[RESEND PATCH] UEFI: Fix several memory leaks of UEFI handles

2025-07-10 Thread Khalid Ali
Fix possible and absolute memory leaks of "handles" returned by grub_efi_locate_handle() using grub_malloc(). Signed-off-by: Khalid Ali --- grub-core/commands/efi/lsefi.c | 1 + grub-core/commands/efi/tpm.c | 2 ++ grub-core/term/efi/serial.c| 4 ++-- grub-core/video/efi_gop.

Re: [RFC PATCH v2 0/2] efi/tpcm: Add Trusted Platform Control

2025-06-28 Thread Khalid Ali
> +/* > + * GRUB -- GRand Unified Bootloader > + * Copyright (C) 2018 Free Software Foundation, Inc. > + * > + * GRUB is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation, either

[RFC PATCH v1] kern/efi: Add centralized UEFI error printer

2025-06-26 Thread Khalid Ali
bugging clarity and code readability. Looking forward for your feedback and what community think of this idea and the code. Additionally i left something i felt worth dicussing with the commuinty, which is if translation is ideal on this context. Best regard khaalid Signed-off-by: Khalid Ali

Re: QEMU and Grub.

2025-06-08 Thread Khalid Ali
iled with the one booting. If that is the case then this is unfortunetly not possible as i know, even if it does not stable (you already saw misaligment issue). The best way is to compile modules with at least grub source compiled. Those distributions maybe have there own fork and do the sam

Re: [RESEND PATCH] UEFI: Fix several memory leaks of UEFI handles

2025-06-06 Thread Khalid Ali
> Hi Khalid Ali, > For pointers, you have to use like port == NULL instead !port Hi Sudhakar Kuppusamy, Well i checked on entire source tree to look for some consistency pattern, and basically both are valid and used. I think it is matter of code author preference. Beside i didn't

[RFC PATCH v1] kern/efi: Add centralized UEFI error printer

2025-05-30 Thread Khalid Ali
e conditional statements. This will improve user experience, debugging clarity and code readability. Looking forward for your feedback and what community think of this idea and the code. Additionally i left something i felt worth dicussing with the commuinty, which is if translation is ideal on th

[RFC Discussion] Proposing an Unstable Repository for GRUB Development

2025-05-27 Thread Khalid Ali
Hey GRUB community, This RFC discussion is about proposing a less stable repository alongside the current official one. The issue I'd like to raise is the slow pace of development. While this slow development helps ensure stability, it can also become a barrier to introducing new features, lim