> Since it doesn't seem possible to have each boot component using the same log
> format, we added a log_format and log_phys_addr fields to give flexibility in
> how logs are stored. An example of a different log format that can be used is
> the cbmem_console log format used by coreboot:
I am not
Standardizing in-memory logging sounds like an interesting idea,
especially with regards to components that can run on top of different
firmware stacks (things like GRUB or TF-A). But I would be a bit wary
of creating a "new standard to rule them all" and then expecting all
projects to switch what
Changed cbmemc to support updated console format from coreboot.
---
grub-core/term/i386/coreboot/cbmemc.c | 50 ---
1 file changed, 35 insertions(+), 15 deletions(-)
diff --git a/grub-core/term/i386/coreboot/cbmemc.c
b/grub-core/term/i386/coreboot/cbmemc.c
index 2
Managed to get it working with serial input now. Found a few issues with my
patch. Will send a new, tested version out.
On Tue, Apr 25, 2017 at 11:48 AM, Julius Werner
wrote:
> Did you check that all implementations use unsigned?
>>
>
> Yes, all the ones that I'm now aware
>
> Did you check that all implementations use unsigned?
>
Yes, all the ones that I'm now aware of used unsigned, 32-bit.
> I am able to build it, I just had to figure out how and install some
>> dependencies. But I tried booting it on an HP Chromebook 14 2013 (falco)
>> and it doesn't seem to r
>
> I'm very concerned with compatibility. You can't guarantee that coreboot
> and payload match. And in case of mismatch you get a memory corruption that
> is very hard to trace. Can we please change signature of cbmem entry?
I would rather allow older implementations to continue working as best
Changed cbmemc to support updated console format from coreboot.
---
grub-core/term/i386/coreboot/cbmemc.c | 44 +--
1 file changed, 32 insertions(+), 12 deletions(-)
diff --git a/grub-core/term/i386/coreboot/cbmemc.c
b/grub-core/term/i386/coreboot/cbmemc.c
index 2
[-seabios for the GRUB part of the thread]
> Could you please also check, if GRUB’s CBMEM console driver, and the
> the command cbmemc to display it need any updates?
>
Thanks, I wasn't aware that GRUB also had a driver for this. I'm happy to
write a patch for it, but unfortunately I'm having so
