Re: [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support

("fs/xfs: Add large extent counters incompat feature > support") > Signed-off-by: Eric Sandeen Good catch. Reviewed-by: Jon DeVree -- Jon Doge Wrangler X(7): A program for managing terminal windows. See also screen(1) and tmux(1). ___ Gru

Re: Grub-devel Digest, Vol 240, Issue 26

On Tue, Feb 20, 2024 at 17:36:35 +0100, Nicolas Frayer wrote: > I think there are more than 4 magic numbers also as I had to put my > code in the direntry loop for it to fix the issue. I think it's > because of the fact that if the directory list fits in an inode it > won't create extent hence no e

Re: [PATCH] fs/xfs: Handle non-continuous data blocks in directory extents

On Thu, Feb 15, 2024 at 20:33:13 +0300, Vladimir 'phcoder' Serbinenko wrote: > Is the pointer guaranteed to be aligned? If not you have to use unaligned > access. I don't know what alignment guarantees grub_malloc() makes. As long as they are close to what the regular C malloc() guarantees then it

[PATCH] fs/xfs: Handle non-continuous data blocks in directory extents

g) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2254370 Signed-off-by: Jon DeVree --- grub-core/fs/xfs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c index bc2224dbb..a6cce9cfe 100644 --- a/grub-core/fs/xfs.c +++ b/grub-core/fs/xfs.c @

[PATCH v4] fs/xfs: Fix XFS directory extent parsing

annah.gnu.org/bugs/?64376 Signed-off-by: Jon DeVree --- grub-core/fs/xfs.c | 51 +- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c index b91cd32b4..acdfb1a7b 100644 --- a/grub-core/fs/xfs.c ++

Re: [PATCH 1/1] fs/xfs: Incorrect short form directory data boundary check

On Mon, Oct 16, 2023 at 19:54:15 +0200, Daniel Kiper wrote: > Jon, may I ask you to take a look at this patch? Does not it conflict > with your XFS patch [1]. > They are similar but distinct code paths. This patch is for the XFS_INODE_FORMAT_INO case, my patch is for the XFS_INODE_FORMAT_EXT and

Re: [PATCH v3] Fix XFS directory extent parsing

On Wed, Oct 04, 2023 at 00:43:18 +, Lidong Chen wrote: > - if (filename + direntry->len - 1 > (char *) tail) > + if (filename + direntry->len + 1 > (char *) end) > return grub_error (GRUB_ERR_BAD_FS, "invalid XFS directory entry"); > > There were these lines in the source after the diff: > >

[PATCH v3] Fix XFS directory extent parsing

found while fuzzing the XFS filesystem) Fixes: b2499b29c (Adds support for the XFS filesystem.) Fixes: https://savannah.gnu.org/bugs/?64376 Signed-off-by: Jon DeVree --- Notes: Changes from v2: * Fix bounds check on filename Changes from v1: * Address review feedback gru

Re: [PATCH v2] Fix XFS directory extent parsing

I'm about to head out camping for a few days so I don't have time to look into this but I think I found another bug in the original fuzzer patch. See below. On Fri, Sep 15, 2023 at 17:51:21 -0400, Jon DeVree wrote: > @@ -917,7 +935,7 @@ grub_xfs_iterate_dir (grub_fshe

[PATCH v2] Fix XFS directory extent parsing

found while fuzzing the XFS filesystem) Fixes: b2499b29c (Adds support for the XFS filesystem.) Fixes: https://savannah.gnu.org/bugs/?64376 Signed-off-by: Jon DeVree --- grub-core/fs/xfs.c | 51 +- 1 file changed, 37 insertions(+), 14 deletions(-) diff

Re: [PATCH] Fix XFS directory extent parsing

On Fri, Sep 15, 2023 at 15:23:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > > @@ -877,9 +883,8 @@ grub_xfs_iterate_dir (grub_fshelp_node_t dir, > > { > > struct grub_xfs_dir2_entry *direntry = > > grub_xfs_first_de(dir->data, > > dirb

[PATCH] Fix XFS directory extent parsing

found while fuzzing the XFS filesystem) Fixes: b2499b29c (Adds support for the XFS filesystem.) Fixes: https://savannah.gnu.org/bugs/?64376 Signed-off-by: Jon DeVree --- grub-core/fs/xfs.c | 59 -- 1 file changed, 41 insertions(+), 18 deletions(-) diff