Re: [PATCH] Remove framework for external modules

2009-08-26 Thread Joe Auricchio
On Tue, Aug 25, 2009 at 14:13, Robert Millan wrote: > > My bad... > > When I proposed adding a framework for building GRUB modules externally, I > was expecting it would end up being used.  I had grub-extras in mind. > > But it became much simpler and straightforwarded to build grub-extras by > ove

Re: [PATCH] UTF-8 to UTF-16 transformation

2009-08-26 Thread Joe Auricchio
On Tue, Aug 25, 2009 at 17:31, Robert Millan wrote: > GNU libc has "iconv" command and "iconv_*" facilities for charset conversion, > how about iconv.mod for consistency? My 2 cents is: that might be confusing. At least, if I saw iconv.mod, I would assume it was really GNU libc's iconv library.

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-24 Thread Joe Auricchio
On Sun, Aug 23, 2009 at 06:07, Robert Millan wrote: > On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >>> >>> So perhaps this can be solved simpler by replacing grub_malloc with >>> grub_zalloc ? >> >> I saw the zalloc commit and th

Re: [PATCH 2/2] Alias cls as clear

2009-07-28 Thread Joe Auricchio
On 25 Jul, 2009, at 09:21 , Robert Millan wrote: On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote: How's this? The ChangeLog entry is incomplete. It should be e.g.: * commands/minicmd.c (grub_mini_cmd_clear): New function. etc. See other entries as an ex

[PATCH] gfxterm clear_char

2009-07-28 Thread Joe Auricchio
t_buffer[i])); } virtual_screen.cursor_x = virtual_screen.cursor_y = 0; Index: src/ChangeLog === --- src.orig/ChangeLog 2009-07-24 17:15:24.0 -0700 +++ src/ChangeLog 2009-07-24 17:18:11.0 -0700 @@ -1,3

Re: [PATCH 2/2] Alias cls as clear

2009-07-23 Thread Joe Auricchio
On 23 Jul, 2009, at 15:42 , Pavel Roskin wrote: On Wed, 2009-07-22 at 22:08 -0700, Joe Auricchio wrote: * commands/minicmd.c: Add clear as alias for cls. My background is in Unix, so 'clear' comes much more naturally to my fingers than 'cls'. But it's bad to c

[PATCH 2/2] Alias cls as clear

2009-07-22 Thread Joe Auricchio
* commands/minicmd.c: Add clear as alias for cls. My background is in Unix, so 'clear' comes much more naturally to my fingers than 'cls'. But it's bad to clutter grub with too many commands. So I leave this to the maintainers: do we add both commands, only one, or neither? -joe --- a/comma

[PATCH 1/2] Add cls command

2009-07-22 Thread Joe Auricchio
* commands/minicmd.c: Add cls command. It's nice to clear the screen once in a while, after a lot of messing around in the command line. -joe --- a/commands/minicmd.c2009-07-07 16:58:05.0 -0700 +++ b/commands/minicmd.c2009-07-22 15:43:30.0 -0700 @@ -336,8 +336,19

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-22 Thread Joe Auricchio
On 22 Jul, 2009, at 10:27 , Robert Millan wrote: On Sat, Jul 18, 2009 at 03:39:00PM -0700, Joe Auricchio wrote: On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: This fixes a 100% reproducible and very annoying bug I've

[PATCH] Call a module's init function only after the module is successfully added

2009-07-20 Thread Joe Auricchio
Hi, * kern/dl.c (grub_dl_load_core): Call grub_dl_call_init only after successful grub_dl_add With this patch the module's init function will no longer be called: - if the module is already loaded - if malloc fails in grub_dl_add - before the module is added to grub_dl_head The first two are er

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of every line has a random

[PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
Hi, My first patch! Please be nice. * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer instead of leaving it uninitialized. This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of