Re: [PATCH] cryptodisk: add luks_recover_key attempts option

2019-11-02 Thread Jason Kushmaul
Hi Daniel, Please see revised patch addressing all of your comments in the attached patch file. Jason From 7a2b845f421d8605e139b2a7e41c2d7722c969c3 Mon Sep 17 00:00:00 2001 From: "Jason J. Kushmaul" Date: Sat, 20 Jul 2019 17:03:01 -0400 Subject: [PATCH] cryptodisk: add luks_recover_key attempts

[PATCH] cryptodisk: add luks_recover_key attempts option

2019-10-04 Thread Jason Kushmaul
Hello, Daniel or other reviewer, I was hoping to get a review for my accessibility patch offering motor impaired individuals more access to full disk encrypted disks, by allowing a configurable retry option. I've addressed the review items from before from Daniel From d135f9f6b7d1503f551e8cced9

Re: [PATCH] cryptodisk: add luks_recover_key attempts

2019-08-24 Thread Jason Kushmaul
Hello, I've updated the patch addressing the issues and just wanted to give this a bump. I wasn't sure about the longer commit message - if you had meant my email with headers and sections outlined with asterisks. That seemed to verbose to me for that have been what you meant. If it was I will

Re: [PATCH] cryptodisk: add luks_recover_key attempts

2019-07-21 Thread Jason Kushmaul
Hi and thanks for the helpful review. I wasn't sure about the commit message - if you had meant my email with headers and sections outlined with asterisks. That seemed to verbose to me but I'm not sure what other message you would have seen. I can update if needed. I had to grub_errno because th

Re: [PATCH] cryptodisk: add luks_recover_key attempts

2019-07-05 Thread Jason Kushmaul
ng you may require. Jason On Sat, Jun 29, 2019 at 9:44 PM Jason Kushmaul wrote: > Add a configurable option for luks key recovery. Existing > users will continue to have the default of 1 attempt. > > Cryptodisk is not accessible to motor impaired individuals > who may need the extra a

[PATCH] cryptodisk: add luks_recover_key attempts

2019-06-29 Thread Jason Kushmaul
Add a configurable option for luks key recovery. Existing users will continue to have the default of 1 attempt. Cryptodisk is not accessible to motor impaired individuals who may need the extra attempts without having to reboot or manually rescue only to be asked again. Reported-by: Jason J. Kus

Re: cryptodisk enabled returns to rescue prompt

2019-06-29 Thread Jason Kushmaul
I'm sending this in a new thread using `git format-patch` On Tue, Jun 25, 2019 at 12:48 AM Jason Kushmaul wrote: > Hello, > > I'm new to the list. I've been working on this myself for personal > reasons. I think this should be viewed as an accessibility issue, not

Re: cryptodisk enabled returns to rescue prompt

2019-06-24 Thread Jason Kushmaul
Hello, I'm new to the list. I've been working on this myself for personal reasons. I think this should be viewed as an accessibility issue, not as a convenience. Those that have motor impairments have a very difficult time booting their machines without a reboot, or rescue. Please see my patch