Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Jan Beulich via Grub-devel
On 14.03.2024 15:24, Ross Lagerwall wrote: > On Thu, Mar 14, 2024 at 1:37 PM Jan Beulich wrote: >> On 14.03.2024 10:30, Ross Lagerwall wrote: >>> On Thu, Mar 14, 2024 at 7:24 AM Jan Beulich wrote: >>>> On 13.03.2024 16:07, Ross Lagerwall wrote: >>>>>

Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Jan Beulich via Grub-devel
On 14.03.2024 10:30, Ross Lagerwall wrote: > On Thu, Mar 14, 2024 at 7:24 AM Jan Beulich wrote: >> >> On 13.03.2024 16:07, Ross Lagerwall wrote: >>> In addition to the existing address and ELF load types, specify a new >>> optional PE binary load type. This ne

Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Jan Beulich via Grub-devel
On 13.03.2024 16:07, Ross Lagerwall wrote: > In addition to the existing address and ELF load types, specify a new > optional PE binary load type. This new type is a useful addition since > PE binaries can be signed and verified (i.e. used with Secure Boot). And the consideration to have ELF signa

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-06 Thread Jan Beulich via Grub-devel
On 01.04.2021 21:43, Andrew Cooper wrote: > On 01/04/2021 09:44, Roger Pau Monné wrote: >> On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: >>> On 01.04.2021 03:06, Roman Shaposhnik wrote: >>>> And the obvious next question: is my EVE usecase esoteric eno

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-01 Thread Jan Beulich via Grub-devel
On 01.04.2021 03:06, Roman Shaposhnik wrote: > And the obvious next question: is my EVE usecase esoteric enough that > I should just go ahead and do a custom GRUB patch or is there a more > general interest in this? Not sure if it ought to be a grub patch - the issue could as well be dealt with in

Re: [Xen-devel] Uniform commands for booting xen

2016-01-11 Thread Jan Beulich
>>> On 11.01.16 at 15:58, wrote: > On 11.01.2016 15:32, Jan Beulich wrote: >>>>> On 11.01.16 at 15:06, wrote: >>> On 13.11.2015 10:50, Ian Campbell wrote: >>>> On Fri, 2015-11-13 at 12:04 +0300, Andrei Borzenkov wrote: >>>>&g

Re: [Xen-devel] Uniform commands for booting xen

2016-01-11 Thread Jan Beulich
>>> On 11.01.16 at 15:06, wrote: > On 13.11.2015 10:50, Ian Campbell wrote: >> On Fri, 2015-11-13 at 12:04 +0300, Andrei Borzenkov wrote: How do you express modules other than kernel+initrd in that scheme, without grub needing to be aware of any new addition we may find necessary go

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Jan Beulich
>>> On 12.11.15 at 18:09, wrote: > On Thu, 2015-11-12 at 08:44 -0700, Jan Beulich wrote: >> > > > On 12.11.15 at 14:41, wrote: >> > Hello, all. I'd like to have set of commands that would boot xen on all >> > platforms. I thought of followi

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Jan Beulich
>>> On 12.11.15 at 17:58, wrote: > 12.11.2015 18:44, Jan Beulich пишет: >>>>> On 12.11.15 at 14:41, wrote: >>> Hello, all. I'd like to have set of commands that would boot xen on all >>> platforms. I thought of following set: >>&

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Jan Beulich
>>> On 12.11.15 at 14:41, wrote: > Hello, all. I'd like to have set of commands that would boot xen on all > platforms. I thought of following set: > > xen_hypervisor FILE XEN_OPTIONS > xen_kernel FILE KERNEL_OPTIONS > xen_initrd INITRD INITRD INITRD > all initrds are concatenated. > xen_xsm ???

Re: [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-09-23 Thread Jan Beulich
>>> On 22.09.15 at 19:03, wrote: > On Thu, Aug 27, 2015 at 06:43:39AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > +#define __packed __attribute__((__packed__)) >> > +#define __text__attribute__

Re: [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 17:21, wrote: > On Thu, Aug 27, 2015 at 06:01:26AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > @@ -130,6 +146,119 @@ print_err: >> > .Lhalt: hlt >> > jmp .Lhalt >> > >

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-09-01 Thread Jan Beulich
>>> On 31.08.15 at 21:49, wrote: > On Fri, Aug 28, 2015 at 08:16:05AM -0600, Jan Beulich wrote: >> >>> On 28.08.15 at 15:42, wrote: >> > Now that said - do you have suggestions on how to make this work >> > with GRUB in the picture? >> >>

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
>>> On 27.08.15 at 17:29, wrote: > You're right, there's no such requirement on memory use in the spec. > But you're missing the point. Supporting grub2 on UEFI is already a > hack (ignoring all intentions EFI had from its first days). And now > you've found an environment where that hack needs an

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
>>> On 28.08.15 at 15:42, wrote: > And I am not comfortable to say 'GRUB2+Xen cannot run on this hardware > because your firmware vendor is not following the EFI spec in spirit.' Well, not the least since I don't really agree with this (albeit I can see where you're coming from) ... > Now that s

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
>>> On 27.08.15 at 19:56, <426...@gmail.com> wrote: >> If you advocate direct booting ( no boot loader) on production machines I > wont argue much, as long as there is good recovery tools to deal with > failed boots (grub does this very well, I am not aware of anything > comparable that is pure ef

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 20:04, wrote: > On 27/08/15 16:29, Jan Beulich wrote: >>>>> On 27.08.15 at 17:10, wrote: >>> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >>>>>>> On 20.07.15 at 16:29, wrote: >>>

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 17:10, wrote: > On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > /* Copy bootstrap trampoline to low memory, below 1MB. */ >> > -mov $sym_phys(trampoline

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > - %fs register is filled with segment descriptor which describes memory > region > with Xen image (it could be relocated or not); This is too fuzzy. Please be very precise which region it is that %fs is supposed to point to (so that reviewers have a chanc

Re: [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code w

Re: [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Signed-off-by: Daniel Kiper For a patch of this size, no description at all seems rather problematic. > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -89,6 +89,13 @@ multiboot1_header_end: > 0, /* Number of the lines

Re: [PATCH v2 19/23] x86/efi: create new early memory allocator

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > There is a problem with place_string() which is used as early memory > allocator. It gets memory chunks starting from start symbol and > going down. Sadly this does not work when Xen is loaded using multiboot2 > protocol because start lives on 1 MiB address. So,

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-26 Thread Jan Beulich
>>> On 26.08.15 at 14:33, wrote: > Do you suggest that I should put this functionality (PE with multiboot > headers) on top of this patch series? Well, it is possible but this > series is big and I would like to avoid to make it bigger. I prefer to > get current patches into Xen tree and then work

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-25 Thread Jan Beulich
>>> On 25.08.15 at 18:31, wrote: > On Tue, Aug 25, 2015 at 06:09:09AM -0600, Jan Beulich wrote: >> >>> On 24.08.15 at 22:54, wrote: >> > On Mon, Aug 24, 2015 at 05:35:21AM -0600, Jan Beulich wrote: >> >> >>> On 22.08.15 at 15:59, wro

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-25 Thread Jan Beulich
>>> On 24.08.15 at 22:54, wrote: > On Mon, Aug 24, 2015 at 05:35:21AM -0600, Jan Beulich wrote: >> >>> On 22.08.15 at 15:59, wrote: >> > On Thu, Aug 20, 2015 at 09:39:39AM -0600, Jan Beulich wrote: >> >> >>> On 20.07.15 at 16:29, wrote

Re: [PATCH v2 09/23] efi: create efi_enabled()

2015-08-24 Thread Jan Beulich
>>> On 22.08.15 at 14:33, wrote: > On Thu, Aug 20, 2015 at 09:18:17AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > --- a/xen/arch/x86/efi/stub.c >> > +++ b/xen/arch/x86/efi/stub.c >> > @@ -4,9 +4,14 @@ >>

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-24 Thread Jan Beulich
>>> On 22.08.15 at 15:59, wrote: > On Thu, Aug 20, 2015 at 09:39:39AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > Build xen.gz with EFI code. We need this to support multiboot2 >> > protocol on EFI platforms. >> > &g

Re: [PATCH v2 14/23] efi: split out efi_find_gop_mode()

2015-08-20 Thread Jan Beulich
al check here. Similarly in patch 17. With these minor adjustments, all the "efi: split out efi_..." patches Acked-by: Jan Beulich Jan ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-20 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Build xen.gz with EFI code. We need this to support multiboot2 > protocol on EFI platforms. > > If we wish to load not ELF file using multiboot (v1) or multiboot2 then DYM "a non-ELF file"? > it must contain "linear" (or "flat") representation of code and data

Re: [PATCH v2 09/23] efi: create efi_enabled()

2015-08-20 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > --- a/xen/arch/x86/efi/stub.c > +++ b/xen/arch/x86/efi/stub.c > @@ -4,9 +4,14 @@ > #include > #include > > -#ifndef efi_enabled > -const bool_t efi_enabled = 0; > -#endif > +struct efi __read_mostly efi = { > + .flags = 0, /* Initialized later. */ > +

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 18.08.15 at 14:00, wrote: > On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > @@ -119,10 +213,11 @@ __start: >> > >> > /* Save the Multiboot info struct (after relocation) f

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
multiboot2.h to Makefile > (suggested by Jan Beulich), With the compiler.h inclusion done I don't think this is as necessary anymore as it was previously. >- isolated/stray __packed attribute usage for multiboot2_memory_map_t > (suggested by Jan Beulich). This one I don'

Re: [PATCH v2 07/23] x86/boot/reloc: Rename some variables and rearrange code a bit

2015-08-17 Thread Jan Beulich
n. > > Signed-off-by: Daniel Kiper Acked-by: Jan Beulich ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 05/23] x86/boot/reloc: create generic alloc and copy functions

2015-08-17 Thread Jan Beulich
ions/fixes: >- generalize new functions names > (suggested by Jan Beulich), >- reduce number of casts > (suggested by Jan Beulich). This contradicts retaining Andrew's R-b tag. Please remember to drop tags for everything you make non-trivial changes to. > @@ -55

Re: [PATCH v2 04/23] x86/boot: call reloc() using cdecl calling convention

2015-08-17 Thread Jan Beulich
>>> On 20.07.15 at 16:28, wrote: An empty description leaves us guess at the "why". > --- a/xen/arch/x86/boot/reloc.c > +++ b/xen/arch/x86/boot/reloc.c > @@ -10,15 +10,27 @@ > *Keir Fraser > */ > > -/* entered with %eax = BOOT_TRAMPOLINE */ > +/* > + * This entry point is entered from

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-14 Thread Jan Beulich
>>> On 14.08.15 at 16:37, wrote: > On Fri, Aug 14, 2015 at 08:32:05AM -0600, Jan Beulich wrote: >> >>> On 14.08.15 at 15:59, wrote: >> > On Fri, Aug 14, 2015 at 06:49:18AM -0600, Jan Beulich wrote: >> >> >>> On 14.08.15 at 13:52, wrote:

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-14 Thread Jan Beulich
>>> On 14.08.15 at 15:59, wrote: > On Fri, Aug 14, 2015 at 06:49:18AM -0600, Jan Beulich wrote: >> >>> On 14.08.15 at 13:52, wrote: >> > On Tue, Aug 11, 2015 at 12:48:06PM -0400, Konrad Rzeszutek Wilk wrote: >> >> On Mon, Jul 20, 2015 at 04:29:17PM

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-14 Thread Jan Beulich
>>> On 14.08.15 at 13:52, wrote: > On Tue, Aug 11, 2015 at 12:48:06PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Jul 20, 2015 at 04:29:17PM +0200, Daniel Kiper wrote: >> > diff --git a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h >> > index 87b3341..27481ac 100644 >> > --- a/xen/inc

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-14 Thread Jan Beulich
>>> On 13.08.15 at 21:22, wrote: > On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: >> > @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER >> > / >> > .long -(MULTIBOOT_HEA

Re: [PATCH v2 00/23] x86: multiboot2 protocol support

2015-07-21 Thread Jan Beulich
>>> On 20.07.15 at 16:28, wrote: > This series, in general, is not targeted to Xen 4.6. However, there are > some fixes at the beginning of it which are worth considering, I think. I looked at the first few, and didn't spot any fixes. If you meant just cleanup or other cosmetic adjustments, then

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:57, wrote: > On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 15:26, wrote: >> > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >> >>> On 27.03.15 at 14:06, wro

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:26, wrote: > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:06, wrote: >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: &

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:09, wrote: > On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:53, wrote: >> > On 27/03/15 13:43, Jan Beulich wrote: >> >>>>> On 27.03.15 at 14:32, wrote: >> >>> On

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:53, wrote: > On 27/03/15 13:43, Jan Beulich wrote: >>>>> On 27.03.15 at 14:32, wrote: >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >>>>>>> On 30.01.15 at 18:54, wrote: >>>>> We ne

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:32, wrote: > On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > We need more fine grained knowledge about EFI environment and check >> > for EFI platform and EFI loader s

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:06, wrote: > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +/* Skip Multiboot2 information fixed part */ >> > +lea MB2_fixed_sizeof(%ebx),%ecx >

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:57, wrote: > On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +{ >> > +void *ptr; >> > + >> > +/* >> > + * Init __malloc_free on r

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:22, wrote: > On Fri, Mar 27, 2015 at 11:20:10AM +, Jan Beulich wrote: >> >>> On 27.03.15 at 11:56, wrote: >> > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >> >>> On

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:00, wrote: > Additionally, efi_start() > is architecture independent and efi_multiboot2() is x86 only and it should > live in x86 files. Is that really the case? Looking at the grub2 sources I see support for other than x86... Jan _

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 12:14, wrote: > IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't help us, as we need to be able to mix

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 11:56, wrote: > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > --- a/xen/arch/x86/boot/Makefile >> > +++ b/xen/arch/x86/boot/Makefile >> > @@ -1,6 +1,7 @@ >&

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-17 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > @@ -94,6 +111,17 @@ ENTRY(start) > gdt_boot_descr: > .word 6*8-1 > .long sym_phys(trampoline_gdt) > +.long 0 /* Needed for 64-bit lgdt */ > + > +cs32_switch_addr: > +.long sym_phys(cs32_switch) > +.long BOOT_CS

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-03 Thread Jan Beulich
>>> On 03.03.15 at 00:40, wrote: > Reviewing the #ifndef CONFIG_ARM in EFI code, and the efi_enabled > usage elsewhere, > the remaining EFI tasks on ARM look like: > * Support for SetVirtualAddressMap > * Runtime service support - looks like just time function used by x86 > in get_cmos_time() * P

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-03 Thread Jan Beulich
>>> On 02.03.15 at 21:25, wrote: > On Mon, Mar 2, 2015 at 9:23 AM, Jan Beulich wrote: >>>>> On 30.01.15 at 18:54, wrote: >>> @@ -192,12 +218,7 @@ static void __init >>> efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, >>> >&g

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-02 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -103,9 +103,35 @@ static void __init relocate_trampoline(unsigned long > phys) > *(u16 *)(*trampoline_ptr + (long)trampoline_ptr) = phys >> 4; > } > > +#define __MALLOC_SIZE

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-02 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > ..which gets memory map and calls ExitBootServices(). We need this > to support multiboot2 protocol on EFI platforms. Patches from 9 up to here all make sense on the basis that patch 18 does and assuming that you really need all this code moved out to separate f

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-02 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > --- a/xen/arch/x86/efi/Makefile > +++ b/xen/arch/x86/efi/Makefile > @@ -1,14 +1,14 @@ > CFLAGS += -fshort-wchar > > -obj-y += stub.o > +obj-y += boot.o > +obj-y += compat.o > +obj-y += runtime.o So how is this going to work with a compiler not new enough to s

Re: [PATCH 07/18] efi: run EFI specific code on EFI platform only

2015-02-20 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > --- a/xen/arch/x86/shutdown.c > +++ b/xen/arch/x86/shutdown.c > @@ -504,7 +504,8 @@ void machine_restart(unsigned int delay_millisecs) > tboot_shutdown(TB_SHUTDOWN_REBOOT); > } > > -efi_reset_system(reboot_mode != 0); > +if ( efi_platform

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-02-20 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > We need more fine grained knowledge about EFI environment and check > for EFI platform and EFI loader separately to properly support > multiboot2 protocol. ... because of ... (i.e. I can't see from the description what the separation is good for). Looking at the

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-02-20 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -1,6 +1,7 @@ > obj-bin-y += head.o > > -RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h > $(BASEDIR)/include/xen/multiboot.h > +RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h > $(BAS

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-11 Thread Jan Beulich
>>> On 10.02.15 at 22:27, wrote: > After some testing we have found at least one machine on which this thing > does not work. It is Dell PowerEdge R820 with latest firmware. Machine > crashes/stops because early 32-bit code is not relocatable and must live > under 0x10 address. (side note: I a

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-10 Thread Jan Beulich
>>> On 09.02.15 at 18:59, wrote: > On Fri, Jan 30, 2015 at 06:54:04PM +0100, Daniel Kiper wrote: >> I am sending, long awaited, first version of multiboot2 protocol >> support for legacy BIOS and EFI platforms. >> >> The final goal is xen.efi binary file which could be loaded by EFI >> loader, mul

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-05 Thread Jan Beulich
>>> On 05.02.15 at 12:50, wrote: > Le 2015-02-04 10:51, "Jan Beulich" a écrit : >> >> >>> On 04.02.15 at 10:04, wrote: >> > On 03/02/2015 17:14, Daniel Kiper wrote: >> >> On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wr

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-04 Thread Jan Beulich
>>> On 04.02.15 at 10:04, wrote: > On 03/02/2015 17:14, Daniel Kiper wrote: >> On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wrote: >>>>>> On 30.01.15 at 18:54, wrote: >>>> - xen.efi build will not so strongly depend >>>>

Re: [PATCH 02/18] x86/boot/reloc: create generic alloc and copy functions

2015-02-03 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > --- a/xen/arch/x86/boot/reloc.c > +++ b/xen/arch/x86/boot/reloc.c > @@ -33,9 +33,10 @@ asm ( > typedef unsigned int u32; > #include "../../../include/xen/multiboot.h" > > -static void *reloc_mbi_struct(void *old, unsigned int bytes) > +static u32 alloc_struct

Re: [PATCH 03/18] x86/boot: use %ecx instead of %eax

2015-02-03 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > /* Save the Multiboot info struct (after relocation) for later use. > */ > mov $sym_phys(cpu0_stack)+1024,%esp > -push%ebx > -callreloc > +mov %ecx,%eax > +push%ebx/* Multiboot

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-02 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > - xen.efi build will not so strongly depend > on a given GCC and binutils version. While I can see the possibility of making the binutils version dependency go away (by manually creating the PE header), I can't see how you'd overcome the gcc one: The MS ca

Re: [Xen-devel] Loading a 32 bit kernel from 64 bit grub-xen

2014-07-02 Thread Jan Beulich
>>> On 01.07.14 at 20:27, wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 7/1/2014 12:18 PM, Andrey Borzenkov wrote: >> В Tue, 01 Jul 2014 12:06:08 -0400 Phillip Susi >> пишет: >> >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >>> I have been trying to fix grub to load a

Re: EFI and multiboot2 devlopment work for Xen

2013-10-29 Thread Jan Beulich
>>> On 28.10.13 at 19:01, Vladimir 'f-coder/phcoder' >>> Serbinenko wrote: Will a multiboot2 tag with whole EFI memory map solve your problem? >>> I added such a tag in documentation and wrote a patch for it (attached). >>> Awaiting for someone to test it to commit >> >> Great! I think from

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Jan Beulich
>>> Vladimir 'φ-coder/phcoder' Serbinenko 10/23/13 7:02 PM >>> >>> >> GrUB - which iiuc stays in memory >> after transferring control - could export its file system support to its >> descendants). > >Xen shouldn't need to load any file after multiboot2 entry point. The >needed files would already

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 10/23/13 3:15 PM >>> >On Wed, Oct 23, 2013 at 09:32:30AM +0100, Ian Campbell wrote: >> Am I correct that xen.efi today can be loaded from grub today using the >> chainload command? Whereupon it will parse the xen.cfg and load the dom0 >> kernel and load things from FAT et

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Jan Beulich
>>> Ian Campbell 10/23/13 10:32 AM >>> >The second (standard PE/COFF entry point) can be launched using the UEFI >chainloader call. AIUI this should work with xen.efi today. There are >some limitations however, firstly there is no way to pass additional >blobs and so the launched image must load e

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 22.10.13 at 16:51, Konrad Rzeszutek Wilk wrote: > And I still haven't found the module that can launch any PE/COFF > image from GRUB2. Maybe that is a myth. I can't exclude that this is a custom a patch as the linuxefi support. Jan ___ Grub-de

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 22.10.13 at 11:45, Ian Campbell wrote: > On Tue, 2013-10-22 at 10:31 +0100, Jan Beulich wrote: >> >>> On 22.10.13 at 11:26, Ian Campbell wrote: >> > AIUI "efilinux" is somewhat badly named and does not use the Linux Boot >> > Protoc

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 22.10.13 at 15:53, Ian Campbell wrote: > On Tue, 2013-10-22 at 09:42 -0400, Konrad Rzeszutek Wilk wrote: > >> Looking at the Fedora GRUB2 source, the 'struct linux_kernel_header' is > defined >> in the linux/Documentation/x86/boot.txt and hpa is pretty strict >> about making it backwards

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 22.10.13 at 11:26, Ian Campbell wrote: > AIUI "efilinux" is somewhat badly named and does not use the Linux Boot > Protocol (i.e. the (b)zImage stuff with real mode entry point) either. > It actually loads and executes the kernel binary as a PE/COFF executable > (the native UEFI binary exec

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 21.10.13 at 20:39, Daniel Kiper wrote: > On Mon, Oct 21, 2013 at 02:36:38PM +0100, Jan Beulich wrote: >> >>> On 21.10.13 at 14:57, Daniel Kiper wrote: >> > Separate multiboot2efi module should be established. It should verify >> > system >

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Jan Beulich
>>> On 21.10.13 at 20:46, Daniel Kiper wrote: > On Mon, Oct 21, 2013 at 03:37:21PM +0100, Jan Beulich wrote: >> >>> On 21.10.13 at 16:23, Konrad Rzeszutek Wilk >> >>> wrote: >> > However my understanding is that the general distro approach is

Re: EFI and multiboot2 devlopment work for Xen

2013-10-21 Thread Jan Beulich
>>> On 21.10.13 at 16:23, Konrad Rzeszutek Wilk wrote: > On Mon, Oct 21, 2013 at 02:36:38PM +0100, Jan Beulich wrote: >> >>> On 21.10.13 at 14:57, Daniel Kiper wrote: >> >> (Looking at the Cc list it's quite interesting that you copied a >> wh

Re: EFI and multiboot2 devlopment work for Xen

2013-10-21 Thread Jan Beulich
>>> On 21.10.13 at 14:57, Daniel Kiper wrote: (Looking at the Cc list it's quite interesting that you copied a whole lot of people, but not me as the maintainer of the EFI bits in Xen.) > Separate multiboot2efi module should be established. It should verify system > kernel and all loaded modules