Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.

2013-12-31 Thread Francesco Lavra
On 12/29/2013 07:47 PM, Ian Campbell wrote: > diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c > index b4216ff..186d259 100644 > --- a/util/grub-mkimagexx.c > +++ b/util/grub-mkimagexx.c > @@ -378,6 +378,7 @@ SUFFIX (relocate_symbols) (Elf_Ehdr *e, Elf_Shdr > *sections, >

Re: [PATCH] add fdt prerequisites for arm64 UEFI Linux loader

2013-12-17 Thread Francesco Lavra
On 12/16/2013 02:52 PM, Leif Lindholm wrote: > diff --git a/grub-core/lib/fdt.c b/grub-core/lib/fdt.c > index 9f34dc7..fb13672 100644 > --- a/grub-core/lib/fdt.c > +++ b/grub-core/lib/fdt.c > @@ -423,3 +423,31 @@ int grub_fdt_set_prop (void *fdt, unsigned int > nodeoffset, const char *name, >g

Re: fdt: fix for add_subnode()

2013-12-05 Thread Francesco Lavra
Hi, On 12/04/2013 04:28 PM, Leif Lindholm wrote: > The current fdt support fails to update the size of the dt_struct after > adding a new node. Attached is the suggested fix. Looks ok to me. -- Francesco ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [RFT] Rewrite timer on arm efi and remove leftover in startup code

2013-10-28 Thread Francesco Lavra
Hi, On 10/07/2013 01:30 PM, Leif Lindholm wrote: > Hmm - trunk does not however seem to be able to successfully boot a > Linux kernel on ARM/UEFI currently. I will look into that. You may have run into the same issues I run into when I try booting a Linux kernel with device tree. See my patch at

[PATCH] grub-core/lib/fdt.c: Working device tree library

2013-10-28 Thread Francesco Lavra
|4 ++ grub-core/lib/fdt.c | 136 --- 2 files changed, 89 insertions(+), 51 deletions(-) diff --git a/ChangeLog b/ChangeLog index bdd2c80..ad30352 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2013-10-28 Francesco Lavra + +

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-25 Thread Francesco Lavra
On 07/25/2013 04:36 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 21.07.2013 15:20, Francesco Lavra wrote: >> Since the last merge of mainline into the arm branch, building for arm >> fails because commands/boot.c is not compiled anymore. The boot module >>

Re: ARM how-to?

2013-07-21 Thread Francesco Lavra
On 07/21/2013 10:57 AM, Andrey Borzenkov wrote: > В Thu, 18 Jul 2013 18:47:11 +0100 > Leif Lindholm пишет: > >> On 18 July 2013 17:58, Andrey Borzenkov wrote: >>> Could someone provide simple steps how to actually use ARM port? As I >>> understand core.img need to be installed as payload for nat

Re: [PATCH] remove Makefile.libfdt.def from EXTRA_DIST

2013-07-21 Thread Francesco Lavra
On 07/20/2013 01:52 PM, Andrey Borzenkov wrote: > libfdt was removed in phco...@gmail.com-20130517115847-6gr15337m1ge8zh3 > Makefile.libfdt.def was missed from cleanup. > > Signed-off-by: Andrey Borzenkov > > --- > conf/Makefile.extra-dist | 1 - > 1 file changed, 1 deletion(-) > > diff --git

[PATCH] [ARM] Enable boot module for arm

2013-07-21 Thread Francesco Lavra
Since the last merge of mainline into the arm branch, building for arm fails because commands/boot.c is not compiled anymore. The boot module should be enabled for arm too. 2013-07-21 Francesco Lavra * grub-core/Makefile.core.def (boot): Enable on ARM. === modified file 'grub

Re: [PATCH 2/2] ls core command: handle listing of the root directory

2013-06-02 Thread Francesco Lavra
On 05/18/2013 12:26 PM, Francesco Lavra wrote: > On 05/12/2013 12:56 PM, Francesco Lavra wrote: >> Currently, listing of the root directory of a device with the command: >> ls (device_name) >> requires the underlying filesystem driver to handle an empty path >> s

[PATCH] Fix listing of directory contents for root device

2013-06-02 Thread Francesco Lavra
Since revision 5010, issuing the ls command with a path not including the device name results in a NULL pointer dereference. This patch fixes the above by reverting one of the three hunks of the patch applied to create revision 5010. Regards, Francesco 2013-06-02 Francesco Lavra

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-05-19 Thread Francesco Lavra
On 05/17/2013 01:49 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > I applied this to ARM branch after fixing several grave problems > including attempts to free statically allocated memory. The files > originally didn't even compile. You seem to have missed the follow-up e-mail I sent on April

Re: [RFT] Caches on ARMv7

2013-05-19 Thread Francesco Lavra
Hi, On 05/17/2013 01:40 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Hello, all. I've changed in arm branch to detect cache type on runtime > rather than compile time. Now a version compiled for armv6 should work > on armv7 as well thus avoiding the need of two separate binaries. As an > add

Re: [PATCH 2/2] ls core command: handle listing of the root directory

2013-05-18 Thread Francesco Lavra
On 05/12/2013 12:56 PM, Francesco Lavra wrote: > Currently, listing of the root directory of a device with the command: > ls (device_name) > requires the underlying filesystem driver to handle an empty path > string as if it was the root directory path "/". This introdu

[PATCH 2/2] ls core command: handle listing of the root directory

2013-05-12 Thread Francesco Lavra
t; is the function grub_core_cmd_ls(), so that handling from each filesystem driver is not required anymore. 2013-05-12 Francesco Lavra * grub-core/kern/corecmd.c (grub_core_cmd_ls): Handle listing of the root directory. === modified file 'grub-core/kern/corecmd.c'

[PATCH 1/2] ls core command: remove unreachable code

2013-05-12 Thread Francesco Lavra
The path local variable in grub_core_cmd_ls() is assigned values such that it cannot be NULL, so a couple of if blocks can be removed as they are never executed. 2013-05-12 Francesco Lavra * grub-core/kern/corecmd.c (grub_core_cmd_ls): Remove unreachable code. === modified file

PATCH [0/2] ls core command: cleanup and fix

2013-05-12 Thread Francesco Lavra
This 2-patch series contains changes to grub-core/kern/corecmd.c (grub_core_cmd_ls): the first patch removes unreachable code, while the second one handles correctly listing of the root directory of a device without requiring duplicated handling from each filesystem driver. -- Francesco _

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-05-11 Thread Francesco Lavra
On 05/09/2013 08:08 PM, Leif Lindholm wrote: > Attached is a patch that: > - incoorporates Francesco's bug fixes > - splits out relocation work into dl_helper.c > - cleans up code slightly > - makes relocations use le_to_cpu/cpu_to_le > - changes all grub_util printout calls to grub_dprintf [...]

Re: ARM automated testing

2013-05-11 Thread Francesco Lavra
On 05/11/2013 04:02 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which QEMU target would be the most appropriate for automated testing? > What is the matching u-boot target? > What about arm-efi in qemu? As far as EFI is concerned, the only target with an EFI firmware working in qemu that I'

Re: ARM branch

2013-05-04 Thread Francesco Lavra
Hi, On 05/01/2013 08:32 PM, Leif Lindholm wrote: > On Fri, Apr 12, 2013 at 07:33:21PM +0200, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> Hello, all. I've uploaded Leif's and my ARM code to >> http://bzr.savannah.gnu.org/lh/grub/branches/arm/changes. Francesco's >> code will be added as well

Re: [PATCH, RFT] ubootnet

2013-04-13 Thread Francesco Lavra
On 04/10/2013 01:19 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On Raspberry pi u-boot doesn't support network. Could someone test this? I'm unable to test it, I just have a couple of minor comments. > --- grub-core/net/drivers/uboot/ubootnet.c1970-01-01 00:00:00 + > +++ grub-core/

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-07 Thread Francesco Lavra
On 04/01/2013 06:42 PM, Francesco Lavra wrote: > On 04/01/2013 04:16 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> Could you put the library itself into a separate tar rather than patch? > > I recall you saying a few months ago that you'd prefer rather wit

Re: [PATCH 6/7] add ARM Linux loader

2013-04-07 Thread Francesco Lavra
Hi, I noticed another minor issue in this patch. On 03/24/2013 06:01 PM, Leif Lindholm wrote: > --- grub-core/loader/arm/linux.c 1970-01-01 00:00:00 + > +++ grub-core/loader/arm/linux.c 2013-03-24 13:49:04 + [...] > +static grub_err_t > +grub_cmd_initrd (grub_command_t cmd __attr

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-04 Thread Francesco Lavra
[Using reply-to-all now...] On 04/04/2013 09:02 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 4/4/2013 2:22 PM, Francesco Lavra wrote: >> On 04/02/2013 10:39 PM, Phillip Susi wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 &

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-04 Thread Francesco Lavra
On 04/02/2013 10:39 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Your patches can not be reviewed inline because your mail client is > incorrectly setting the mime type to application/octet-stream and the > disposition to attachment. Please fix this. Actually the

Re: [PATCH] Add missing ARM relocation codes and fix existing ones

2013-04-01 Thread Francesco Lavra
On 03/17/2013 09:36 PM, Francesco Lavra wrote: > I'm working on the GRUB port to ARM using the EFI platform. When > generating a relocatable ARM image, some relocation entries use a > relocation code (0x33) which is not defined in include/grub/elf.h. So I > went through the late

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:16 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Could you put the library itself into a separate tar rather than patch? I recall you saying a few months ago that you'd prefer rather without libfdt. In fact, libfdt contains much more than what is needed by GRUB. I rewrote the

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === added file 'grub-core/kern/arm/efi/misc.c' > --- grub-core/kern/arm/efi/misc.c 1970-01-01 00:00:00 + > +++ grub-core/kern/arm/efi/misc.c 2013-03-24 15:43:19 + [...] > +void * > +grub_efi_allocate_loader_memory (grub_uint32_t min_off

Re: [PATCH 6/7] add ARM Linux loader

2013-04-01 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === added directory 'grub-core/loader/arm' > === added file 'grub-core/loader/arm/linux.c' > --- grub-core/loader/arm/linux.c 1970-01-01 00:00:00 + > +++ grub-core/loader/arm/linux.c 2013-03-24 13:49:04 + > @@ -0,0 +1,405 @@ > +/* lin

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:16 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 01.04.2013 16:10, Francesco Lavra wrote: > >> On 04/01/2013 01:23 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> get_time is wrong function for getting tsc. You should create

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 01:24 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 01.04.2013 11:53, Francesco Lavra wrote: > >> On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>>> Which architecture is raspberry pie? I have one here and

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 01:23 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > get_time is wrong function for getting tsc. You should create a timer > event with 1 units (=1 ms) and in its callback increase millisecond > counter. The problem is that such timer event would be machine-specific and would

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:31 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> +static grub_uint64_t > >> +grub_efi_get_time_ms(void) >> +{ >> + grub_efi_time_t now; >> + grub_uint64_t retval; >> + grub_efi_status_t status; >> + >> + status = efi_call_2 (grub_efi_system_table->runtime_services->get_t

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which architecture is raspberry pie? I have one here and it would be > good if I could use it for testing. It's ARMv6, so unfortunately it's not supported by this port, which works only on ARMv7. > >> +#define GRUB_KERNEL_MAC

Re: [PATCH 2/7] Initial support for ARMv7 architecture

2013-04-01 Thread Francesco Lavra
On 04/01/2013 03:28 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> +grub_err_t >> +reloc_thm_call (grub_uint16_t *target, Elf32_Addr sym_addr) >> +{ >> + grub_int32_t offset, offset_low, offset_high; >> + grub_uint32_t sign, j1, j2, is_blx; >> + grub_uint32_t insword, insmask; >> + >> + /*

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-03-30 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === modified file 'docs/grub.texi' > --- docs/grub.texi2013-03-07 07:17:24 + > +++ docs/grub.texi2013-03-24 13:24:52 + > @@ -3372,6 +3372,7 @@ > * cpuid:: Check for CPU features > * crc::

Re: [PATCH 3/7] Initial support for U-Boot platforms

2013-03-30 Thread Francesco Lavra
Mostly cosmetic comments from my side here... On 03/24/2013 06:01 PM, Leif Lindholm wrote: [...] > === added file 'grub-core/disk/uboot/ubootdisk.c' > --- grub-core/disk/uboot/ubootdisk.c 1970-01-01 00:00:00 + > +++ grub-core/disk/uboot/ubootdisk.c 2013-03-24 12:58:23 + [...] > +/* > + *

Re: [PATCH 2/7] Initial support for ARMv7 architecture

2013-03-30 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: [...] > === added file 'grub-core/kern/arm/cache.S' > --- grub-core/kern/arm/cache.S1970-01-01 00:00:00 + > +++ grub-core/kern/arm/cache.S2013-03-24 12:56:20 + > @@ -0,0 +1,251 @@ > +/* > + * GRUB -- GRand Unified Bootloader >

Re: [PATCH 1/7] ARM/U-Boot basic build system additions

2013-03-30 Thread Francesco Lavra
Hi, On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === modified file 'conf/Makefile.common' > --- conf/Makefile.common 2013-03-03 14:57:30 + > +++ conf/Makefile.common 2013-03-24 11:00:29 + > @@ -37,6 +37,13 @@ >CFLAGS_PLATFORM += -mno-app-regs >LDFLAGS_PLATFORM = -Wl,-me

[PATCH] Add missing ARM relocation codes and fix existing ones

2013-03-17 Thread Francesco Lavra
t from the spec. So while at it I fixed those differences as well. Hence this patch. 2013-03-17 Francesco Lavra * include/grub/elf.h: Add missing ARM relocation codes and fix existing ones. === modified file 'include/grub/elf.h' --- include/grub/elf.h 2013-

Re: Command documentation part 1.

2013-02-09 Thread Francesco Lavra
Hi, On 01/29/2013 11:25 AM, Andrey Borzenkov wrote: > В Tue, 22 Jan 2013 17:12:18 + > Colin Watson пишет: > >> On Tue, Jan 22, 2013 at 05:08:51PM +0400, Andrey Borzenkov wrote: >>> Quit a number of commands are not documented. Is it intentional >>> (because they are not considered "user leve

Re: [PATCH]: Add EFI conditional

2013-01-27 Thread Francesco Lavra
Hi, On 01/27/2013 04:20 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 26.01.2013 20:42, Francesco Lavra wrote: > >> This patch adds the automake conditional COND_efi, which is true for >> every configuration using the EFI platform. This conditional is used in

Re: Need help in studying the grub bootloader

2013-01-26 Thread Francesco Lavra
Hi Parth, On 01/26/2013 05:55 PM, parth paritosh wrote: > Sir, > I am trying to study the source code of grub bootloader in order to be > able to contribute in it. I would like to know about any existing > documentation that explains the control flow in the code. > That would be very helpful in un

[PATCH]: Add EFI conditional

2013-01-26 Thread Francesco Lavra
progress to port GRUB to ARM using EFI), this patch will allow not to have even more duplicated code in the future. 2013-01-26 Francesco Lavra * configure.ac (COND_efi): New condition. * grub-core/Makefile.am (KERNEL_HEADER_FILES): Add EFI files under COND_efi and remove