Re: Determining boot server and own IP on sparc64-ieee1275

2011-07-06 Thread David Miller
From: Vladimir 'φ-coder/phcoder' Serbinenko Date: Wed, 06 Jul 2011 14:13:20 +0200 > 1) Is there any way to retrieve client and server IP on sparc64 used by > IEEE1275 or do we have to redo RARP ourselves? "/chosen/{client,server,gateway}-ip" > According to a web search newer sparc machines use

Re: Fallback to scanning OF tree if no devaliases

2010-07-29 Thread David Miller
From: lsore...@csclub.uwaterloo.ca (Lennart Sorensen) Date: Thu, 29 Jul 2010 12:59:08 -0400 > On Thu, Jul 29, 2010 at 09:52:18AM -0700, David Miller wrote: >> From: Doug Nazar >> Date: Thu, 29 Jul 2010 11:57:50 -0400 >> >> > How common is it not to have nval

Re: Fallback to scanning OF tree if no devaliases

2010-07-29 Thread David Miller
From: Doug Nazar Date: Thu, 29 Jul 2010 11:57:50 -0400 > How common is it not to have nvalias's? Is that usual operating > procedure? FWIW, I've never seen this on a sparc64 system, ever. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu

Re: GIT mirror of BZR repo

2010-03-11 Thread David Miller
From: "KESHAV P.R." Date: Thu, 11 Mar 2010 21:20:42 +0530 > If u guys have any plans for a git repo (or mirror) , I will be glad > to change over to it. Yes, please provide an uptodate GIT mirrot of the grub sources. I've simply stopped trying to work on grub after the transition to bzr, using

Re: [RFC] Dynamic device.map

2009-12-26 Thread David Miller
From: Robert Millan Date: Sat, 26 Dec 2009 14:25:51 +0100 > Then we rely only on UUIDs. This is exactly what I suggested we should avoid. On OpenFirmware we scan every device alias, %80 of them point to non-existing devices. The aliases are just an enumeration of the set of devices that could

Re: [PATCH] Don't open same disk twice on OpenFirmware.

2009-12-18 Thread David Miller
From: David Miller Date: Fri, 18 Dec 2009 10:33:13 -0800 (PST) > From: Vladimir 'φ-coder/phcoder' Serbinenko > Date: Fri, 18 Dec 2009 17:17:13 +0100 > >> Hello, all. According to David Miller sparc's openboot doesn't support >> opening same disk twi

Re: [PATCH] Don't open same disk twice on OpenFirmware.

2009-12-18 Thread David Miller
From: Vladimir 'φ-coder/phcoder' Serbinenko Date: Fri, 18 Dec 2009 17:17:13 +0100 > Hello, all. According to David Miller sparc's openboot doesn't support > opening same disk twice. So I implemented handle reusage logic. Tested > on imac g3 At a minimum you have to

Re: Broken common.rmk change

2009-12-07 Thread David Miller
From: Robert Millan Date: Mon, 7 Dec 2009 15:04:11 +0100 > On Sun, Dec 06, 2009 at 04:21:50PM -0800, David Miller wrote: >> From: Robert Millan >> Date: Sun, 6 Dec 2009 14:10:26 +0100 >> >> > We're actually in the process of getting rid of device.ma

Re: mkrelpath doesn't do what it should...

2009-12-07 Thread David Miller
From: Felix Zielcke Date: Mon, 07 Dec 2009 11:39:22 +0100 > The one mount point case is now fixed in r1917 > See Subject: `handling mount points in grub-mkrelpath' from me for the > patch. Seems to work properly now. The paths all start with "//" but I guess that's ok. Thanks! __

Re: mkrelpath doesn't do what it should...

2009-12-07 Thread David Miller
From: Felix Zielcke Date: Mon, 07 Dec 2009 23:06:46 +0100 > Am Montag, den 07.12.2009, 03:24 -0800 schrieb David Miller: >> In fact I don't see why these scripts don't do that, and relatively >> resolve the /boot directory whatever seperately. > > Because it

Re: Broken common.rmk change

2009-12-07 Thread David Miller
From: Robert Millan Date: Mon, 7 Dec 2009 15:05:16 +0100 > On Sun, Dec 06, 2009 at 05:22:52PM -0800, David Miller wrote: >> From: Robert Millan >> Date: Sun, 6 Dec 2009 14:10:26 +0100 >> >> > grub-mkconfig generates a grub.cfg that relies on UUIDs instead >&g

Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 12:52:01 +0100 > It already works on MIPS and AFAICT only thing it needs to work is PCI. > Do you mean that accessing PCI on sparc is a lot of work? Even just calculating the register addresses is a lot of work. You can't

Re: mkrelpath doesn't do what it should...

2009-12-07 Thread David Miller
From: Felix Zielcke Date: Mon, 07 Dec 2009 11:39:22 +0100 > Am Sonntag, den 06.12.2009, 23:30 -0800 schrieb David Miller: >> I was trying to figure out why the kernel image paths generated >> automatically for me by grub-mkconfig were not correct. >> >> I have /boot o

Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 12:05:24 +0100 > Committed. > David Miller wrote: >> I tried to surmise other ways to do this more cleanly, such as >> resolving the path and looking for some device property inside of

Re: Broken common.rmk change

2009-12-07 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 11:48:07 +0100 > The problem actually is the following: > When we're in OS we know the OS device name but not the firmware device > name. So we're able to generate correct root= for kernel command line > but can only guess

Re: Broken common.rmk change

2009-12-07 Thread David Miller
From: Colin Watson Date: Mon, 7 Dec 2009 10:20:16 + > On Sun, Dec 06, 2009 at 05:22:52PM -0800, David Miller wrote: >> From: Robert Millan >> Date: Sun, 6 Dec 2009 14:10:26 +0100 >> >> > grub-mkconfig generates a grub.cfg that relies on UUIDs instead >&g

mkrelpath doesn't do what it should...

2009-12-06 Thread David Miller
I was trying to figure out why the kernel image paths generated automatically for me by grub-mkconfig were not correct. I have /boot on a seperate partition, but in the generated config files it uses paths like /boot/vmlinux-2632 etc. The problem is grub-mkrelpath and it's usage in the scrips su

[PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-06 Thread David Miller
We skip CDROMs in the block device iterator because they simply can't be openned safely unless we absolutely know there is a CDROM drive there and there is in fact a disc in the drive. Openning it blindly results in either a 10 second hang during the open call, or even worse a crash in OpenFirmwa

Re: Broken common.rmk change

2009-12-06 Thread David Miller
From: Robert Millan Date: Sun, 6 Dec 2009 14:10:26 +0100 > grub-mkconfig generates a grub.cfg that relies on UUIDs instead > of hardcoding, etc. Well, for one thing I don't use initrd's for my Linux kernels, therefore specifying root devices via UUIDs isn't going to work. _

Re: Broken common.rmk change

2009-12-06 Thread David Miller
From: Robert Millan Date: Sun, 6 Dec 2009 14:10:26 +0100 > We're actually in the process of getting rid of device.map; Meanwhile, please fix the regression you added to the tree. :-) And I'll look into what you've mentioned to see if that kind of scheme will work properly on Sparc. __

Broken common.rmk change

2009-12-06 Thread David Miller
Robert, the set of objects used to build grub-mkdevicemap on sparc64-ieee1275 is not the same as those used on other architectures. So this change was not correct: 2009-11-26 Robert Millan * conf/common.rmk (sbin_UTILITIES): Add `grub-mkdevicemap'. ... * conf/i386-coreboot.rm

Re: [PATCH]: Fix sparc64 build...

2009-12-04 Thread David Miller
From: Robert Millan Date: Fri, 4 Dec 2009 21:58:25 +0100 > On Thu, Dec 03, 2009 at 01:03:09PM -0800, David Miller wrote: >> >> Thanks, but I don't feel comfortable enough with bzr yet. >> >> I had to struggle just to get things checked out, as the bzr >>

Re: [PATCH]: Fix sparc64 build...

2009-12-03 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Thu, 03 Dec 2009 22:56:34 +0100 > The problem is that nobody of us has such hardware. I would happily do a > sparc boot every 2 weeks but I just don't have a sparc You can get an Ultra5 for ~$100.00 USD on EBAY :-) Anyways, no matter, I'm

Re: [PATCH]: Fix sparc64 build...

2009-12-03 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Thu, 03 Dec 2009 21:22:27 +0100 > David Miller wrote: >>> Committed. >>> >> >> Thanks. >> >> > You can commit to bzr yourself actually. And unless Robert objects I >

Re: [PATCH]: Fix sparc64 build...

2009-12-03 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Thu, 03 Dec 2009 21:22:27 +0100 > For me the main reason for or against it is break probability. Merging > will avoid stupid breakages like ones you fixed but may introduce more > subtle ones You lack a cross-build environment? I test bui

Re: [PATCH]: Fix sparc64 build...

2009-12-03 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Thu, 03 Dec 2009 12:26:05 +0100 > Hello, nice to see you again. > David Miller wrote: >> So I finally am about to have enough time to start looking into >> sparc64 support again. >> >> >

[PATCH]: Fix sparc64 build...

2009-12-03 Thread David Miller
So I finally am about to have enough time to start looking into sparc64 support again. And, surprise! The trunk doesn't even build. :-) 2009-12-03 David S. Miller * conf/sparc64-ieee1275.rmk (grub_mkimage_SOURCES, grub_setup_SOURCES, grub_ofpathname_SOURCES): Add gnulib/prog

Re: powerpc/sparc problems

2009-10-28 Thread David Miller
From: Felix Zielcke Date: Wed, 28 Oct 2009 11:24:58 +0100 > Am Montag, den 12.10.2009, 10:55 +0200 schrieb Felix Zielcke: >> David are you still there? >> And also anyone who has access to a powerpc machine (and experience)? >> >> In Debian we the problem that the `__ashldi3' and `__bswapsi2' sy

Re: powerpc/sparc problems

2009-10-16 Thread David Miller
From: Pavel Roskin Date: Thu, 15 Oct 2009 18:41:41 -0400 > This makes me think that checks for __bswapsi2 and __bswapdi2 will fail > on Sparc64, even if those functions are present and even if > --disable-werror is used. They worked perfectly fine for me on a real system with a real compiler an

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Vladimir 'phcoder' Serbinenko Date: Mon, 12 Oct 2009 17:45:33 +0200 > Another idea: we could use nm to generate list of functions in libgcc. Yes, 'nm' would work too. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/l

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Bean Date: Mon, 12 Oct 2009 18:31:12 +0800 > To use the libgcc, we need to link the object file, this doesn't work > in system that use non ELF format like mach-o. How can one even build programs in the mach-o format if linking object files is not allowed? :-) If this is just for embedded

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Vladimir 'phcoder' Serbinenko Date: Mon, 12 Oct 2009 12:26:04 +0200 > It was removed as a part of following commit > 2009-06-10 Pavel Roskin > > * configure.ac: Use -nostdlib when probing for the target. It > should not be required to have libc for the target. > >

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Bean Date: Mon, 12 Oct 2009 17:58:42 +0800 > Try my branch, it includes the libgcc functions in grub instead of > rely on external library. It builds and run properly for > powerpc-ieee1275 last time I check. Good luck when the compiler changes the interface and/or semantics of these routi

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Vladimir 'phcoder' Serbinenko Date: Mon, 12 Oct 2009 11:56:23 +0200 > How accurate is qemu-system-sparc64? We could have an automated > regression testing for it - this should keep grub-sparc reasonably > working and permit minor (and perhaps even major) developpement Personally, I don't k

Re: powerpc/sparc problems

2009-10-12 Thread David Miller
From: Felix Zielcke Date: Mon, 12 Oct 2009 10:55:46 +0200 > And David we still have this sparc bug open, which I forwared to > grub-devel: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538030 I'm about to head to Tokyo for the Linux Kernel summit and the Japan Linux Symposium so I'll be out

Re: Require at least gcc 4.2

2009-09-05 Thread David Miller
From: Robert Millan Date: Sat, 5 Sep 2009 23:26:11 +0200 > David et al, can we agree on a minimal version of GCC that we should > recommend? > > For mentioning in the INSTALL file only. I assume nobody's interested in > gcc 2.95. I think gcc-4.1.x, maybe specifically gcc-4.1.3 is a reasonable

Re: [RFC] Eliminate NESTED_ATTR_FUNC

2009-09-03 Thread David Miller
From: "Vladimir 'phcoder' Serbinenko" Date: Thu, 3 Sep 2009 17:08:34 +0200 > I can't agree with designating nested functions as root issue. Imagine > tomorrow we discover a bug in "for" loop compiling. This wouldn't be a > reason to replace all "for"s with "while"s. The root issue is compiler > b

Re: [RFC] Eliminate NESTED_ATTR_FUNC

2009-09-01 Thread David Miller
From: Yves Blusseau Date: Tue, 1 Sep 2009 21:30:01 +0200 > > Le 1 sept. 09 à 17:43, Bean a écrit : > >> IMO, if we are to tackle the NESTED_FUNC_ATTR issue, we should do it >> properly by removing nested function, this also has other advantages, >> like allowing to run tools on systems like OSX

Re: Require at least gcc 4.2

2009-09-01 Thread David Miller
From: "Vladimir 'phcoder' Serbinenko" Date: Tue, 1 Sep 2009 19:02:39 +0200 > Even if it's not so I still think dropping support for old building > environments is a good thing since it decreases bug possibilities > and so maintainance work too. It also decreases your testing base. I think this

Re: Require at least gcc 4.2

2009-09-01 Thread David Miller
From: "Vladimir 'phcoder' Serbinenko" Date: Tue, 1 Sep 2009 16:12:20 +0200 > Even if gcc<4.2 seem to work ok I think we shouldn't waste resources > on it and officially declare a minimal requirement ("you're free to go > under requirement but don't post bugreports if you do") You're making it su

Re: sparc: [Fwd: Bug#538030: grub-ieee1275 fails to install bootblock]

2009-07-22 Thread David Miller
From: Felix Zielcke Date: Wed, 22 Jul 2009 20:11:44 +0200 > Just mail him: Alexander Vlasov > but then please also CC the bug report: 538...@bugs.debian.org > You could ask then also if he wants to subscribe to grub-devel but if > not then please CC him + the bug report for everything which is >

Re: sparc: [Fwd: Bug#538030: grub-ieee1275 fails to install bootblock]

2009-07-22 Thread David Miller
From: Robert Millan Date: Wed, 22 Jul 2009 19:57:49 +0200 > On Wed, Jul 22, 2009 at 05:45:41PM +0200, Felix Zielcke wrote: >> > grub-mkdevicemap: error: Cannot open SAS PHY ID >> > '/sys/devices/root/f0063e50/pci:02/:02:00.0/:03:09.0/:0a:00.0/:0b:01.0/host0/port-0:0/end_devic

Re: sparc: [Fwd: Bug#538030: grub-ieee1275 fails to install bootblock]

2009-07-22 Thread David Miller
From: Felix Zielcke Date: Wed, 22 Jul 2009 17:45:41 +0200 > could you please have a look at this? > It's a sparc problem. I won't even be close to being able to look into this until late August as I'm currently in New York City and therefore thousands of miles from my Sparc systems :-) ___

Re: OLPC regression, ofdisk stops working

2009-07-10 Thread David Miller
From: Robert Millan Date: Fri, 10 Jul 2009 19:41:15 +0200 > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote: >> Hi, >> >> There is something wrong with r2132, now childtype is a pointer, so >> sizeof childtype == 4, the name would be truncated to 4 characters. > > Bean, you never cease to

Re: Data loss at savannah.gnu.org

2009-06-02 Thread David Miller
From: Felix Zielcke Date: Tue, 02 Jun 2009 23:12:15 +0200 > Okuji already said once [0] that he could add a new co-maintainer. > The only reply was from Robert [1] that he doestn't have time. > I wonder why I didn't reply. Well anyway I would have time but I don't > think I would be a good GNU ma

Re: Data loss at savannah.gnu.org

2009-06-02 Thread David Miller
From: Marco Gerards Date: Tue, 02 Jun 2009 17:17:46 +0200 > No offense, but didn't Okuji implement more than most of us did? He > actually wrote all the intial code of GRUB 2 from scratch. RMS did the same for GCC, but now he concentrates his efforts on other activities and doesn't pretend to b

Re: Data loss at savannah.gnu.org

2009-06-02 Thread David Miller
From: Felix Zielcke Date: Tue, 02 Jun 2009 12:13:02 +0200 > Unfortunately Okuji already objected against git [0] That was a year and a half ago, and how much has Okuji even made postings to this mailing list lately? Remind me what the definition of "maintainer" is? I think the people actually

Re: Data loss at savannah.gnu.org

2009-06-01 Thread David Miller
From: Pavel Roskin Date: Mon, 01 Jun 2009 09:37:23 -0400 > Since now having a repository affects out effectiveness, we may opt to > switch to a git repository. Yes, please, let's do this :-) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists

[PATCH]: Fix sed quoting in sparc64 install script.

2009-05-05 Thread David Miller
Committed. Index: ChangeLog === --- ChangeLog (revision 2191) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2009-05-05 David S. Miller + + * util/sparc64/ieee1275/grub-install.in: Fix sed arg quoting. + 2009-05-05 Pave

Re: [PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL

2009-05-04 Thread David Miller
From: Pavel Roskin Date: Mon, 04 May 2009 20:13:24 -0400 > Hello! > > The GRUB code is full of constructs like > > #ifndef GRUB_UTIL > grub_dl_ref (my_mod); > #endif > > It's better to avoid having source files littered with preprocessor > conditionals. This patch implements grub_dl_ref() a

[PATCH]: IEEE1275 path name escaping...

2009-05-04 Thread David Miller
Ok, finally GRUB works also on my workstation. These are the changes that allow GRUB to properly handle "," characters in OF path names. As we discussed about a month ago, when a "," appears in an OF path name we escape it with "\". So all of the real work is escaping OF paths as they are given

[PATCH]: Fix hangs and stalls on sparc64

2009-05-04 Thread David Miller
1) If there isn't a CDROM in the drive, trying to do an ieee1275 open() on a cdroom device hangs nearly indefinitely. 2) If you try to open the bare device "ide/disk" for example (with no "@X,Y" ID selector) this hangs for 5 seconds then spits out ugly errors about not being able to read

[PATCH]: Fix sparc64 build.

2009-05-04 Thread David Miller
Please be more careful people. 2009-05-04 David S. Miller * conf/sparc64-ieee1275.rmk: Fix build due to missing '\'. --- conf/sparc64-ieee1275.rmk (revision 2184) +++ conf/sparc64-ieee1275.rmk (revision 2187) @@ -113,12 +113,12 @@ kern/device.c kern/disk.c kern/dl.c kern/

[PATCH]: Fix ieee1275 iterator regression.

2009-05-04 Thread David Miller
When I converted this code over to user dynamically allocated strings, I inserted a bug by passing the address of the string pointer instead of the pointer itself. Committed. 2009-05-04 David S. Miller * kern/ieee1275/openfw.c (grub_children_iterate): Fix string pointer args

[PATCH]: Build warning fix.

2009-05-03 Thread David Miller
I just committed the following. I see people talking about enabling -Werror, but nobody is watching for even the most obvious new warning messages when they commit new changes :-( 2009-05-03 David S. Miller * normal/menu.c: Include grub/parser.h diff --git a/normal/menu.c b/normal/m

Re: mmap services

2009-04-30 Thread David Miller
From: "Vladimir 'phcoder' Serbinenko" Date: Thu, 30 Apr 2009 15:36:36 +0200 > Rediffed and reposted due to request by David Miller I've looked these over and I'm completely OK with these changes as long as at least basic testing occurs for the BIOS, ACPI, and EF

Re: [PATCH]: grub: Partitions can start at zero.

2009-04-30 Thread David Miller
From: Vladimir Serbinenko Date: Mon, 20 Apr 2009 18:53:35 +0200 > On Mon, Apr 20, 2009 at 2:30 AM, David Miller wrote: > >> >> With Sun partitions, individual partitions can start at disk >> address zero. That's right, zero. >> >> This works because

[PATCH]: Handle virtual disk device names on powerpc/sparc64

2009-04-30 Thread David Miller
PowerPC and Sparc64 virtualized disks on hypervisor systems are named /dev/vdiskX instead of /dev/vdX. Handle this. Committed. 2009-04-30 David S. Miller * util/hostdisk.c (convert_system_partition_to_system_disk): Handle virtual disk devices named /dev/vdiskX as found on sp

[PATCH]: Handle lettered OF path partitions on sparc64.

2009-04-30 Thread David Miller
OpenBoot uses ":a", ":b", etc. partition specifiers instead of the numbered ":1", ":2", etc. that the generic ieee1275 code expects. Instead of cruddng up the generic ieee1275 code with this, just convert in the sparc64 specific code beforehand. Committed. 2009-04-30 David S. Miller

[PATCH]: Fix up a few build warnings.

2009-04-29 Thread David Miller
I noticed these in the build, and they result from the fact that grub_uint64_t is "unsigned long" and consequently grub_addr_t and grub_disk_addr_t have this type as well. Since grub_uint64_t can be either "long long" or "long" depending on the platform, a cast is the best fix for now. Committed

[PATCH]: Missing newline at end of file.

2009-04-29 Thread David Miller
The build had been warning about this for a few weeks now, I finnaly got annoyed enough to fix it :-) Committed. 2009-04-29 David S. Miller * normal/command.c: Add missing newline at end of file. diff --git a/normal/command.c b/normal/command.c index 863d45f..3296515 100644 --- a/no

[PATCH]: Fix warning on ieee1275 platforms other than i386

2009-04-29 Thread David Miller
On powerpc and sparc compiling lsmmap.c gives a warning because the mmap iterator function declaration isn't visible. Others provide this via memory.h so let's make these platforms do this as well by simply including ieee1275.h The sparc64 build, at least, is now warning free for me. Committed.

Re: Revision 2136 breaks two-disk configuarion

2009-04-28 Thread David Miller
From: Pavel Roskin Date: Mon, 27 Apr 2009 18:26:11 -0400 > On Sun, 2009-04-26 at 22:57 -0700, David Miller wrote: > >> grub_disk_open() isn't used, but a grub_device_open() does occur >> during the iterator that has us find the FS_UUID device. This >> happens s

Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion

2009-04-28 Thread David Miller
From: Pavel Roskin Date: Mon, 27 Apr 2009 23:50:45 -0400 > On Mon, 2009-04-27 at 18:45 -0700, David Miller wrote: > >> Thanks for fixing this Pavel. I suspect this bug is why the close was >> left as a NOP function all of this time. > > Maybe. > >> Please co

Re: [PATCH] Re: Revision 2136 breaks two-disk configuarion

2009-04-27 Thread David Miller
From: Pavel Roskin Date: Mon, 27 Apr 2009 21:37:52 -0400 > On Mon, 2009-04-27 at 18:26 -0400, Pavel Roskin wrote: > >> It's entirely possible that the problem is elsewhere. But I have no >> experience debugging memory problems in GRUB, so it will take time >> before I find out. > > Done! disk

Re: Revision 2136 breaks two-disk configuarion

2009-04-26 Thread David Miller
From: Pavel Roskin Date: Mon, 27 Apr 2009 01:25:37 -0400 > Hello! > > Since the revision 2136, I'm getting a non-fatal error message: > > GRUB loading. > Welcome to GRUB! > > alloc magic is broken at 0x7fdaf20 > Aborted. Press any key to exit. > > After pressing enter, the menu appears and I

Re: Faulty grub-mkdevicemap file

2009-04-26 Thread David Miller
From: BandiPat Date: Sat, 25 Apr 2009 15:29:11 -0400 > Here is the error when running grub-install: I just checked in the following patch which will fix this bug. 2009-04-26 David S. Miller * util/grub-mkdevicemap.c (make_device_map): Add missing NESTED_FUNC_ATTR to process_

Re: zfs preview

2009-04-25 Thread David Miller
From: Jordi Mallach Date: Sun, 26 Apr 2009 02:58:47 +0200 > He surely will, yes... if you take into account that phcoder /is/ Vladimir. This reminds me that I've had some serious trouble finding posting in the archives because his postings show up under more than one name :-/ Unfortunately, ema

Re: Faulty grub-mkdevicemap file

2009-04-25 Thread David Miller
From: BandiPat Date: Sat, 25 Apr 2009 15:29:11 -0400 > Here is the error when running grub-install: > > grub-install /dev/sda > /usr/sbin/grub-install: line 203: 1362 Segmentation fault > $grub_mkdevicemap --device-map=$device_map $no_floppy > > This is using svn2140 release. Can you please ru

Re: [PATCH]: grub: Fix ieee1275 iteraters to stop when hook() returns non-zero.

2009-04-24 Thread David Miller
From: David Miller Date: Thu, 23 Apr 2009 03:33:18 -0700 (PDT) > 2009-04-23 David S. Miller > > * disk/ieee1275/nand.c (grub_nand_iterate): Return > grub_devalias_iterate() result instead of unconditional 0. > * disk/ieee1275/ofdisk.c (grub_ofdisk_ite

Re: [PATCH]: grub: Close parent device in grub_fs_uuid_close().

2009-04-24 Thread David Miller
From: David Miller Date: Thu, 23 Apr 2009 03:33:16 -0700 (PDT) > 2009-04-23 David S. Miller > > * disk/fs_uuid.c (grub_fs_uuid_close): Call grub_disk_close() > on disk->data. Committed. ___ Grub-devel mailing list Gru

Re: [PATCH]: grub: Don't hold raw device open when iterating down into partitions.

2009-04-24 Thread David Miller
From: David Miller Date: Thu, 23 Apr 2009 03:33:14 -0700 (PDT) > 2009-04-23 David S. Miller > > Avoiding openning same device multiple times in device iterator. > > * kern/device.c (grub_device_iterate): Define struct part_ent, > and use it to build a lis

[PATCH]: grub: Fix ieee1275 iteraters to stop when hook() returns non-zero.

2009-04-23 Thread David Miller
This is the third part of fixing FS_UUID on sparc64. The IEEE1275 devalias and child iterators were not like true grub2 iterators, even though their users expected as such. Instead of stopping on the first non-zero hook return, they gave instead error codes and walked the entire list of objects

[PATCH]: grub: Close parent device in grub_fs_uuid_close().

2009-04-23 Thread David Miller
This is the second part of fixing FS_UUID on sparc64. Strangely, the FS_UUID close handler was empty. This leaks the parent disk and device object. Fix by calling grub_disk_close() on the appropriate object. 2009-04-23 David S. Miller * disk/fs_uuid.c (grub_fs_uuid_close): Call gru

[PATCH]: grub: Don't hold raw device open when iterating down into partitions.

2009-04-23 Thread David Miller
This is the first part in fixing FS_UUID on sparc64. As explained in some of my previous patch descriptions, you cannot open the same device node multiple times concurrently in OpenBoot. The two cases in grub2 which cause this situation were module dependency handling (already fixed by me a week

[PATCH]: Kill unused sparc64 file.

2009-04-23 Thread David Miller
Committed. 2009-04-23 David S. Miller * kern/sparc64/ieee1275/openfw.c: Unused, delete. diff --git a/kern/sparc64/ieee1275/openfw.c b/kern/sparc64/ieee1275/openfw.c deleted file mode 100644 index fe9ee96..000 --- a/kern/sparc64/ieee1275/openfw.c +++ /dev/null @@ -1,373 +0,0 @@ -/

Re: [PATCH]: grub: Add sparc64 support code.

2009-04-22 Thread David Miller
From: David Miller Date: Sun, 19 Apr 2009 17:42:18 -0700 (PDT) > 2009-04-19 David S. Miller > > * util/sparc64/ieee1275/misc.c: New file. > * util/sparc64/ieee1275/grub-setup.c: New file. > * util/sparc64/ieee1275/grub-ofpathname.c: New file. > * uti

Re: [PATCH]: grub: Exliminate fixed length string buffers in child and devalias iterators.

2009-04-22 Thread David Miller
From: David Miller Date: Sun, 19 Apr 2009 17:27:53 -0700 (PDT) > 2009-04-19 David S. Miller > > * include/grub/ieee1275/ieee1275.h (IEEE1275_MAX_PROP_LEN, > IEEE1275_MAX_PATH_LEN): Define. > * kern/ieee1275/openfw.c (grub_children_iterate): Dynamically &

Re: [PATCH]: grub: Handle the case where the root node has size-cells but not address-cells.

2009-04-22 Thread David Miller
From: David Miller Date: Sun, 19 Apr 2009 17:24:54 -0700 (PDT) > 2009-04-19 David S. Miller > > * kern/ieee1275/mmap.c (grub_machine_mmap_iterate): If size_cells > is larger than address_cells, use that value for address_cells too

Re: [PATCH]: grub: Partitions can start at zero.

2009-04-22 Thread David Miller
From: Vladimir Serbinenko Date: Mon, 20 Apr 2009 18:53:35 +0200 > On Mon, Apr 20, 2009 at 2:30 AM, David Miller wrote: > >> >> With Sun partitions, individual partitions can start at disk >> address zero. That's right, zero. >> >> This works because

Re: [PATCH]: grub: Partitions can start at zero.

2009-04-21 Thread David Miller
From: Vladimir Serbinenko Date: Mon, 20 Apr 2009 18:53:35 +0200 > On Mon, Apr 20, 2009 at 2:30 AM, David Miller wrote: > >> >> With Sun partitions, individual partitions can start at disk >> address zero. That's right, zero. >> >> This works because

Re: [PATCH]: grub: Add sparc64 support code.

2009-04-19 Thread David Miller
From: David Miller Date: Sun, 19 Apr 2009 17:45:21 -0700 (PDT) > Ho hum, the grub-devel "posting size monster" is likely going > to eat this one. It actually allowed the posting, I was just impatient :-) ___ Grub-devel mailing

Re: [PATCH]: grub: Add sparc64 support code.

2009-04-19 Thread David Miller
From: David Miller Date: Sun, 19 Apr 2009 17:42:18 -0700 (PDT) Ho hum, the grub-devel "posting size monster" is likely going to eat this one. If you want to review this patch, I've put a copy up at: http://vger.kernel.org/~davem/0004-grub-Add-sparc64-support-code.patch

[PATCH]: grub: Partitions can start at zero.

2009-04-19 Thread David Miller
With Sun partitions, individual partitions can start at disk address zero. That's right, zero. This works because UFS and EXT{2,3,4} superblocks are offset far enough into the partition that it won't overwrite the disk label nor the boot block. I added an, arguably hackish, heuristic to handle

[PATCH]: grub: Exliminate fixed length string buffers in child and devalias iterators.

2009-04-19 Thread David Miller
I did a lot of extensive research, and had some conversations with a few openboot engineers, to determine the top-end values for properties and path lengths. Using that I added some defines and got rid of the various fixed size stack lock buffers used throughout the openfirmware code. We now use

[PATCH]: grub: Handle the case where the root node has size-cells but not address-cells.

2009-04-19 Thread David Miller
Under OpenBoot on sparc64: The value of the #address-cells property in the root node is the default value of 2. The value of the #size-cells property in the root node is the non-default value 2. (NOTE: Since the #address-cells property value in the root node is the default value

[PATCH]: Fix sparc64 linux loader command registry.

2009-04-19 Thread David Miller
This code needed to be updated to deal with the fact that the whole rescue thing is not being used any more. Committed. 2009-04-19 David S. Miller * loader/sparc64/ieee1275/linux.c: Include grub/command.h (grub_rescue_cmd_linux): Rename to... (grub_cmd_linux): and fix

Re: Eliminating nested functions

2009-04-18 Thread David Miller
From: Colin D Bennett Date: Sat, 18 Apr 2009 08:57:33 -0700 > Probably passing a pointer to a local structure is the easiest way > to do it in most cases if the iteration function needs to access > some state, right? Right. The biggest surprise for me, easily, when reading the grub2 sources for

Re: Eliminating nested functions

2009-04-17 Thread David Miller
From: Pavel Roskin Date: Fri, 17 Apr 2009 11:54:57 -0400 > I suggest that we eliminate all nested functions. I support this completely. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub-fstest build issue in grub2-r2071 +

2009-04-14 Thread David Miller
From: David Miller Date: Tue, 14 Apr 2009 01:53:00 -0700 (PDT) > From: John Stanley > Date: Tue, 14 Apr 2009 05:17:44 -0400 > >> An update: I looked at the change between r2077 and r2104 and it looks >> like the relevant code is util/hostdisk.c; I've attached a patch

Re: grub-fstest build issue in grub2-r2071 +

2009-04-14 Thread David Miller
From: John Stanley Date: Tue, 14 Apr 2009 05:17:44 -0400 > An update: I looked at the change between r2077 and r2104 and it looks > like the relevant code is util/hostdisk.c; I've attached a patch that > appears to fix the problem. Sorry about that bug. I did test that patch, I wonder why it wo

Re: grub: Eliminate recursive reads of the same device in grub_dl_load_file().

2009-04-13 Thread David Miller
From: David Miller Date: Sun, 12 Apr 2009 23:56:11 -0700 (PDT) > > Openfirmware block device drivers do not allow for multiple concurrent > opens of the same device. It simply does not work. > > Fortunately grub doesn't actually need to do this, it just happens > to

Re: [PATCH]: grub: Kill fixed device name length from make_device_name().

2009-04-13 Thread David Miller
From: David Miller Date: Sun, 12 Apr 2009 23:53:04 -0700 (PDT) > make_device_name() uses an arbitrary value for the device name > length, putting an arbitrary limit on such strings. > > We can do better by calculating the length of this string precisely. > > 2009-04-1

Re: [PATCH]: grub: Add Sun partition support to grub-probe and grub-fstest.

2009-04-13 Thread David Miller
From: Pavel Roskin Date: Mon, 13 Apr 2009 08:51:36 -0400 > On Sun, 2009-04-12 at 23:53 -0700, David Miller wrote: >> Should be self-explanatory, these tools will be used on sparc64 just >> like they are on i386-pc > > Fine with me. Thanks for

Re: [PATCH]: grub: Allow to control objcopy '-B' argument from foo.rmk files.

2009-04-13 Thread David Miller
From: Robert Millan Date: Mon, 13 Apr 2009 16:29:10 +0200 > On Sat, Apr 11, 2009 at 01:08:31AM -0700, David Miller wrote: >> index 7dfb854..b4f1353 100644 >> --- a/conf/i386-pc.rmk >> +++ b/conf/i386-pc.rmk >> @@ -17,26 +17,31 @@ pkglib_IMAGES = boot.img diskboot.img

Re: [PATCH]: grub: Add sparc64 Linux kernel loader support.

2009-04-13 Thread David Miller
From: phcoder Date: Mon, 13 Apr 2009 10:58:13 +0200 > Really nice. I have no way of testing it but if it works it means that > sparc64 port now has real life. We could even proclaim April, the 13th > the annual GRUB2 SPARC64 day Not really. None of the openfirmware path handling changes are in,

Re: [PATCH]: grub: Add Sun partition support to grub-probe and grub-fstest.

2009-04-13 Thread David Miller
From: Chip Panarchy Date: Mon, 13 Apr 2009 17:40:22 +1000 > Hello > > When you mention 'Sun Partition' what file-system are you specifying? > > ZFS? > UFS? EXT3, but the sun "partition" support has to be there for grub tools to even get at the filesystems at all.

[PATCH]: grub: Add sparc64 Linux kernel loader support.

2009-04-13 Thread David Miller
This adds the sparc64 loader for Linux kernels. Committed. 2009-04-13 David S. Miller * include/grub/sparc64/ieee1275/loader.h: New file. * include/grub/sparc64/ieee1275/memory.h: Likewise. * include/grub/sparc64/kernel.h: Likewise. * loader/sparc64/ieee1275/lin

grub: Add ieee1275 interfaces for phys and virt memory allocation on sparc64.

2009-04-13 Thread David Miller
This adds the ieee1275 interfaces sparc64's openboot has for allocating physical memory, creating mappings, etc. We can't reuse any of the existing similar calls used by powerpc since these use two cells for passing physical addresses (even though only one of those cell slots is used, this is leg

[PATCH]: grub: Add revamped kernel startup code for sparc64.

2009-04-13 Thread David Miller
I've commited these changes. 2009-04-12 David S. Miller * kern/sparc64/ieee1275/init.c: Delete, replace with... * kern/sparc64/ieee1275/crt0.S: assembler implementation. * include/grub/sparc64/ieee1275/kernel.h: Declare grub_prefix[]. (GRUB_MOD_ALIGN, GRUB_MOD_GA

  1   2   >