-off-by: Andrew Hamilton
---
grub-core/fs/fshelp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/grub-core/fs/fshelp.c b/grub-core/fs/fshelp.c
index cb41934b4..a9d24a908 100644
--- a/grub-core/fs/fshelp.c
+++ b/grub-core/fs/fshelp.c
@@ -226,7 +226,10 @@ find_file (char
I just sent a patch series that happens to attempt to address the same
issue being addressed here, but in a slightly different way. It should have
title:
[PATCH 1/3] fs/ntfs: Correct some NTFS regressions
Thanks,
Andrew
On Thu, May 15, 2025 at 11:25 AM Daniel Kiper wrote:
> On Sat, May 03, 202
attribute run
list values. The calculation was incorrect for the 'curr' variable.
Fixes: 067b6d225d482280abad03944f04e30abcbdafa1
Signed-off-by: Andrew Hamilton
---
grub-core/fs/ntfs.c | 52 +
1 file changed, 39 insertions(+), 13 deletions(-)
di
Correct some NTFS test failures introduced by previous fixes for CVEs.
With these changes, the NTFS tests run successfully.
Also correct some fuzzer identified crashes and hangs (in NTFS and one
that may in theory impact HFS too).
Signed-off-by: Andrew Hamilton
Andrew Hamilton (3):
fs/ntfs
Correct several memory access violations and hangs found during fuzzing.
Signed-off-by: Andrew Hamilton
---
grub-core/fs/ntfs.c | 95 ++---
1 file changed, 80 insertions(+), 15 deletions(-)
diff --git a/grub-core/fs/ntfs.c b/grub-core/fs/ntfs.c
index
Yes this matches with the first layer of the onion I also found.
The hard link fail issue seems to stem from attempting to use
validate_attribute on attribute lists instead of attributes, I’m working on
a fix for that but it’s taking some time as it creates new fuzzer
identified flaws once changed
I try to do whenever I have some
free time. If anyone is an NTFS expert I'd be more than happy to hand it
off ;)
Thanks,
Andrew
On Thu, May 1, 2025 at 5:50 PM Glenn Washburn
wrote:
> On Thu, 20 Mar 2025 18:28:00 -0500
> Andrew Hamilton wrote:
>
> > A regression was introd
Support dates outside of 1901..2038.
Fixes: https://savannah.gnu.org/bugs/?63894
Fixes: https://savannah.gnu.org/bugs/?66301
Signed-off-by: Vladimir Serbinenko
Signed-off-by: Andrew Hamilton
---
grub-core/lib/datetime.c | 48
include/grub/datetime.h
the origin of some of the numbers used in calculations.
Andrew Hamilton (2):
datetime: Support dates outside of 1901..2038 range
date_unit_test: test dates outside of 32-bit unix range
grub-core/lib/datetime.c | 48
include/grub/datetime.h |
Signed-off-by: Vladimir Serbinenko
Signed-off-by: Andrew Hamilton
---
tests/date_unit_test.c | 35 ++-
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/tests/date_unit_test.c b/tests/date_unit_test.c
index 99774f199..c76f37cb5 100644
--- a/tests
Hi Vladimir,
I can make an attempt at addressing Daniel's comments if that's okay - any
objections?
Thanks,
Andrew
On Thu, Dec 19, 2024 at 11:34 AM Andrew Hamilton wrote:
> Just checking on this again. I know people are busy so understand.
>
> Thanks,
> Andrew
>
>
where "NULL" address
is invalid (such as may happen when calling grub-mount from
the operating system level).
Correct this issue by checking that at->attr_cur is within bounds
inside find_attr.
Fixes: https://savannah.gnu.org/bugs/?66855
Co-authored-by: B Horn
Co-authored-by: An
!
Andrew
On Thu, Mar 20, 2025 at 11:45 AM Daniel Kiper wrote:
> On Tue, Mar 18, 2025 at 09:22:46AM -0500, Andrew Hamilton wrote:
> > Unless someone else is already working on this, I started working on a
> patch
> > for this as well as fixes to correct the NTFS Grub te
Hello,
Personally, I really like this idea.
I'm not yet a Rust programmer but I am happy to learn... and perhaps
there are others like me that would take this as an opportunity to
learn while doing something like porting a Grub module from C to Rust
if we had that framework in place.
It seems li
Good feedback, I will update as suggested and send out a v3 shortly!
Thanks!
Andrew
On Thu, Mar 20, 2025 at 6:04 PM Vladimir 'phcoder' Serbinenko <
phco...@gmail.com> wrote:
>
>
> Le ven. 21 mars 2025, 01:54, Andrew Hamilton a
> écrit :
>
>> A regression
where "NULL" address
is invalid (such as may happen when calling grub-mount from
the operating system level).
Correct this issue by checking that at->attr_cur != NULL inside
find_attr.
Fixes: https://savannah.gnu.org/bugs/?66855
Co-authored-by: B Horn
Co-authored-by: Andrew Hamilton
Hello,
Looks good to me, thanks!
Reviewed-by: Andrew Hamilton
- Andrew
On Wed, Mar 19, 2025 at 7:54 AM Renaud Métrich via Grub-devel
wrote:
>
> Signed-off-by: Renaud Métrich
> ---
> grub-core/commands/efi/lsefi.c | 4
> 1 file changed, 4 insertions(+)
>
> d
Hello,
I just had one question about the use of the 'goto' and the 'loop'
label in the below code... see my question below the 'loop' label.
Let me know if I just misunderstand or am wrong.
Thank you!
Andrew
On Wed, Mar 19, 2025 at 7:53 AM Renaud Métrich via Grub-devel
wrote:
>
> When network b
,
Andrew
On Mon, Mar 17, 2025 at 7:47 AM Andrew Hamilton wrote:
> For some fuzzers I’m working on, l happened to run into the same issue
> this patch is addressing and used a fix similar to what Vladimir suggested
> (keeping mft_end check and adding attr_cur != NULL check). This fixes th
For some fuzzers I’m working on, l happened to run into the same issue this
patch is addressing and used a fix similar to what Vladimir suggested
(keeping mft_end check and adding attr_cur != NULL check). This fixes the
issue for me in my fuzzer so far.
Thanks,
Andrew
On Fri, Feb 28, 2025 at 7:12
: previous definition is here
typedef TPMS_SCHEME_HASH_t TPMS_SCHEME_KDF2_t;
^
1 error generated.
Making the change proposed allows successfully building GRUB with clang 14.
Andrew Hamilton (1):
lib: Fix clang Build - Remove Duplicate Typedef in TSS
grub-cor
>> by a Windows application. Thanks for any information. Should the lockdown
>> for NTFS remain, is it here to stay indefinitely?
>
>We did a lot of work to improve the NTFS code but still we are not sure
>it is fully correct. If somebody will do full NTFS code analysis and
>properly fix all (poten
tss2_structs.h contains a duplicate typedef as follows:
typedef TPMS_SCHEME_HASH_t TPMS_SCHEME_KDF2_t;
This causes a build failure when compiling with clang.
Remove the duplicate typedef which allows successfully
building GRUB with clang.
Signed-off-by: Andrew Hamilton
---
grub-core/lib/tss2
Document which file systems are not allowed when lockdown
is enabled to align to recent GRUB changes.
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 89 --
1 file changed, 87 insertions(+), 2 deletions(-)
diff --git a/docs/grub.texi b/docs
Make some updates to the GRUB documentation around which file systems
are allowed / disallowed in lockdown, as well as additional Commands
now blocked in lockdown mode.
Andrew Hamilton (2):
docs: Document Restricted Filesystems in Lockdown
docs: Capture Additional Commands Restricted by
Update documentation to capture that all memrw commands, the
minicmd dump command, and raw memory dumping via hexdump
are restricted when lockdown is enabled. This aligns to recent
GRUB code updates.
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 9 +
1 file changed, 9 insertions
5PM -0500, Andrew Hamilton wrote:
> > Hello,
> >
> > I’m looking for feedback on whether there would be project interest /
> support
> > on me creating an initial fuzz test suite for some core GRUB functions
> and then
> > integrating these fuzzers into the OSS-Fuzz p
Hello,
I’m looking for feedback on whether there would be project interest /
support on me creating an initial fuzz test suite for some core GRUB
functions and then integrating these fuzzers into the OSS-Fuzz project that
would run them and automate bug reporting to project owners / maintainers
on
Thanks I will submit a GRUB documentation patch when I get back from
vacation.
Thanks!
Andrew
On Mon, Feb 24, 2025 at 9:18 AM Daniel Kiper
wrote:
> On Wed, Feb 19, 2025 at 09:43:59AM -0600, Andrew Hamilton wrote:
> > It seems this may impact some users attempting to use secure boot, I
It seems this may impact some users attempting to use secure boot, I think
I understand the reasoning behind this but maybe we should have something
on the roadmap or issue tracker for what it would take to get these file
systems more robust (fuzzing and/or test coverage)?
Also should we update gr
Sounds great, thank you and hope everyone has a happy holiday season.
- Andrew
On Thu, Dec 19, 2024 at 2:02 PM Daniel Kiper
wrote:
> On Thu, Dec 19, 2024 at 11:32:59AM -0600, Andrew Hamilton wrote:
> > Any interest in this patch set?
>
> Yes, but due to holiday season and othe
Just checking on this again. I know people are busy so understand.
Thanks,
Andrew
On Sat, Oct 26, 2024 at 10:00 AM Andrew Hamilton wrote:
> Just checking if this was still on the radar, seems mostly comment and
> type changes so maybe a relatively minor update?
>
> If any help
Any interest in this patch set?
Thanks,
Andrew
On Thu, Nov 28, 2024 at 12:42 PM Andrew Hamilton wrote:
> Implement a virtio-net driver (using an in-built virtio-pci
> driver) to allow GRUB to have network support in virtual
> environments such as Qemu without a dependency on the BIO
compared.
Signed-off-by: Andrew Hamilton
---
.gitignore | 2 +
Makefile.util.def | 12
tests/net_http_transfer_test.in | 107
tests/util/grub-shell.in| 3 +
tests/util/qemu-linkup.in | 21 +++
5 files
Add documentation for new module virtionet which can be used to provide
network driver support in GRUB in a virtual environment like Qemu.
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 16
1 file changed, 16 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
Provide virtio-net driver for network interface support in a virtual
environment such as Qemu. This was written to comply with virtio version
1.x. This uses a virtio-pci interface.
Signed-off-by: Andrew Hamilton
---
grub-core/Makefile.core.def | 12 +
grub-core/net/drivers/virtio
improve test coverage of the network code in GRUB. This
driver should provide a basis for building upon this initial small
test for the network code in the future.
Andrew Hamilton (3):
docs: Document Module virtionet
net: Implement virtio-net Driver for Qemu in GRUB
tests: Add
Correct the documentation for the grub.cfg searching via network that
will be done based on a given MAC address (was missing the Ethernet
Type - 01).
Fixes: https://savannah.gnu.org/bugs/?65152
Signed-off-by: Andrew Hamilton
Reviewed-by: Daniel Kiper
---
docs/grub.texi | 4 ++--
1 file
Correct documentation for secure boot with UEFI to remove statement that
chainloader does not work with secure boot, as this was added by a
previous GRUB update.
Fixes: https://savannah.gnu.org/bugs/?62004
Signed-off-by: Andrew Hamilton
Reviewed-by: Daniel Kiper
---
docs/grub.texi | 14
- Correct patch titles for individual patches.
Changes in v3:
- Split patches by bug report fixed.
- Corrected "Closes" to "Fixes" in commits.
Changes in v2:
- Regenerate patch against current master branch.
Andrew Hamilton (3):
Correct docume
Correct documentation for pxe_default_server, pxe_default_gatway, and
pxe_blksize. Only pxe_default_server is actually used (alias for
net_default_server) so capture this, and remove the other two.
Fixes: https://savannah.gnu.org/bugs/?54480
Signed-off-by: Andrew Hamilton
Reviewed-by: Daniel
Just checking if this was still on the radar, seems mostly comment and type
changes so maybe a relatively minor update?
If any help is needed to make the adjustments let me know and I can help.
Thanks,
Andrew
On Mon, Sep 2, 2024 at 11:14 AM Daniel Kiper wrote:
> On Sat, Aug 17, 2024 at 08:30:2
Correct documentation for pxe_default_server, pxe_default_gatway, and
pxe_blksize. Only pxe_default_server is actually used (alias for
net_default_server) so capture this, and remove the other two.
Fixes: https://savannah.gnu.org/bugs/?54480
Signed-off-by: Andrew Hamilton
---
docs/grub.texi
- Split patches by bug report fixed.
- Corrected "Closes" to "Fixes" in commits.
Changes in v2:
- Regenerate patch against current master branch.
Andrew Hamilton (3):
Correct documentation for pxe_default_server, pxe_default_gatway, and
pxe_blksiz
Thank you for the review and feedback, I will send a corrected (v3)
version of this patch series shortly.
Thanks,
Andrew
On Thu, Oct 24, 2024 at 12:14 PM Daniel Kiper wrote:
>
> On Sat, Oct 19, 2024 at 08:28:57AM -0500, Andrew Hamilton wrote:
> > Closes: https://savannah.gnu.org
Correct the documentation for the grub.cfg searching via network that
will be done based on a given MAC address (was missing the Ethernet
Type - 01).
Fixes: https://savannah.gnu.org/bugs/?65152
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 4 ++--
1 file changed, 2 insertions(+), 2
Correct documentation for secure boot with UEFI to remove statement that
chainloader does not work with secure boot, as this was added by a
previous GRUB update.
Fixes: https://savannah.gnu.org/bugs/?62004
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 14 +++---
1 file changed, 7
v2:
- Regenerate patch against current master branch.
Andrew Hamilton (1):
Correct documentation for pxe_default_server, pxe_default_gatway, and
pxe_blksize. Only pxe_default_server is actually used (alias for
net_default_server) so capture this, and remove the other two.
Co
Closes: https://savannah.gnu.org/bugs/?54480
Closes: https://savannah.gnu.org/bugs/?62004
Closes: https://savannah.gnu.org/bugs/?65152
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 35 ---
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/docs
Will do, sorry for the delay (was on vacation), I will submit a v2 shortly.
Thanks,
Andrew
On Wed, Oct 9, 2024 at 8:07 AM Daniel Kiper wrote:
>
> On Thu, Oct 03, 2024 at 09:05:46AM -0500, Andrew Hamilton wrote:
> > Any feedback on this? If needed and can make a new version aga
Any feedback on this? If needed and can make a new version against current
main branch.
Thanks,
Andrew
On Sun, Aug 18, 2024 at 11:21 AM Andrew Hamilton wrote:
> Currently the GRUB Manual has a few small issues captured in bug
> reports (54480, 62004, and 65152). These are related to iss
Any feedback on this? I can regenerate and resend the patch if there are
any conflicts with other updates.
Thanks,
Andrew
On Sat, Aug 31, 2024 at 10:31 PM Andrew Hamilton wrote:
> Correct incorrect handling of routes being maintained when an
> associated interface is deleted. Previous
Thanks for fixing these, I’m not an official maintainer but looks good to
me!
Sincerely,
Andrew Hamilton
On Thu, Sep 5, 2024 at 8:37 PM Glenn Washburn
wrote:
> Signed-off-by: Glenn Washburn
> ---
> docs/grub.texi | 15 +++
> 1 file changed, 7 insertions(+),
ostly to enable
building / creating additional network tests I can run inside Qemu.
Please let me know your thoughts.
Sincerely,
Andrew Hamilton
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
but it will fail.
With the net.c change, this test will pass on grub-emu and be
skipped for other platforms.
Changes since v1:
(Ref:
https://lists.gnu.org/archive/html/grub-devel/2024-08/msg00138.html)
- Add net_test
- Resubmit net.c change due to incorrect patch submission before.
Andrew
Signed-off-by: Andrew Hamilton
---
grub-core/net/net.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 8cad4fb6d..51e0dd312 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -718,6 +718,23 @@ grub_cmd_deladdr
diff --git a/Makefile.util.def b/Makefile.util.def
index 0f74a1680..9ed211bc5 100644
--- a/Makefile.util.def
+++ b/Makefile.util.def
@@ -1131,6 +1131,12 @@ script = {
common = tests/cdboot_test.in;
};
+script = {
+ testcase = nonnative;
+ name = net_test;
+ common = tests/net_test.in;
+};
: Andrew Hamilton
-
On Fri, Aug 30, 2024 at 9:45 PM Andrew Hamilton wrote:
>
> With this update, routes mapped to a deleted interface will be deleted.
>
> Signed-off-by: Andrew Hamilton
> ---
> grub-core/net/net.c | 17 +
> 1 file changed, 17 i
With this update, routes mapped to a deleted interface will be deleted.
Signed-off-by: Andrew Hamilton
---
grub-core/net/net.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 8cad4fb6d..51e0dd312 100644
--- a/grub-core/net
port secure boot; and an issue in network boot documentation
for the searched grub.cfg name.
These issues have been updated in the grub manual (grub.texi).
From user perspective, this patch improve / correct / clarify
documentation around PXE, Secure Boot, and Network booting.
Andrew Hamilton (1
/bugs/?62004
Closes: https://savannah.gnu.org/bugs/?65152
Signed-off-by: Andrew Hamilton
---
docs/grub.texi | 35 ---
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/docs/grub.texi b/docs/grub.texi
index a050dc0fc..69ddf09e2 100644
--- a/docs/grub.texi
Thank you for doing this, it worked perfectly for me when I tested it
on x86-64 in a VM.
Testing performed:
1. Set various files on FAT32 and Ext4 file systems with various dates
in the future (2038, 2040, 2100, etc.) and confirmed correct date /
time display via GRUB 'ls' command.
2. Ran your pro
Thank you for doing this, it worked perfectly for me when I tested it
on x86-64 in a VM.
Sincerely,
Andrew
On Sat, Aug 17, 2024 at 12:31 PM Vladimir Serbinenko wrote:
>
> Signed-off-by: Vladimir Serbinenko
> ---
> tests/date_unit_test.c | 35 ++-
> 1 file change
e don't use that code.
>
> Le sam. 17 août 2024, 16:44, Andrew Hamilton a écrit :
>>
>> Hello,
>>
>> I'm thinking to try to address bug 63894 (grub_datetime2unixtime()
>> still has the year 2038 problem):
>> https://savannah.gnu.org/bugs/?63894
Hello,
I'm thinking to try to address bug 63894 (grub_datetime2unixtime()
still has the year 2038 problem):
https://savannah.gnu.org/bugs/?63894
I confirmed the issue is still partially present in
include/grub/datetime.h... the following checks are still present and
the issue mentioned local vari
Hello,
I'm not an expert in GRUB, but was trying to learn more. I took this
chance to learn about this new feature a bit and just had a couple
thoughts / questions. Otherwise, thank you!
> +char *
> +grub_fdt_prop_to_string (const unsigned char *val, grub_uint32_t len)
> +{
> + char *str;
> + i
Add documentation for all GRUB modules contained in the source code tree.
When possible, cross-references to additional detail on commands was added
from their corresponding module documentation. In addition, documentation
for the file command was added.
Signed-off-by: Andrew Hamilton
---
docs
's purpose.
From user perspective, this patch will greatly expand (I counted a bit
more than 300 modules today) section 16 (Modules) of the GRUB Manual, and
I also added some detail on the "file" command (moved it from
undocumented).
Andrew Hamilton (1):
docs: Document all GRUB
Thank you for the feedback, I just wanted to share that I am working on
this now - but it will take some time to work through all the modules.
Thanks!
- Andrew
On Thu, Jul 11, 2024 at 8:34 AM Oliver Steffen wrote:
> Quoting Andrew Hamilton (2024-06-27 18:31:59)
> > Hello,
&g
ng BLI module.
Any feedback on whether this would be a useful addition to the GRUB
documentation would be welcome.
Sincerely,
Andrew Hamilton
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
70 matches
Mail list logo
