Re: [PATCH v1 1/2] envblk: ignore empty new lines while parsing env files

2025-05-19 Thread Alexey Makhalov via Grub-devel
. This patch adds a check to skip empty lines along with those starting with `#'. Signed-off-by: Shreenidhi Shedi Reviewed-by: Alexey Makhalov Please do not add RBs if reviews have not been done in public. Those given on the grub-devel counts only. Hi Daniel, it was my ask to Shreenidhi t

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-09 Thread Alexey Makhalov
> On Sep 9, 2020, at 4:12 AM, Daniel Kiper wrote: > > Hey Javier, > > On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> Thanks for the review. >> >> On 9/7/20 9:36 PM, Daniel Kiper wrote: >>> On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Marti