Re: [PATCH 0/2] commands/efi: Fix sevral memory leaks

2025-05-20 Thread khaalid cali
From: Khalid Ali I added Daniel review tag, as he requested from me by privious thread. He reviewed this patch from another thread. Best regards, khaalid ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/2 ] loader/efi/linux: Fix memory leak

2025-05-20 Thread khaalid cali
Free mempath in case of failures. Signed-off-by: Khalid Ali --- grub-core/loader/efi/linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/grub-core/loader/efi/linux.c b/grub-core/loader/efi/linux.c index 78ea07ca8..e1f3d5f48 100644 --- a/grub-core/loader/efi/linux.c ++

[PATCH 1/2] disk/efi/efidisk: Fix memory leak

2025-05-20 Thread khaalid cali
Free "dp" in case of failure. Signed-off-by: Khalid Ali --- grub-core/disk/efi/efidisk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c index 3b5ed5691..1db29880a 100644 --- a/grub-core/disk/efi/efidisk.c +++ b/grub-core/dis

[PATCH 0/2] commands/efi: Fix sevral memory leaks

2025-05-20 Thread khaalid cali
"handles" that "grub_efi_locate_handles" was allocated with "grub_malloc" wasn't being freed. Signed-off-by: Khalid Ali Reviewed-by: Daniel Kiper --- grub-core/commands/efi/lsefi.c | 1 + grub-core/commands/efi/tpm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/grub-core/commands/e

Re: [PATCH v2 4/4] fs/ntfs: Correct possible access violations and hangs

2025-05-20 Thread Daniel Kiper via Grub-devel
I think you should change the order of this patch and patch #3. On Mon, May 19, 2025 at 09:03:18PM -0500, Andrew Hamilton wrote: > Correct several memory access violations and hangs found during fuzzing. > The issues fixed here could occur if certain specific malformed NTFS > file systems were pre

Re: [PATCH v2 3/4] fs/fshelp: Avoid possible NULL pointer deference

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:17PM -0500, Andrew Hamilton wrote: > Avoid attempting to defererence a NULL pointer to call read_symlink when > the given filesystem does not provide a read_symlink function. This could > be triggered if the calling filesystem had a file marked as a symlink. > This app

Re: [PATCH v2 2/4] fs/ntfs: Correct attribute vs attribute list validation

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:16PM -0500, Andrew Hamilton wrote: > Correct ntfs_test test failures around attempting to validate attribute > list entries as attributes. The NTFS code uses common logic in some > places to parse both attributes and attribute_lists which complicates > validation. Attr

Re: [PATCH v2 1/4] fs/ntfs: Correct regression with run list calculation

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 09:03:15PM -0500, Andrew Hamilton wrote: > Correct ntfs_test test failures around attempting to validate attribute > run list values. The calculation was incorrect for the 'curr' variable. > With previous calculation, some file systems would fail validation > despite being w

Re: [PATCH v2 00/21] Appended Signature Secure Boot Support for PowerPC

2025-05-20 Thread sudhakar
Hi Marta, Thanks Martha, yes that would be very helpful and I appreciate your consideration for that. Yes the patch-set is getting reviewed actively so I am also hopeful that these would be upstreamed soon. Thanks, Sudhakar Kuppusamy On 2025-05-13 19:46, Marta Lewandowska wrote: Red Hat ha

Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Previously, the command line construction function > (grub_create_loader_cmdline) escaped single and double quotes, which is > unnecessary and potentially problematic since the kernel command line > hand

Re: [PATCH v2 1/2] envblk: ignore empty new lines while parsing env files

2025-05-20 Thread Daniel Kiper via Grub-devel
On Mon, May 19, 2025 at 11:49:54PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Environment files may contain empty lines, which should be > ignored during parsing. Currently, these lines are not skipped and > resulting in incorrect behavior. This patch adds a check to skip empty >

Re: [PATCH v2 1/4] fs/ntfs: Correct regression with run list calculation

2025-05-20 Thread Vladimir 'phcoder' Serbinenko
Reviewed-by: Vladimir Serbinenko Regards Vladimir 'phcoder' Serbinenko Le mar. 20 mai 2025, 05:03, Andrew Hamilton a écrit : > Correct ntfs_test test failures around attempting to validate attribute > run list values. The calculation was incorrect for the 'curr' variable. > With previous calcu