Re: [PATCH v12 08/13] Remove now unneeded gcrypt compilation flag

On Tue, Apr 15, 2025 at 10:57:03PM +, Vladimir Serbinenko wrote: > HAVE_STRTOUL is now defined in stdlib.h. Include it in g10lib.h rather than > defining on command line > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___

Re: Fwd [PATCH] efi/tpcm: Add TPCM module support

From: Khalid Ali > TPCM(Trusted Platform Control Module) is a Chinese standard and has similar > function > to tpm, but tpcm adds the function of active monitoring and control to the > system. > It can realize active startup measurement when the system starts,as well as > dynamic > measurement

Re: [PATCH v12 11/13] import_gcry: Make compatible with python 3.4

On Tue, Apr 15, 2025 at 10:57:06PM +, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v12 04/13] Adjust import script, definitions and API users for libgcrypt 1.11

On Tue, Apr 15, 2025 at 10:56:59PM +, Vladimir Serbinenko wrote: > This patches modifies the GRUB-libgcrypt API to match new libgcrypt 1.11 > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-d

Re: [PATCH v12 13/13] libgcrypt: Don't use 64-bit division on platforms where it's slow

On Tue, Apr 15, 2025 at 10:57:08PM +, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v12 12/13] import_gcry: Fix pylint warnings

On Tue, Apr 15, 2025 at 10:57:07PM +, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v12 09/13] gcry: Ignore sign-compare warnings

On Tue, Apr 15, 2025 at 10:57:04PM +, Vladimir Serbinenko wrote: > libgcrypt itself is compiled with -Wno-sign-compare. > Do the same for consistency Hmmm... Why libgcrypt is compiled with -Wno-sign-compare? Daniel ___ Grub-devel mailing list Grub-

Re: [PATCH v12 01/13] Import libgcrypt 1.11

On Tue, Apr 15, 2025 at 10:56:56PM +, Vladimir Serbinenko wrote: > We currently use an old version of libcrypt which > results in us having fewer ciphers and missing on many > other improvements. May I ask you to describe the import process in the commit message and in dev docs? Good examples

Re: [PATCH v12 07/13] libgcrypt: Fix coverity warnings

On Tue, Apr 15, 2025 at 10:57:02PM +, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v12 06/13] keccak: Disable acceleration with SSE asm

On Tue, Apr 15, 2025 at 10:57:01PM +, Vladimir Serbinenko wrote: > Libgcrypt code assumes that on x64 all SSE registers are fair game. > While it's true that CPUs in question support it, we disable it in > our compilation options. Disable the offending optimization. > > Signed-off-by: Vladimir

Re: [PATCH v12 05/13] Add DSA and RSA SEXP tests

On Tue, Apr 15, 2025 at 10:57:00PM +, Vladimir Serbinenko wrote: > This allows us to test purely the integration of the implementation > of DSA and RSA from libgcrypt without concerning with additional > code. > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v12 03/13] b64dec: Adjust for compilation in GRUB environment

On Tue, Apr 15, 2025 at 10:56:58PM +, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko I think this patch should go to, e.g., grub-core/lib/misc-patches and be applied by autogen as other patches. Daniel ___ Grub-devel mailing list

Re: [PATCH v12 02/13] Import b64dec from gpg-error

On Tue, Apr 15, 2025 at 10:56:57PM +, Vladimir Serbinenko wrote: > Imported from libgpg-error 1.51 The same comment as for the patch #1. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ntfs: Fix attribute validation check

On Sat, May 03, 2025 at 08:02:07AM +, Vladimir Serbinenko wrote: > Without this fix GRUB doesn't see most of the files > on NTFS partition. It would be perfect if it is explained why current code is broken and why the fix is correct... Daniel ___ G

Re: [PATCH] fs/zfs: Fix another memory leak in ZFS code

On Mon, May 05, 2025 at 05:09:19PM -0500, Glenn Washburn wrote: > Commit b66c6f918 ("fs/zfs: Fix a number of memory leaks in ZFS code") > fixes many of the same leaks detected in bug #63846 except one, which > is fixed here. > > Fixes: https://savannah.gnu.org/bugs/?63846 > Signed-off-by: Glenn Was

Re: [PATCH] tests: Disable gfxterm_menu and cmdline_cat tests

On Mon, May 05, 2025 at 04:11:36PM -0500, Glenn Washburn wrote: > Those tests fail depending on the version of unifont. As we don't distribute > our own unifont it fails for most users. Disable them so that they don't mask > real failures. They can be reinstated once we solve unifont problem. > >

Re: [PATCH 1/2] envblk: ignore empty new lines while parsing env files

On Thu, May 15, 2025 at 12:44:27PM +0530, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Signed-off-by: Shreenidhi Shedi Both patches are missing explanations why they are needed and/or what kind of issues they are fixing. I do not mention cover letter... Daniel _

[PATCH 1/2] envblk: ignore empty new lines while parsing env files

From: Shreenidhi Shedi Signed-off-by: Shreenidhi Shedi --- grub-core/lib/envblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/lib/envblk.c b/grub-core/lib/envblk.c index 2e4e78b13..f08dabaad 100644 --- a/grub-core/lib/envblk.c +++ b/grub-core/lib/envblk.c @@ -2

[PATCH 2/2] cmdline: fix command line parsing in grub

From: Shreenidhi Shedi - Stop escaping single and double quotes - Kernel command line handler doesn't support escape quotes Signed-off-by: Shreenidhi Shedi --- grub-core/lib/cmdline.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/grub-core/lib/cmdline.c