From: khaalid
Well, i think the hex option is simpler in terms of code. Or maybe we
need to have centralized function for all UEFI error messages, however
this will complicate things a little bit as it requires modifications.
Just thought maybe we can extract high bit and treat like integer, thu
From: khaalid
As said in my privious patch.
The error message "cannot start image" seems better than "start_imaged
returned ..", to make it consistent with the other one.
Signed-off-by: khalid Ali
---
grub-core/loader/efi/linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Looks good
Reviewed-by: Vladimir Serbinenko phco...@gmail.com
Regards
Vladimir 'phcoder' Serbinenko
Le lun. 12 mai 2025, 14:55, Yair Yarom a écrit :
> Initial testpci module and command used to query if PCI devices are
> present.
>
> ---
> docs/grub.texi | 39 +++
> grub-cor
Initial testpci module and command used to query if PCI devices are present.
---
docs/grub.texi | 39 +++
grub-core/Makefile.core.def | 7 ++
grub-core/commands/testpci.c | 194 +++
grub-core/kern/efi/sb.c | 1 +
include/grub/file.h
From: khaalid
Hi Vladimir 'phcoder' Serbinenko,
I realize this patch is taking longer than expected,
and I’d like to avoid more back-and-forths that take time from both of us.
Would it be possible for us to work through the remaining points together more
directly or clarify the final expectatio
Le lun. 12 mai 2025, 10:37, khaalid cali a écrit :
> From: khaalid
>
> > Vladimir 'phcoder' Serbinenko wrote:
> > Please have a look at how to handle errors with realloc. You need to
> keep a copy of old pointer in case you have to free it. Some places in our
> codebase have similar memory leaks
From: khaalid
> Vladimir 'phcoder' Serbinenko wrote:
> Please have a look at how to handle errors with realloc. You need to keep a
> copy of old pointer in case you have to free it. Some places in our codebase
> have similar memory leaks but it'> s not a reason to introduce more.
Well, i follo
