Re: [PATCH 1/2] build: remove extra_deps.lst from EXTRA_DIST

2025-05-11 Thread Mike Gilbert
On Thu, Mar 27, 2025 at 5:12 PM Mike Gilbert wrote: > > This file is auto-generated based on the selected platform and should > not be included in the source tarball. PING. Please merge this 2-patch series. I am unable to generate a working tarball without these changes, and I would prefer not t

Re: [PATCH] testpci: initial module

2025-05-11 Thread Vladimir 'phcoder' Serbinenko
Le dim. 11 mai 2025, 17:11, Yair Yarom a écrit : > > > On Thu, 8 May 2025 at 17:30, Vladimir 'phcoder' Serbinenko < > phco...@gmail.com> wrote: > >> Le jeu. 8 mai 2025, 15:49, Yair Yarom a écrit : >> >>> +#include >>> >> What requires normal.h? Just curious >> > grub_file_getline is in normal.h

Re: [PATCH v4] commands/efi: add command to dump all uefi runtime variables

2025-05-11 Thread Vladimir 'phcoder' Serbinenko
Le dim. 11 mai 2025, 17:36, khaalid cali a écrit : > From: khaalid > > I followed the suggestion and implemented the option parsing using extcmd. > However, I feel this command is not ideal to have any arguments. Similar > commands like > lsefi, lsefimmap, and lsefisystab don’t take arguments—th

[PATCH v4] commands/efi: add command to dump all uefi runtime variables

2025-05-11 Thread khaalid cali
From: khaalid I followed the suggestion and implemented the option parsing using extcmd. However, I feel this command is not ideal to have any arguments. Similar commands like lsefi, lsefimmap, and lsefisystab don’t take arguments—they simply dump data. Since this command also just dumps variabl

Re: [PATCH] testpci: initial module

2025-05-11 Thread Yair Yarom
On Thu, 8 May 2025 at 17:30, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Le jeu. 8 mai 2025, 15:49, Yair Yarom a écrit : > >> +#include >> > What requires normal.h? Just curious > grub_file_getline is in normal.h > +struct grub_testpci_devlist { >> + char** devices; >> + int

Re: [PATCH v3] commands/efi: add command to dump all uefi runtime variables

2025-05-11 Thread Vladimir 'phcoder' Serbinenko
> > > > Changes in v3: > - Command arguments, maybe this command is better if it doesn't have > any command argument, since we are printing only. Command options is > just unneccessary. And this is how many grub commands does, so it > should align. > Options are good. Just use extcmd