Re: [PATCH 0/2] kern/efi/mm.c: add range check on risc-v

2025-04-21 Thread Adriano Cordova Fedeli
The series '[PATCH 0/3] Use -shared compilation instead of -Wl,-r' seems to fix the relocation error and grub loads fine when mcmodel=large. But still not sure what happens if mcmodel=medany and we allocate something more than 2GiB away, probably relocation overflow. On Mon, 21 Apr 2025 at 20:03,

Re: [PATCH 0/2] kern/efi/mm.c: add range check on risc-v

2025-04-21 Thread Vladimir 'phcoder' Serbinenko
Le mar. 22 avr. 2025, 01:13, Adriano Cordova Fedeli < adriano.cord...@canonical.com> a écrit : > Hi Vladimir, > > I just subscribed to the mailing list. Copying your 1/3 patch by hand says > it is corrupted. Do you have a git branch with that series for me to test, > or the .patch files? > Pushed

Re: [PATCH 0/2] kern/efi/mm.c: add range check on risc-v

2025-04-21 Thread Adriano Cordova Fedeli
Hi Vladimir, I just subscribed to the mailing list. Copying your 1/3 patch by hand says it is corrupted. Do you have a git branch with that series for me to test, or the .patch files? Best, Adriano On Mon, 21 Apr 2025 at 12:40, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > I belie

Re: [PATCH 0/2] kern/efi/mm.c: add range check on risc-v

2025-04-21 Thread Vladimir 'phcoder' Serbinenko
I believe the problem you describe is fixed by series of patches '[PATCH 0/3] Use -shared compilation instead of -Wl,-r'. Can you try them? Regards Vladimir 'phcoder' Serbinenko Le lun. 21 avr. 2025, 18:56, Adriano Cordova a écrit : > The current grub risc-v ELF loader does not support some of

[PATCH 1/2] kern/efi/mm.c: Add optional range check

2025-04-21 Thread Adriano Cordova
Add the flag GRUB_MM_ADD_REGION_IN_RANGE for the grub memory allocator for it to allocate memory only in a span of DEFAULT_MAX_COMBINED_SIZE around where EFI loaded grub. Signed-off-by: Adriano Cordova --- grub-core/kern/efi/mm.c | 56 ++--- include/grub/mm.h

[PATCH 2/2] kern/efi/mm.c: use GRUB_MM_ADD_REGION_IN_RANGE on risc-v

2025-04-21 Thread Adriano Cordova
Default to using GRUB_MM_ADD_REGION_IN_RANGE on risc-v. This is because the current grub risc-v ELF loader does not support some of the relocations produced by -mcmodel=large (e.g. when compiled with -mcmodel=large grub-mkimage returns 'error: relocation 0x2b is not implemented yet.'), so it has to

[PATCH 0/2] kern/efi/mm.c: add range check on risc-v

2025-04-21 Thread Adriano Cordova
The current grub risc-v ELF loader does not support some of the relocations produced by -mcmodel=large (e.g. when compiled with -mcmodel=large grub-mkimage returns 'error: relocation 0x2b is not implemented yet.'), so it has to be compiled with -mcmodel=medany, which only works if the grub code fit

Re: [PATCH v3 0/3] Add commands to load BLS and UKI files

2025-04-21 Thread Neal Gompa
On Thu, Apr 17, 2025 at 2:43 PM Daniel Kiper wrote: > > On Thu, Apr 17, 2025 at 07:37:13AM -0400, Neal Gompa wrote: > > On Fri, Apr 11, 2025 at 11:55 PM Alec Brown via Grub-devel > > wrote: > > > > > > v3: > > > - Added --enable-fallback option to check the default directory if the > > > --path