Re: [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support

Can I bribe someone to merge this fix, perhaps? ;) On 3/27/25 2:48 PM, Eric Sandeen wrote: > Grub folks, ping on this? It has 2 reviews and testing but I don't see it > merged yet. > > Thanks, > -Eric > > On 12/4/24 7:50 AM, Eric Sandeen wrote: >> When large extent counter / NREXT64 support was

[PATCH v12 07/13] libgcrypt: Fix coverity warnings

Signed-off-by: Vladimir Serbinenko --- .../libgcrypt-patches/03_mpiutil_alloc.patch | 20 ++ .../lib/libgcrypt-patches/03_sexp_free.patch | 37 +++ 2 files changed, 57 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/03_mpiutil_alloc.patch create mode 1

[PATCH v12 04/13] Adjust import script, definitions and API users for libgcrypt 1.11

This patches modifies the GRUB-libgcrypt API to match new libgcrypt 1.11 Signed-off-by: Vladimir Serbinenko --- autogen.sh| 5 + conf/Makefile.common | 4 +- grub-core/Makefile.core.def | 20 +- grub-core/command

[PATCH v12 08/13] Remove now unneeded gcrypt compilation flag

HAVE_STRTOUL is now defined in stdlib.h. Include it in g10lib.h rather than defining on command line Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common | 2 +- util/import_gcry.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.

[PATCH v12 10/13] libgcrypt: Import blake family of hashes

Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/06_blake.patch | 80 +++ include/grub/crypto.h | 6 ++ util/import_gcry.py | 36 +++-- 3 files changed, 115 insertions(+), 7 deletions(-) create mode 10064

[PATCH v12 09/13] gcry: Ignore sign-compare warnings

libgcrypt itself is compiled with -Wno-sign-compare. Do the same for consistency Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common| 2 +- grub-core/Makefile.core.def | 10 +- util/import_gcry.py | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --

[PATCH v12 12/13] import_gcry: Fix pylint warnings

Signed-off-by: Vladimir Serbinenko --- util/import_gcry.py | 1277 +-- 1 file changed, 623 insertions(+), 654 deletions(-) diff --git a/util/import_gcry.py b/util/import_gcry.py index 396ce0f68..cd54daca1 100644 --- a/util/import_gcry.py +++ b/util/import_

[PATCH v12 05/13] Add DSA and RSA SEXP tests

This allows us to test purely the integration of the implementation of DSA and RSA from libgcrypt without concerning with additional code. Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 16 grub-core/tests/dsa_sexp_test.c | 127 gr

[PATCH v12 06/13] keccak: Disable acceleration with SSE asm

Libgcrypt code assumes that on x64 all SSE registers are fair game. While it's true that CPUs in question support it, we disable it in our compilation options. Disable the offending optimization. Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/02_keccak_sse.patch | 25 ++

[PATCH v12 13/13] libgcrypt: Don't use 64-bit division on platforms where it's slow

Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/07_disable_64div.patch | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/07_disable_64div.patch diff --git a/grub-core/lib/libgcrypt-patches/07_disable_64div.patch b/grub-c

[PATCH v12 03/13] b64dec: Adjust for compilation in GRUB environment

Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c index 868d98568..8aafa9700 100644 --- a/grub-core/lib/b64dec.c +++ b/grub-core/l

[PATCH v12 02/13] Import b64dec from gpg-error

Imported from libgpg-error 1.51 Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 279 + 1 file changed, 279 insertions(+) create mode 100644 grub-core/lib/b64dec.c diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c new file mode

[PATCH v12 00/13] Upgrade libgcrypt to 1.11

Changes from v11: * Removed 64-bit division in mpi ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v11 05/14] Add DSA and RSA SEXP tests

This allows us to test purely the integration of the implementation of DSA and RSA from libgcrypt without concerning with additional code. Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 16 grub-core/tests/dsa_sexp_test.c | 127 gr

Re: [PATCH] i386: Reduce the time of set VESA mode by clearing FB directly for Zhaoxin/Glenfly card

Le lun. 14 avr. 2025, 05:38, Tony W Wang-oc a écrit : > While calling VBIOS to set VESA mode, BIOS/GRUB can indicate VBIOS to clear > frame buffer, it can also indicate VBIOS to skip this and do the clearing > itself by access linear frame buffer directly. > > Zhaoxin/Glenfly VBIOS is running at

Re: [PATCH v3 4/5] loader/efi/chainloader: Use shim loader image handle where available

On Tue, Apr 01, 2025 at 11:26:44AM +0100, Mate Kukri wrote: I think you should shortly explain here why this patch is needed. > Signed-off-by: Mate Kukri Otherwise patch LGTM... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu

Re: [PATCH v3 2/5] efi/sb: Add support for the shim loader protocol

On Tue, Apr 01, 2025 at 11:26:42AM +0100, Mate Kukri wrote: > Use loader protocol for image verification where available, otherwise > fall back to the old shim lock protocol. > > Signed-off-by: Mate Kukri > --- > grub-core/kern/efi/sb.c | 58 > grub-core/

Re: [PATCH 1/2] Include function name on debug traces

What is the code size increase on i386-pc? Did you test it? This is likely to result in a big one Regards Vladimir 'phcoder' Serbinenko Le sam. 12 avr. 2025, 01:03, Leo Sandoval via Grub-devel a écrit : > Together with the line number, the debug trace with the function name > provides a bit mor

Re: [PATCH v3 5/5] loader/efi/linux: Use shim loader image handle where available

On Tue, Apr 01, 2025 at 11:26:45AM +0100, Mate Kukri wrote: I think you should shortly explain here why this patch is needed. > Signed-off-by: Mate Kukri Otherwise patch LGTM... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu

Re: [PATCH 2/2] Prepend debug traces with absolute and relative timestamps

On Fri, Apr 11, 2025 at 04:01:05PM -0600, Leo Sandoval via Grub-devel wrote: > From: Renaud Métrich > > Debug traces with timestamps are useful to detect performance > issues. To enable it, include '--with-debug-timestamps' argument on > the configure step. > > Signed-off-by: Renaud Métrich > Sig

Re: [PATCH 1/2] Include function name on debug traces

On Fri, Apr 11, 2025 at 04:01:04PM -0600, Leo Sandoval via Grub-devel wrote: > Together with the line number, the debug trace with the function name > provides a bit more context and could be useful when inspecting log. > > Signed-off-by: Leo Sandoval Reviewed-by: Daniel Kiper Daniel _

Re: [PATCH v3 3/5] efi/sb: Add API for retrieving shim loader image handles

On Tue, Apr 01, 2025 at 11:26:43AM +0100, Mate Kukri wrote: > Not reusing these handles will result in image measurements showing up > twice in the event log. > > Signed-off-by: Mate Kukri > --- > grub-core/kern/efi/sb.c | 16 > include/grub/efi/sb.h | 4 > 2 files change

[PATCH v11 02/14] Import b64dec from gpg-error

Imported from libgpg-error 1.51 Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 279 + 1 file changed, 279 insertions(+) create mode 100644 grub-core/lib/b64dec.c diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c new file mode

Re: [PATCH v3 1/5] efi: Provide wrappers for load_image, start_image, unload_image

On Tue, Apr 01, 2025 at 11:26:41AM +0100, Mate Kukri wrote: > From: Julian Andres Klode > > These can be used to register a different implementation later, > for example, when shim provides a protocol with those functions. > > Signed-off-by: Mate Kukri Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH v1] grub-probe: detect DDF container similar to IMSM

On Mon, Apr 14, 2025 at 12:47:05PM +0300, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 21 juin 2024, 11:21, Renaud Métrich a écrit : > DDF and IMSM are very similar in handling, especially these should > not > be considered as RAID abstraction. > This fixes the requirement of

[PATCH v11 13/14] import_gcry: Make compatible with python 3.4

Signed-off-by: Vladimir Serbinenko --- util/import_gcry.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/util/import_gcry.py b/util/import_gcry.py index b6ddde9cd..396ce0f68 100644 --- a/util/import_gcry.py +++ b/util/import_gcry.py @@ -249,15 +249,15 @@ for ciphe

[PATCH v11 08/14] Remove now unneeded gcrypt compilation flag

HAVE_STRTOUL is now defined in stdlib.h. Include it in g10lib.h rather than defining on command line Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common | 2 +- util/import_gcry.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.

[PATCH v11 07/14] libgcrypt: Fix coverity warnings

Signed-off-by: Vladimir Serbinenko --- .../libgcrypt-patches/03_mpiutil_alloc.patch | 20 ++ .../lib/libgcrypt-patches/03_sexp_free.patch | 37 +++ 2 files changed, 57 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/03_mpiutil_alloc.patch create mode 1

[PATCH v11 12/14] libgcrypt: Import blake family of hashes

Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/06_blake.patch | 80 +++ include/grub/crypto.h | 6 ++ util/import_gcry.py | 36 +++-- 3 files changed, 115 insertions(+), 7 deletions(-) create mode 10064

[PATCH v11 09/14] Implement __aeabi_uldivmod

Some arm compilers insert 64-bit division into the code compiled from libgcrypt source and possibly others. Rether than fighting it, simply provide the function in question. Signed-off-by: Vladimir Serbinenko --- grub-core/kern/arm/compiler-rt.S | 11 +++ include/grub/compiler-rt.h

[PATCH v11 11/14] gcry: Ignore sign-compare warnings

libgcrypt itself is compiled with -Wno-sign-compare. Do the same for consistency Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common| 2 +- grub-core/Makefile.core.def | 10 +- util/import_gcry.py | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --

[PATCH v11 10/14] Enable (u)divdi3 and (u)moddi3 for mips

Some mips compilers insert 64-bit division into the code compiled from libgcrypt source and possibly others. Rather than fighting it, simply provide the functions in question. Signed-off-by: Vladimir Serbinenko --- gentpl.py| 2 +- grub-core/kern/compiler-rt.c | 6 +- gru

[PATCH v11 04/14] Adjust import script, definitions and API users for libgcrypt 1.11

This patches modifies the GRUB-libgcrypt API to match new libgcrypt 1.11 Signed-off-by: Vladimir Serbinenko --- autogen.sh| 5 + conf/Makefile.common | 4 +- grub-core/Makefile.core.def | 20 +- grub-core/command

[PATCH v11 06/14] keccak: Disable acceleration with SSE asm

Libgcrypt code assumes that on x64 all SSE registers are fair game. While it's true that CPUs in question support it, we disable it in our compilation options. Disable the offending optimization. Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/02_keccak_sse.patch | 25 ++

[PATCH v11 14/14] import_gcry: Fix pylint warnings

Signed-off-by: Vladimir Serbinenko --- util/import_gcry.py | 1277 +-- 1 file changed, 623 insertions(+), 654 deletions(-) diff --git a/util/import_gcry.py b/util/import_gcry.py index 396ce0f68..cd54daca1 100644 --- a/util/import_gcry.py +++ b/util/import_

[PATCH v11 03/14] b64dec: Adjust for compilation in GRUB environment

Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c index 868d98568..8aafa9700 100644 --- a/grub-core/lib/b64dec.c +++ b/grub-core/l

[PATCH v11 00/14] Upgrade libgcrypt to 1.11

Upgrade libgcrypt to 1.11. Changes from previous version: * Export signed in addition to unsigned division on mips ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 20/21] appendedsig: The grub command's trusted and distrusted support

On Thu, Mar 27, 2025 at 01:02:41AM +0530, Sudhakar Kuppusamy wrote: > To support the following trusted and distrusted commands > > 1. trusted_list: > It will show the list of trusted certificates and binary hashes > 2. distrusted_list: > It will show the list of distrusted cert