Re: [PATCH v5 11/13] docs: Update NV index mode of TPM2 key protector

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:25PM +0800, Gary Lin wrote: > This commit updates the NV index mode section and the grub-protect > section to reflect the recent changes in TPM2 key protector and > grub-protect. > > Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v5 10/13] tests/tpm2_key_protector_test: Add more NV index mode tests

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:24PM +0800, Gary Lin wrote: > Two more NV index test cases are added to test key sealing and > unsealing with the NV index handle 0x100. > > Signed-off-by: Gary Lin > Reviewed-by: Stefan Berger Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v5 13/13] docs: Document the long options of tpm2_key_protect_init

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:27PM +0800, Gary Lin wrote: > Add the long options of tpm2_key_protect_init along with the short > options. > > Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [PATCH v5 09/13] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 09:26:00AM -0400, Stefan Berger wrote: > On 4/7/25 4:29 AM, Gary Lin wrote: > > Reset 'ret' to 0 when a test case fails so that the other test cases > > could continue. > > > > Also set the exit status to 1 when encountering a failure to reflect the > > test result. > > > >

Re: [PATCH v5 05/13] tpm2_key_protector: Unseal key from a buffer

2025-04-09 Thread Daniel Kiper via Grub-devel
On Mon, Apr 07, 2025 at 04:29:19PM +0800, Gary Lin wrote: > Extract the logic to handle the file buffer from the SRK recover > function to prepare to load the sealed key from the NV index handle, > so the NV index mode can share the same code path in the later patch. > The SRK recover function now