Re: [PATCH v2] loader/efi/chainloader: Add efidriver command

2025-03-01 Thread Glenn Washburn
On Sat, 26 Oct 2024 10:24:05 +0500 Nikita Travkin via Grub-devel wrote: > Nikita Travkin писал(а) 24.09.2024 21:29: > > Sometimes it's useful to load EFI drivers. Since loading a driver is > > the same as starting it and UEFI handles cleanup after on it's own, we > > can piggy back on existing ch

Re: [PATCH v2 0/4] EFI envblk

2025-03-01 Thread Glenn Washburn
Daniel, Is this still in the to be reviewed queue? Despite how long its been, I believe this patch series still applies cleanly to master. Glenn On Mon, 23 Sep 2024 01:04:54 -0500 Glenn Washburn wrote: > Update v2: > * Rebase onto current master. This really did not change the contents of >

[PATCH v6 3/6] commands/ls: Show modification time for file paths

2025-03-01 Thread Glenn Washburn
The modification time for paths to files was not being printed because the grub_dirhook_info, which contains the mtime, was initialized to NULL. Instead of calling print_file() directly, use fs->fs_dir() to call print_file() with a properly filled in grub_dirhook_info. This has the added benefit of

[PATCH v6 6/6] commands/ls: Add directory header for dir args

2025-03-01 Thread Glenn Washburn
Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13 inserti

[PATCH v6 0/6] More ls improvements

2025-03-01 Thread Glenn Washburn
Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Washburn v6: * Rebase onto current master * Change ctx->filen

[PATCH v6 4/6] commands/ls: Output path for single file arguments given with path

2025-03-01 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 1b447acf7c34..886441575cac 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file (con

[PATCH v6 2/6] commands/ls: Merge print_files_long and print_files into print_file

2025-03-01 Thread Glenn Washburn
Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 65b17

[PATCH v6 5/6] commands/ls: Print full paths for file args

2025-03-01 Thread Glenn Washburn
For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 886441575cac..09de23bb0b3a

[PATCH v6 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

2025-03-01 Thread Glenn Washburn
Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index f660946a24e4..65b17768b605 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/com

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

2025-03-01 Thread Glenn Washburn
On Fri, 28 Feb 2025 14:04:51 +0100 Daniel Kiper via Grub-devel wrote: > Huh! > > B Horn, may I ask you to take a look at this and prepare a fix? > > Andreas, please help with testing the fix. Not that anyone cares, but this regression was caught by the file system tests. It causes grub-fstest

Re: [PATCH v4 5/6] commands/ls: Print full paths for file args

2025-03-01 Thread Daniel Kiper
On Sat, Mar 01, 2025 at 03:54:25PM -0600, Glenn Washburn wrote: > On Thu, 27 Feb 2025 17:27:29 +0100 > Daniel Kiper wrote: > > On Thu, Feb 27, 2025 at 12:28:31AM -0600, Glenn Washburn wrote: > > > On Mon, 24 Feb 2025 18:14:59 +0100 Daniel Kiper > > > wrote: > > > > On Mon, Jan 06, 2025 at 01:02:

[PATCH v5 5/6] commands/ls: Print full paths for file args

2025-03-01 Thread Glenn Washburn
For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 886441575cac..8f6440e845fd 100644

[PATCH v5 4/6] commands/ls: Output path for single file arguments given with path

2025-03-01 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 1b447acf7c34..886441575cac 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file (con

[PATCH v3] acpi: Use options enum to index command options

2025-03-01 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- v3: * Specify first enum const value * Fix improperly using OPTION_EXCLUDE instead of OPTION_LOAD_ONLY v2: Rebase to current master --- Range-diff against v2: 1: 8b14fcf62f88 ! 1: a51e20bb9b10 acpi: Use options enum to index command options @@ grub-core/c