Re: [PATCH v4 5/5] ieee1275: ofpath enable NVMeoF logical device translate

2025-02-12 Thread Avnish Chouhan
Hi Michael, Thank you so much for a review! I'll add the failure checks in the code mentioned by you. On build issue. I haven't observed any of these errors on my machine. Today, I built the latest upstream grub with this patch on my machine and no errors are observed. Regards, Avnish Chouha

Re: [PATCH v4 5/5] ieee1275: ofpath enable NVMeoF logical device translate

2025-02-12 Thread Michael Chang via Grub-devel
Hi Avnish, This patch doesn't build: ../grub-core/osdep/linux/ofpath.c: In function ‘of_path_of_nvme’: ../grub-core/osdep/linux/ofpath.c:729:37: error: ‘%x’ directive output may be truncated writing between 1 and 8 bytes into a region of size 7 [-Werror=format-truncation=] 729 |