Re: [PATCH v2 09/10] tests/tpm2_key_protector_test: Amend the NV index mode test

2025-01-09 Thread Gary Lin via Grub-devel
On Thu, Jan 09, 2025 at 02:13:02PM -0500, Stefan Berger wrote: > > > On 1/8/25 10:58 PM, Gary Lin wrote: > > Since 'grub-protect' already supports NV index mode, tpm2_seal_nv() is > > replaced with one 'grub-protect' command to simplify the test script. > > > > Two more NV index test cases are a

Re: [PATCH v2 08/10] util/grub-protect: Support NV index mode

2025-01-09 Thread Gary Lin via Grub-devel
On Thu, Jan 09, 2025 at 02:03:47PM -0500, Stefan Berger wrote: > > > On 1/8/25 10:58 PM, Gary Lin wrote: > > This commit implements the missing NV index mode support in > > 'grub-protect'. NV index mode stores the sealed key in the TPM > > non-volatile memory (NVRAM) instead of a file. There are

Re: [PATCH v2 07/10] tpm2_key_protector: Support NV index handles

2025-01-09 Thread Gary Lin via Grub-devel
On Thu, Jan 09, 2025 at 01:03:54PM -0500, Stefan Berger wrote: > > > On 1/8/25 10:58 PM, Gary Lin wrote: > > Previously, NV index mode only supported persistent handles which are > > only for TPM objects. > > > > On the other hand, the "NV index" handle allows the user-defined data, > > so it ca

Re: [PATCH v2 09/10] tests/tpm2_key_protector_test: Amend the NV index mode test

2025-01-09 Thread Stefan Berger
On 1/8/25 10:58 PM, Gary Lin wrote: Since 'grub-protect' already supports NV index mode, tpm2_seal_nv() is replaced with one 'grub-protect' command to simplify the test script. Two more NV index test cases are also added to test key sealing and unsealing with the NV index handle 0x100. Al

Re: [PATCH v2 08/10] util/grub-protect: Support NV index mode

2025-01-09 Thread Stefan Berger
On 1/8/25 10:58 PM, Gary Lin wrote: This commit implements the missing NV index mode support in 'grub-protect'. NV index mode stores the sealed key in the TPM non-volatile memory (NVRAM) instead of a file. There are two supported types of TPM handles. 1. Persistent handle (0x8100~0x81F

Re: [PATCH v2 07/10] tpm2_key_protector: Support NV index handles

2025-01-09 Thread Stefan Berger
On 1/8/25 10:58 PM, Gary Lin wrote: Previously, NV index mode only supported persistent handles which are only for TPM objects. On the other hand, the "NV index" handle allows the user-defined data, so it can be an alternative to the key file and support TPM 2.0 Key File format immediately. T

[PATCH] term/ns8250: return in case of a null SPCR base addresses

2025-01-09 Thread Leo Sandoval
Serial SPCR MMIO null address are invalid, so return from function, otherwise invalid 'mmio,0' port names are generated halting the system when running terminal_input|output commands. Signed-off-by: Leo Sandoval --- grub-core/term/ns8250.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/g

Re: [PATCH v2 10/10] docs: Update NV index mode of TPM2 key protector

2025-01-09 Thread Stefan Berger
On 1/8/25 10:58 PM, Gary Lin wrote: This commit updates the NV index mode section and the grub-protect section to reflect the recent changes in TPM2 key protector and grub-protect. Signed-off-by: Gary Lin --- docs/grub.texi | 188 +++-- 1 file ch