Re: [PATCH 10/10] docs: Update NV index mode of TPM2 key protector

On Thu, Jan 02, 2025 at 04:50:53PM -0500, Stefan Berger wrote: > > > On 12/19/24 3:12 AM, Gary Lin via Grub-devel wrote: > > This commit updates the NV index mode section and the grub-protect > > section to reflect the recent changes in TPM2 key protector and > > grub-protect. > > > > Signed-off

[PATCH v4 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13 inserti

[PATCH v4 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index e33c16158d63..384d3e3cede8 100644

[PATCH v4 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 9e69b

[PATCH v4 3/6] commands/ls: Show modification time for file paths

The modification time for paths to files was not being printed because the grub_dirhook_info, which contains the mtime, was initialized to NULL. Instead of calling print_file() directly, use fs->fs_dir() to call print_file() with a properly filled in grub_dirhook_info. This has the added benefit of

[PATCH v4 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 6a1c7f5d3626..9e69b19371d5 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/com

[PATCH v4 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Washburn v4: Add missing parenthesis Glenn Washburn (6): com

[PATCH v4 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index ed296a536554..e33c16158d63 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file (con

Re: [PATCH v1 01/21] powerpc-ieee1275: Add support for signing grub with an appended signature

Reviewed-by: Avnish Chouhan  On 2024-12-18 20:26, Sudhakar Kuppusamy wrote: From: Rashmica Gupta Add infrastructure to allow firmware to verify the integrity of grub by use of a Linux-kernel-module-style appended signature. We initially target powerpc-ieee1275, but the code should be extensibl

Re: [PATCH] Mandatory install device check for PowerPC

Hi Vladimir, Did you get a chance to review my response to your query? Thank you! Regards, Avnish Chouhan On 2024-11-28 16:11, Avnish Chouhan wrote: (Resending the email due to missing proper subject line caused by some glitches in my application) Hi Vladimir, Hope you're doing wonderful! Di

[PATCH] commands/file: Fix null dereference in the knetbsd tests

From: Lukas Fink The pointer returned by grub_elf_file() is not checked to verify it is not null before use. A null pointer may be returned when the given file does not have a valid ELF header. Fixes: https://savannah.gnu.org/bugs/?61960 Signed-off-by: Lukas Fink Signed-off-by: Glenn Washburn