Re: [PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM VG

Hi Patrick, It looks like you're not using the --thread option for git format-patch. Would you please use that for the next version? That option will keep the patch set together for those with email clients with threaded view. Thanks. Glenn On Sat, 4 Jan 2025 15:16:59 -0500 Patrick Plenefisch w

[PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM VG

In an effort to solve https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself, I implemented basic support for cachevol and integrity volumes in LVM. This is just an extension of the cachepool support that already existed, and just like that support, I ignore all of the metadata and j

[PATCH 1/6 v13] disk/lvm: Make cache_lv more generic as ignored_feature_lv

This patch isn't necessary by itself, but when combined with the next two patchs it enhances readability as ignored_features_lv is then used for multiple types of extra LV's, not just cache LV's Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper --- grub-core/disk/lvm.c | 176 +

[PATCH 2/6 v13] disk/lvm: Remove unused cache_pool

cache_pool is never read or used, remove it Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper --- grub-core/disk/lvm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 36023279f..286132d74 100644 --- a/grub

[PATCH 3/6 v13] lvm: Match all lvm segments before validation

pv matching must be completely finished before validating a volume, otherwise referenced raid stripes may not have pv data applied yet This change is required for integrity & cachevol support Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper --- grub-core/disk/diskfilter.c | 6 --

[PATCH 4/6 v13] lvm: Add support for integrity lv

lv matching must be done after processing the ignored feature indirections, as integrity volumes & caches may have several levels of indirection that the segments must be shifted through. Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper --- grub-core/disk/lvm.c | 70 +

[PATCH 5/6 v13] lvm: add informational messages in error cases of ignored features

Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 9c9386751..abb5b12ae 100644 --- a/grub-core/disk/lvm.c +++ b/grub-core/disk/lvm.c @@ -818,6 +818,14 @@

[PATCH 6/6 v13] lvm: Add support for cachevol lv

Mark cachevol lv's as ignored features, which is true only if they are configured as "writethrough". This patch does not let grub boot from "writeback" cache-enabled lv's Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper --- grub-core/disk/lvm.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v1 06/21] crypto: move storage for grub_crypto_pk_* to crypto.c

Reviewed-By: Vladimir Serbinenko On Wed, Dec 18, 2024 at 5:59 PM Sudhakar Kuppusamy wrote: > > From: Daniel Axtens > > The way gcry_rsa and friends (the asymmetric ciphers) are loaded for the > pgp module is a bit quirky. > > include/grub/crypto.h contains: > extern struct gcry_pk_spec *grub_

Re: [PATCH v1 05/21] pgp: factor out rsa_pad

rsa_pad will be removed when we update libgcrypt (see pending patch). Can we accommodate for this? On Wed, Dec 18, 2024 at 5:58 PM Sudhakar Kuppusamy wrote: > > From: Daniel Axtens > > rsa_pad does the PKCS#1 v1.5 padding for the RSA signature scheme. > We want to use it in other RSA signature v

Re: [PATCH v1 04/21] dl: provide a fake grub_dl_set_persistent for the emu target

grub-emu has 2 modes: full with all modules compiled-in and lite with actual module loading (mostly useful for testing module loading itself. So just adding if (mod) ... is going to fix all cases and avoids ifdef On Wed, Dec 18, 2024 at 5:58 PM Sudhakar Kuppusamy wrote: > > From: Daniel Axtens >

Re: [PATCH v1 03/21] docs/grub: Document signing grub with an appended signature

May we instead invoke sign-file from grub-mkimage as to spare the user the hassle? On Wed, Dec 18, 2024 at 5:58 PM Sudhakar Kuppusamy wrote: > > From: Daniel Axtens > > Signing grub for firmware that verifies an appended signature is a > bit fiddly. I don't want people to have to figure it out f

Re: [PATCH v1 01/21] powerpc-ieee1275: Add support for signing grub with an appended signature

Passing signature size to the tools looks very clumsy. How does the user know the signature size? Can we somehow determine it programmatically ourselves? On Wed, Dec 18, 2024 at 5:58 PM Sudhakar Kuppusamy wrote: > > From: Rashmica Gupta > > Add infrastructure to allow firmware to verify the inte

Re: [PATCH v2] acpi: Use options enum to index command options

Reviewed-by: Vladimir Serbinenko On Fri, Jan 3, 2025 at 9:13 AM Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > --- > This should be a quick review. > > v2: Rebase to current master > > Glenn > --- > Range-diff against v1: > 1: fbaf2eb14231 ! 1: 8b14fcf62f88 acpi: Use options enum t

[PATCH v3 3/6] commands/ls: Show modification time for file paths

The modification time for paths to files was not being printed because the grub_dirhook_info, which contains the mtime, was initialized to NULL. Instead of calling print_file() directly, use fs->fs_dir() to call print_file() with a properly filled in grub_dirhook_info. This has the added benefit of

[PATCH v3 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13 inserti

[PATCH v3 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index b0f139cf133a..e671313e6a0e 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file (con

[PATCH v3 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index e671313e6a0e..a419174a81a5 100644

[PATCH v3 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 9e69b

[PATCH v3 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Glenn Washburn (6): commands/ls: Return proper GRUB_ERR_* for

[PATCH v3 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 6a1c7f5d3626..9e69b19371d5 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/com