[PATCH v3 1/3] docs: Small Fixes for Network, Secure Boot, PXE

Correct documentation for pxe_default_server, pxe_default_gatway, and pxe_blksize. Only pxe_default_server is actually used (alias for net_default_server) so capture this, and remove the other two. Fixes: https://savannah.gnu.org/bugs/?54480 Signed-off-by: Andrew Hamilton --- docs/grub.texi |

[PATCH v3 0/3] docs: Small Fixes for Network, Secure Boot, PXE

Currently the GRUB Manual has a few small issues captured in bug reports (54480, 62004, and 65152). These are related to issues in documentation for environment variables "pxe_default_server", "pxe_default_gateway"; incorrect statement that "chainloader" does not support secure boot; and an issue i

Re: [PATCH v2 1/1] docs: Small Fixes for Network, Secure Boot, PXE

Thank you for the review and feedback, I will send a corrected (v3) version of this patch series shortly. Thanks, Andrew On Thu, Oct 24, 2024 at 12:14 PM Daniel Kiper wrote: > > On Sat, Oct 19, 2024 at 08:28:57AM -0500, Andrew Hamilton wrote: > > Closes: https://savannah.gnu.org/bugs/?54480 > >

[PATCH v3 3/3] docs: Small Fixes for Network, Secure Boot, PXE

Correct the documentation for the grub.cfg searching via network that will be done based on a given MAC address (was missing the Ethernet Type - 01). Fixes: https://savannah.gnu.org/bugs/?65152 Signed-off-by: Andrew Hamilton --- docs/grub.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH v3 2/3] docs: Small Fixes for Network, Secure Boot, PXE

Correct documentation for secure boot with UEFI to remove statement that chainloader does not work with secure boot, as this was added by a previous GRUB update. Fixes: https://savannah.gnu.org/bugs/?62004 Signed-off-by: Andrew Hamilton --- docs/grub.texi | 14 +++--- 1 file changed, 7

Re: [PATCH v20 33/33] docs: Document TPM2 key protector

On Mon, Oct 21, 2024 at 04:07:11PM +0800, Gary Lin wrote: > Update the user manual to address TPM2 key protector including the two > related commands, tpm2_key_protector_init and tpm2_key_protector_clear, > and the user-space utility: grub-protect. > > Signed-off-by: Gary Lin > --- > docs/grub.te

Re: [PATCH v2] Re-order grub_serial_find to fix default to com0 on some platforms

On Wed, Oct 16, 2024 at 10:09:30AM -0700, Adam Williamson wrote: > 7b192ec4c rejigged the serial port detection code when no port > is explicitly specified. Before 7b192ec4c we did > grub_serial_find ("com0") in this case, which on *any* platform > would return a port called "com0" if one was found

Re: [PATCH v2 1/1] docs: Small Fixes for Network, Secure Boot, PXE

On Sat, Oct 19, 2024 at 08:28:57AM -0500, Andrew Hamilton wrote: > Closes: https://savannah.gnu.org/bugs/?54480 > Closes: https://savannah.gnu.org/bugs/?62004 > Closes: https://savannah.gnu.org/bugs/?65152 s/Closes/Fixes/ > Signed-off-by: Andrew Hamilton This patch fix three separate issues. Pl

Re: [PATCH] legacycfg.c: avoid closing file twice

On Wed, Oct 16, 2024 at 11:54:38AM -0600, Leo Sandoval wrote: > An Internal (at Red Hat) static soure code scan detected the issue below, > pointing to an use-after-free scenario so remove the extra file close > call. > > Error: USE_AFTER_FREE (CWE-416): > grub-2.06/grub-core/commands/legac

Re: [PATCH v20 00/33] Automatic Disk Unlock with TPM2

On Wed, Oct 23, 2024 at 03:52:43PM +0200, Daniel Kiper wrote: > On Mon, Oct 21, 2024 at 04:06:38PM +0800, Gary Lin wrote: > > GIT repo for v20: https://github.com/lcp/grub2/tree/tpm2-unlock-v20 > > > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > > Hernan Gatta to intro

Re: [PATCH v20 23/33] key_protector: Add TPM2 Key Protector

On Wed, Oct 23, 2024 at 07:02:20PM +0200, Daniel Kiper wrote: > On Mon, Oct 21, 2024 at 04:07:01PM +0800, Gary Lin wrote: > > From: Hernan Gatta > > > > The TPM2 key protector is a module that enables the automatic retrieval > > of a fully-encrypted disk's unlocking key from a TPM 2.0. > > > > The