Re: [PATCH v19 21/33] tss2: Add TPM2 Software Stack (TSS2) support

2024-09-17 Thread Stefan Berger
On 9/6/24 5:11 AM, Gary Lin wrote: A Trusted Platform Module (TPM) Software Stack (TSS) provides logic to compose and submit TPM commands and parse reponses. +static TPM_RC_t +tpm2_submit_command_real (const TPMI_ST_COMMAND_TAG_t tag, + const TPM_CC_t commandCode, +

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-09-17 Thread Gary Lin via Grub-devel
On Tue, Sep 17, 2024 at 03:23:00PM -0400, Stefan Berger wrote: > > > On 9/16/24 1:42 PM, Stefan Berger wrote: > > > > > > On 9/15/24 11:35 PM, Gary Lin wrote: > > > On Mon, Sep 16, 2024 at 10:24:03AM +0800, Gary Lin wrote: > > > > On Fri, Sep 13, 2024 at 10:32:39AM -0400, Stefan Berger wrote: >

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-09-17 Thread Gary Lin via Grub-devel
On Mon, Sep 16, 2024 at 01:42:18PM -0400, Stefan Berger wrote: > > > On 9/15/24 11:35 PM, Gary Lin wrote: > > On Mon, Sep 16, 2024 at 10:24:03AM +0800, Gary Lin wrote: > > > On Fri, Sep 13, 2024 at 10:32:39AM -0400, Stefan Berger wrote: > > > > > > > > > > > > On 9/6/24 5:10 AM, Gary Lin wrote:

Re: [PATCH 10/24] include/grub: Introduce Secure Launch Resource Table (SLRT)

2024-09-17 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Provide definitions of structures and basic functions for constructing and parsing of SLRT. I looked this all over and it is inline with the layout of the tables (ABI) of the most recent SLRT (both in the v11 release code and the

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-09-17 Thread Stefan Berger
On 9/16/24 1:42 PM, Stefan Berger wrote: On 9/15/24 11:35 PM, Gary Lin wrote: On Mon, Sep 16, 2024 at 10:24:03AM +0800, Gary Lin wrote: On Fri, Sep 13, 2024 at 10:32:39AM -0400, Stefan Berger wrote: On 9/6/24 5:10 AM, Gary Lin wrote: GIT repo for v19: https://github.com/lcp/grub2/tree/t

Re: [PATCH v2] util/grub.d/30_os-prober.in: Fix GRUB_OS_PROBER_SKIP_LIST for non-EFI

2024-09-17 Thread Pascal Hambourg
On 08/05/2024 at 01:03, Pascal Hambourg wrote: GRUB documentation states: ‘GRUB_OS_PROBER_SKIP_LIST’ List of space-separated FS UUIDs of filesystems to be ignored from os-prober output. For efi chainloaders it’s @ But the actual behaviour does not match this description. GRUB_OS_PROBE

Re: [PATCH 11/24] i386/slaunch: Add basic platform support for secure launch

2024-09-17 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Some of the commands declared in header files will be implemented in the follow-up commits. Oh and in the split out patch, can you fix the commit message to just indicate this is generic x86 bits? Ross Signed-off-by: Ross Ph

Re: [PATCH 11/24] i386/slaunch: Add basic platform support for secure launch

2024-09-17 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Ross Philipson Some of the commands declared in header files will be implemented in the follow-up commits. In addition to submitting the first seven patches standalone, if you split this patch up and remove the slaunch.h changes, you can then

Re: [PATCH 07/24] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

2024-09-17 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper The functions calculate lowest and highest available RAM addresses respectively. Both functions are needed to calculate PMR boundaries for Intel TXT secure launcher introduced by subsequent patches. After discussing this we think t