[PATCH v2] bli: Fix crash in get_part_uuid

2024-07-16 Thread Michael Chang via Grub-devel
The get_part_uuid() function made an assumption that the target grub device is a partition device and accessed device->disk->partition without checking for NULL. There are four situations where this assumption is problematic: 1. The device is a net device instead of a disk. 2. The device is an abs

Re: [PATCH] bli: Fix crash in get_part_uuid

2024-07-16 Thread Michael Chang via Grub-devel
On Tue, Jul 16, 2024 at 05:45:10AM GMT, Oliver Steffen wrote: > Quoting Michael Chang via Grub-devel (2024-07-16 08:55:00) > > The get_part_uuid() function made an assumption that the target grub > > device is a partition device and accessed device->disk->partition > > without checking for NULL. Th

Re: EFI El Torito image on ISO9660 (was: [PATCH] bli: Fix crash in get_part_uuid)

2024-07-16 Thread Michael Chang via Grub-devel
On Tue, Jul 16, 2024 at 10:47:57AM GMT, Pascal Hambourg wrote: > On 16/07/2024 at 08:55, Michael Chang via Grub-devel wrote: > > > > 4. When booting from an ISO, the ESP is treated as an El Torito image in > > the boot catalog. It is therefore presented by firmware and > > interpreted by g

Re: [PATCH] bli: Fix crash in get_part_uuid

2024-07-16 Thread Oliver Steffen
Quoting Michael Chang via Grub-devel (2024-07-16 08:55:00) > The get_part_uuid() function made an assumption that the target grub > device is a partition device and accessed device->disk->partition > without checking for NULL. There are four situations where this > assumption is problematic: > > 1.

Re: [PATCH v5 2/2] efi: new 'connectefi' command

2024-07-16 Thread Renaud Métrich
It could indeed be done automatically, but not always, because by default it's not needed and also because connecting EFI devices can be long apparently. So I fear that as soon as a "search" would fail, triggering the connection internally will slow down the boot, even though the search was s

EFI El Torito image on ISO9660 (was: [PATCH] bli: Fix crash in get_part_uuid)

2024-07-16 Thread Pascal Hambourg
On 16/07/2024 at 08:55, Michael Chang via Grub-devel wrote: 4. When booting from an ISO, the ESP is treated as an El Torito image in the boot catalog. It is therefore presented by firmware and interpreted by grub as a disk (cd0). In my limited experience, (cd0) is the whole CD/DVD/BD a