[PATCH 0/2] grub-fstest: Show error message if command causes grub_errno

2024-06-20 Thread Thomas Schmitt via Grub-devel
Most return values of function execute_command() are ignored in util/grub-fstest.c. Only one of two "loopback" occasions and the command "cryptomount" care. They perform grub_util_error() if the return value is non-zero. So there seems to be a general lack of handling of problems found in the drive

[PATCH 2/2] tests: Use new grub-fstest option -E with iso9660_ce_loop test

2024-06-20 Thread Thomas Schmitt via Grub-devel
This part of tests/iso9660_test works on an intentionally bad ISO which with older versions of GRUB will cause an endless cycle. Therefore the test runs grub-fstest under the program timeout. A non-zero exit value is taken as indication that the timeout was triggered. Non-empty output from grub-fst

[PATCH 1/2] grub-fstest: Show error message if command causes grub_errno

2024-06-20 Thread Thomas Schmitt via Grub-devel
Check grub_errno after a command was performed. If not GRUB_ERR_NONE then print grub_errno and grub_errmsg. Count the errors and exit 1 with a message if the count is larger than zero when function fs_test() ends. The number of printed messages is restricted to 3. Introduce a new option -E which r

Re: [PATCH v17 11/20] key_protector: Add TPM2 Key Protector

2024-06-20 Thread Daniel Kiper via Grub-devel
On Thu, Jun 20, 2024 at 03:35:32PM +0800, Gary Lin wrote: > On Wed, Jun 19, 2024 at 06:34:13PM +0200, Daniel Kiper wrote: > > On Fri, Jun 14, 2024 at 02:45:44PM +0800, Gary Lin wrote: > > > From: Hernan Gatta > > > > > > The TPM2 key protector is a module that enables the automatic retrieval > > >

Re: [PATCH v17 10/20] tpm2: Add TPM Software Stack (TSS)

2024-06-20 Thread Daniel Kiper via Grub-devel
On Thu, Jun 20, 2024 at 02:13:02PM +0800, Gary Lin wrote: > On Wed, Jun 19, 2024 at 04:04:47PM +0200, Daniel Kiper wrote: > > On Wed, Jun 19, 2024 at 02:41:13PM +0800, Gary Lin wrote: > > > On Tue, Jun 18, 2024 at 03:30:03PM +0200, Daniel Kiper wrote: > > > > On Fri, Jun 14, 2024 at 02:45:43PM +080

Re: [PATCH] fs/erofs: Fix EROFS label tests in grub-fs-tester

2024-06-20 Thread Daniel Kiper
On Wed, Jun 12, 2024 at 03:28:41PM +0800, Yifan Zhao wrote: > mkfs.erofs with version < 1.6 does not support the -L option. > Let's detect the version of mkfs.erofs and skip the label tests > if it is not supported. > > Signed-off-by: Yifan Zhao Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH 2/2] zfs: Add test for zfs zstd

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 02:44:09PM +0300, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] zfs: Support zstd compression

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 02:44:08PM +0300, Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] emu/linux: Fix determination of program name

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 03:56:31PM +0300, Vladimir Serbinenko wrote: > Current code works only if package matches binary name transformation rules. > It's often true but is no waz guaranteed > > Fixes bug #64410 > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH 1/2] cryptodisk: Fix translatable message

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 03:56:30PM +0300, Vladimir Serbinenko wrote: > Fixes bug #64408. > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-

Re: [PATCH] getroot: Unmark 2 strings for translation

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 03:59:56PM +0300, Vladimir Serbinenko wrote: > First they're use macros so they can't be translated as-is. > Second there is no point in translating them as they're too technical. > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v3] loader/efi/fdt: Add fdtdump command to access device tree

2024-06-20 Thread Daniel Kiper
On Mon, Jun 17, 2024 at 05:10:26PM +0200, Tobias Heider wrote: > The fdtdump command allows dumping arbitrary device tree properties > and saving them to a variable similar to the smbios command. > > This is useful in scripts where further actions such as selecting a > kernel or loading another de

Re: [PATCH v3 2/6] ieee1275/powerpc: enables device mapper discovery

2024-06-20 Thread avnish
Hi Vladimir, We have implemented this code to enable the ieee1275 hint for grub. We had scenarios (in SLES) like the disk had PReP partition followed by an LVM and, inside this LVM , the boot partition. So, we implemented this code to make grub able to generate the hint. Without this code, we

Re: [PATCH v3 2/6] ieee1275/powerpc: enables device mapper discovery

2024-06-20 Thread Vladimir 'phcoder' Serbinenko
Concept of ofpathname is clear: return OF path to a given device or NULL if none. Returning anything else is a bug even if it ends up helping you somewhere. Le jeu. 20 juin 2024, 12:45, avnish a écrit : > Hi Vladimir, > > We have implemented this code to enable the ieee1275 hint for grub. We > h

Re: [PATCH v17 11/20] key_protector: Add TPM2 Key Protector

2024-06-20 Thread Gary Lin via Grub-devel
On Wed, Jun 19, 2024 at 06:34:13PM +0200, Daniel Kiper wrote: > On Fri, Jun 14, 2024 at 02:45:44PM +0800, Gary Lin wrote: > > From: Hernan Gatta > > > > The TPM2 key protector is a module that enables the automatic retrieval > > of a fully-encrypted disk's unlocking key from a TPM 2.0. > > > > The

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-06-20 Thread Michael Chang via Grub-devel
On Thu, Jun 20, 2024 at 02:48:55PM GMT, Michael Chang wrote: > A regression in grub 2.12 causes the grub screen to become cluttered > with artifacts from the previous screen, whether it's the UEFI post ui, > UEFI shell, or any graphical UI running before grub. this issue occurs > in situations like