Re: [PATCH] fs/xfs: Handle non-continuous data blocks in directory extents

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
On Sat, Feb 17, 2024 at 12:39 AM Jon DeVree wrote: > > On Thu, Feb 15, 2024 at 20:33:13 +0300, Vladimir 'phcoder' Serbinenko wrote: > > Is the pointer guaranteed to be aligned? If not you have to use unaligned > > access. > > I don't know what alignment guarantees grub_malloc() makes. As long as >

[PATCH] Implement fmap support

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
fmap (flash map) is a partition table used by coreboot. Support it in order to retrieve the files in non-default partition Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-Implement-fmap-support.patch Description: Binary data ___

loadenv.c - How to check if a file is writable or not?

2024-03-15 Thread Aaron Rainbolt
Good morning/evening, and thanks for your time. I'm currently attempting to implement a patch in the GRUB that will allow the `load_env` command to set an environment variable in the event the grubenv file can be read from but cannot be written to (for instance, if the file is on a BTRFS files

[PATCH] grub-fstest: Add a new command zfs-bootfs.

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
This is useful to check zfs-bootfs command. Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-grub-fstest-Add-a-new-command-zfs-bootfs.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https

[PATCH] Improve cbfs detection

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
With FMAP and non-continuous SPI old way of reading CBFS pointer is no longer reliable. Hence use new lbio tags to detect the correct cbfs layout Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-Improve-cbfs-detection.patch Description: Binary data

[PATCH] Add commands for reading and writing raw bytes to CMOS

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
With some coreboot configs setting a byte to a magic value changes behaviour on next boot. Setting bit-by-bit is possible but not convenient. Add cmosread and cmoswrite for convenience. Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-Add-commands-for-reading-a

[PATCH] Enable cmos on x86 EFI

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
CMOS actually exists on most EFI platforms and in some cases used to store useful data that makes it useful for GRUB to read/write it As for datetime keep using EFI API and not CMOS Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-Enable-cmos-on-x86-EFI.patch

[PATCH v2] acpi: Mark MADT entries as packed.

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
No alignment is guaranteed and in fact on my ia64 sapic is aligned to 4 bytes instead of 8 and causes a trap. It affects only rarely used lsacpi command and so went unnoticed. Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-acpi-Mark-MADT-entries-as-packed.pat

[PATCH v2] MULTIBOOT: Fix handling of errors in broken aout-kludge

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
Current code in some codepaths neither discards nor reports errors. Properly surface the error While on it split 2 cases of unrelated variables both named err. Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-MULTIBOOT-Fix-handling-of-errors-in-broken-aout-klu

[PATCH] STACK_PROTECTOR: Support symbols emitted by windows compiler

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
stack protector needs symbols with just one underscore in C name unlike unix variant that needs double underscore. Supply both symbols for simplicity Signed-off-by: Vladimir Serbinenko -- Regards Vladimir 'phcoder' Serbinenko 0001-STACK_PROTECTOR-Support-symbols-emitted-by-windows-c.patch Des

Re: [PATCH 2/6] ieee1275/powerpc: enables device mapper discovery

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
On Mon, May 8, 2023 at 5:01 PM Avnish Chouhan wrote: > > From: Diego Domingos > > This patch enables the device mapper discovery on ofpath.c. Currently, > when we are dealing with a device like /dev/dm-* the ofpath returns null > since there is no function implemented to handle this case. Why is

Re: [PATCH 2/6] ieee1275/powerpc: enables device mapper discovery

2024-03-15 Thread Stefan Berger
On 3/15/24 00:06, Michael Chang via Grub-devel wrote: On Mon, May 08, 2023 at 01:58:36PM +, Avnish Chouhan wrote: From: Diego Domingos This patch enables the device mapper discovery on ofpath.c. Currently, when we are dealing with a device like /dev/dm-* the ofpath returns null since the

Re: [PATCH] disk: Prioritize OS disk devices over memdisk and procfs

2024-03-15 Thread Daniel Kiper
On Fri, Mar 15, 2024 at 05:00:28PM +0800, Michael Chang via Grub-devel wrote: > Refine iteration to prioritize returning system disk devices over > memdisk and procfs. This adjustment brings about a modest improvement in > search efficiency, particularly during file or UUID-based > searches for a r

[PATCH] disk: Prioritize OS disk devices over memdisk and procfs

2024-03-15 Thread Michael Chang via Grub-devel
Refine iteration to prioritize returning system disk devices over memdisk and procfs. This adjustment brings about a modest improvement in search efficiency, particularly during file or UUID-based searches for a root file system. Additionally, it helps mitigate potential collisions in file-based se

Re: [PATCH 3/7] multiboot2: Add support for the load type header tag

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
Not a full review. Just one blocking problem > > } > + case MULTIBOOT_LOAD_TYPE_PE: > + grub_fatal ("Unsupported load type: %u\n", mld.load_type); > + default: > +/* should be impossible */ > +grub_fatal ("Unknown load type: %u\n", mld.load_type); > Don't use grub_fatal for th

Re: [PATCH 7/7] verifiers: Verify after decompression

2024-03-15 Thread Vladimir 'phcoder' Serbinenko
Verifying after decompression is a bad security practice. It relies on decompression having no security holes. Given how complex decompression is, this is almost guaranteed to be false. Le mer. 13 mars 2024, 18:08, Ross Lagerwall via Grub-devel < grub-devel@gnu.org> a écrit : > It is convenient a