Re: [PATCH v8 08/22] protectors: Add key protectors framework

2024-01-17 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 05:58:25AM +0300, Vladimir 'phcoder' Serbinenko wrote: > Any strong reason to have it in kernel? It doesn't seem to be > necessary in non-crypto cases. Separate module or cryptodisk looks > like better places > I have no strong opinion about the location as long as it works

Re: [PATCH v8 04/22] libtasn1: changes for grub compatibility

2024-01-17 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 05:51:58AM +0300, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jan 16, 2024 at 12:23 PM Gary Lin via Grub-devel > wrote: > > > > From: Daniel Axtens > > > > Do a few things to make libtasn1 compile as part of grub: > > > > - redefine _asn1_strcat. grub removed strcat so

Re: [PATCH] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

2024-01-17 Thread Pascal Hambourg
On 17/01/2024 at 17:48, Vladimir 'phcoder' Serbinenko wrote: Le mer. 17 janv. 2024, 18:10, Pascal Hambourg a écrit : On 17/01/2024 at 04:15, Vladimir 'phcoder' Serbinenko wrote: +if [ "\$grub_platform" != "efi" ]; then This is not the right check. Only "pc" platform supports chainloadin boot

Re: [PATCH] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

2024-01-17 Thread Vladimir 'phcoder' Serbinenko
Le mer. 17 janv. 2024, 18:10, Pascal Hambourg a écrit : > On 17/01/2024 at 04:15, Vladimir 'phcoder' Serbinenko wrote: > >>onstr="$(gettext_printf "(on %s)" "${DEVICE}")" > >> cat << EOF > >> +if [ "\$grub_platform" != "efi" ]; then > > > > This is not the right check. Only "

Re: [PATCH] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

2024-01-17 Thread Pascal Hambourg
On 17/01/2024 at 04:15, Vladimir 'phcoder' Serbinenko wrote: onstr="$(gettext_printf "(on %s)" "${DEVICE}")" cat << EOF +if [ "\$grub_platform" != "efi" ]; then This is not the right check. Only "pc" platform supports chainloadin boot sector. All other: coreboot, qemu, emu,

Re: [PATCH] util/grub.d/30_os-prober.in: Skip drivemap for Windows 8 to 19, Server 2012 and later

2024-01-17 Thread Pascal Hambourg
On 17/01/2024 à 04:17, Vladimir 'phcoder' Serbinenko wrote: On Sat, Jan 6, 2024 at 6:38 PM Pascal Hambourg wrote: If Windows Vista, Seven and Server 2008 do not need drivemap, then later versions using bootmgr too should not need it either. (...) case ${LONGNAME} in - Windows\

Re: [PATCH v8 03/22] libtasn1: disable code not needed in grub

2024-01-17 Thread Gary Lin via Grub-devel
On Wed, Jan 17, 2024 at 05:28:20AM +0300, Vladimir 'phcoder' Serbinenko wrote: > I would suggest something a bit more descriptive than if 0. What about > #ifdef GRUB_SKIPPED_IMPORTING ? > That makes sense and improves the readability. Will update it for v9. Thanks, Gary Lin > Le mar. 16 janv. 2

Re: [PATCH v8 16/22] tpm2: Support authorized policy

2024-01-17 Thread Gary Lin via Grub-devel
On Tue, Jan 16, 2024 at 10:39:45AM -0500, James Bottomley wrote: > On Tue, 2024-01-16 at 17:20 +0800, Gary Lin via Grub-devel wrote: > [...] > > (*1) https://www.hansenpartnership.com/draft-bottomley-tpm2-keys.html > > (*2) https://github.com/okirch/pcr-oracle > > Just a curiosity question, but ha