Re: [PATCH 0/2] Bli: fix hidden module dependency

2023-11-14 Thread Vladimir 'phcoder' Serbinenko
In general series looks good. Few comments: * I'm unsure about the name. It seems to suggest that people put the dependencies there by default while in fact it's the last place for it. Maybe extra_deps.lst? * EFI supports both GPT and msdos. GPT is a more common choice but I still think that a depe

[PATCH 1/2] Allow explicit module dependencies

2023-11-14 Thread Oliver Steffen
The build system deduces inter-module dependencies from the symbols required and exported by the modules. This works well, except for some rare cases where the dependency is indirect or hidden. A module might not make use of any function of some other module, but still expect its functionality to b

[PATCH 0/2] Bli: fix hidden module dependency

2023-11-14 Thread Oliver Steffen
The bli module has a hidden/implicit dependency on the part_gpt module. The part_gpt module has to be loaded before the bli module. This dependency is not picked up automatically by the build system because the bli module does not use any function of part_gpt. It just expects Grub to be able to par

[PATCH 2/2] bli: Add explicit dependency on the part_gpt module

2023-11-14 Thread Oliver Steffen
The bli module has a "hidden" dependency on the part_gpt module, which is not picked up automatically by the build system. Without the part_gpt module, bli does not function correctly. Since bli does its work in the module initialization function, the order in which the modules are loaded is also i