Re: [PATCH v9 02/11] Unify GUID types

2023-09-12 Thread Pedro Miguel Justo
I can confirm that, taking [1][2] and making [3] on top of it, my Montvale-based rx2660 machine still boots fine. [1] - https://github.com/phcoder/GRUB.git [2] - cfa21b94e [3] : diff --git a/include/grub/gpt_partition.h b/include/grub/gpt_partition.h index 3c70b148d..bddf832fa 100644 --- a/incl

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread Vladimir 'phcoder' Serbinenko
Le lun. 11 sept. 2023, 13:16, darkpenguin a écrit : > Hmmm, this is actually a good idea. Grub does determine the boot device > by analyzing fstab, doesn't it? No it doesn't Why does it then use either UUIDs or > device paths, based on a configuration in a separate file, instead of > simply re

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread darkpenguin
On 12/09/23 17:02, Nicholas Vinson wrote: > On 9/12/23 03:42, darkpenguin wrote: > >> On 12/09/23 06:54, Oskari Pirhonen wrote: >>> On Mon, Sep 11, 2023 at 06:48:58 +, darkpenguin wrote: >> The decision to reuse GRUB_DISABLE_LINUX_UUID was because: >> 1) This is more of an addition o

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread darkpenguin
On 12/09/23 16:10, Nicholas Vinson wrote: > On 9/11/23 07:15, darkpenguin wrote: >> Hmmm, this is actually a good idea. Grub does determine the boot device >> by analyzing fstab, doesn't it? Why does it then use either UUIDs or >> device paths, based on a configuration in a separate file, instead o

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread Nicholas Vinson
On 9/12/23 03:42, darkpenguin wrote: On 12/09/23 06:54, Oskari Pirhonen wrote: On Mon, Sep 11, 2023 at 06:48:58 +, darkpenguin wrote: The decision to reuse GRUB_DISABLE_LINUX_UUID was because: 1) This is more of an addition on top of UUID rather than "disabling" it, it still uses UUID inte

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread Nicholas Vinson
On 9/11/23 07:15, darkpenguin wrote: Hmmm, this is actually a good idea. Grub does determine the boot device by analyzing fstab, doesn't it? Why does it then use either UUIDs or device paths, based on a configuration in a separate file, instead of simply reusing exactly what it has found specifi

Re: [PATCH] Add support for specifying the boot device by label

2023-09-12 Thread darkpenguin
On 12/09/23 06:54, Oskari Pirhonen wrote: > On Mon, Sep 11, 2023 at 06:48:58 +, darkpenguin wrote: The decision to reuse GRUB_DISABLE_LINUX_UUID was because: 1) This is more of an addition on top of UUID rather than "disabling" it, it still uses UUID internally, and it falls back