>
>
> {
> - ret = (cargs->search_uuid != NULL && grub_strcasecmp
> (cargs->search_uuid, dev->uuid) == 0);
> + ret = cargs->search_uuid && !grub_uuidcasecmp(cargs->search_uuid,
> dev->uuid, sizeof(dev->uuid));
>
Please keep comparison with == 0 explicit. Also comparison with NULL
imp
On Thu, Aug 17, 2023 at 4:21 PM Glenn Washburn
wrote:
> What version of automake are you using? I'm on 1.16.3-2 from Debian 11.
> rs_decoder.h is ending up in BUILT_SOURCES, so it should get built
> before anything is compiled. Can you check BUILT_SOURCES? For me
> rs_decoder.h is included via a f
On Thu, 17 Aug 2023 10:52:58 +0200
Olaf Hering wrote:
> Prior commit 3cf2e848bc03 ("disk/cryptodisk: Allows UUIDs to be compared
> in a dash-insensitive manner") the grub.cfg below worked as expected:
> create a menu, which if selected tries to open the specified partition
> and does further proc
On Thu, 17 Aug 2023 11:00:44 +0200
Olaf Hering wrote:
> Wed, 16 Aug 2023 14:33:43 -0500 Glenn Washburn :
>
> > There's an extra 'd' in read in the subject line.
>
> Perhaps there is a better phrase to describe the act of adding something back?
Ah, it needs a dash, "re-add". I misinterpreted yo
On Wed, 16 Aug 2023 21:43:25 -0400
Mike Gilbert wrote:
> On Wed, Aug 16, 2023 at 3:33 PM Glenn Washburn
> wrote:
> >
> > Hi Olaf,
> >
> > There's an extra 'd' in read in the subject line.
> >
> > On Wed, 16 Aug 2023 11:55:01 +0200
> > Olaf Hering wrote:
> >
> > > startup_raw.S includes a genera
On Mon, Aug 14, 2023 at 02:59:00PM -0500, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, Aug 14, 2023 at 03:00:10PM -0500, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, Aug 14, 2023 at 10:33:50PM -0500, Glenn Washburn wrote:
> Pretty self explanatory. The first patch allows explicitly telling grub-shell
> which terminal output device to use so we can test that the right bytes are
> getting written there. The second patch, which is the serial test, runs
> g
Adding Glenn and Patrick...
Olaf, please always CC at least original author of the patch...
Thanks for the report!
On Thu, Aug 17, 2023 at 10:52:58AM +0200, Olaf Hering wrote:
> Prior commit 3cf2e848bc03 ("disk/cryptodisk: Allows UUIDs to be compared
> in a dash-insensitive manner") the grub.cfg
Hey,
On Thu, Aug 17, 2023 at 11:09:50AM +0800, Gary Lin wrote:
> GIT repo for v5: https://github.com/lcp/grub2/tree/tpm2-unlock-v5
>
> This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by
> Hernan Gatta to introduce the key protector framework and TPM2 stack
> to GRUB2, and this
Wed, 16 Aug 2023 12:53:48 -0500 Glenn Washburn :
> I specifically wanted these two sections to be subsections of
> x86_64-efi and not at the same level as i386-pc, hence why I have them
> as subsections. I suspect that the issue could be fixed by adding a
> @menu in the x86_64-efi section with the
Wed, 16 Aug 2023 14:33:43 -0500 Glenn Washburn :
> There's an extra 'd' in read in the subject line.
Perhaps there is a better phrase to describe the act of adding something back?
> I don't see this error when building any of the targets that I test.
It is the result of my attempt to build just
Prior commit 3cf2e848bc03 ("disk/cryptodisk: Allows UUIDs to be compared
in a dash-insensitive manner") the grub.cfg below worked as expected:
create a menu, which if selected tries to open the specified partition
and does further processing. In case the passphrase was wrong, it would
just return a
13 matches
Mail list logo
