Re: [PATCH 00/14] Automatic Disk Unlock with TPM2

On Tue, Feb 28, 2023 at 06:39:22PM +0100, Daniel Kiper wrote: > On Wed, Feb 22, 2023 at 03:00:40PM +0800, Gary Lin via Grub-devel wrote: > > The patch series "Automatic TPM Disk Unlock" posted by Hernan Gatta > > introduces the key protector framework and TPM2 stack to GRUB2, and it's > > a useful

Re: [PATCH v4 0/6] Dynamic allocation of memory regions and IBM vTPM 2.0

Stefan Berger writes: > Hello, > > This is an addition to the series sent from Daniel Axtens > (https://lists.gnu.org/archive/html/grub-devel/2022-04/msg00064.html). > > Patch 'ieee1275: request memory with ibm,client-architecture-support' > implements vectors 1-4 of client-architecture-support

Re: [PATCH 00/14] Automatic Disk Unlock with TPM2

On Wed, Feb 22, 2023 at 03:00:40PM +0800, Gary Lin via Grub-devel wrote: > The patch series "Automatic TPM Disk Unlock" posted by Hernan Gatta > introduces the key protector framework and TPM2 stack to GRUB2, and it's > a useful feature for the systems to implement full disk encryption. > However,

Re: [PATCH 2/2] docs: Document that the functional test requires the package xfonts-unifont

On Sun, Feb 26, 2023 at 12:56:22AM -0600, Glenn Washburn wrote: > On Fri, 24 Feb 2023 16:54:28 +0100 > Daniel Kiper wrote: > > > On Thu, Feb 16, 2023 at 01:15:01AM -0600, Glenn Washburn wrote: > > > Signed-off-by: Glenn Washburn > > > --- > > > INSTALL | 1 + > > > 1 file changed, 1 insertion(+)

Re: [PATCH v2 6/7] commands/probe: use grub_gpt_part_guid_snprint

On Mon, Feb 20, 2023 at 07:56:29PM +0100, Oliver Steffen wrote: > Use the new function for printing the partition guid. > > Signed-off-by: Oliver Steffen This and next patch LGTM... > --- > grub-core/commands/probe.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff -

Re: [PATCH v2 5/7] partmap/gpt: add print function for guids

On Mon, Feb 20, 2023 at 07:56:28PM +0100, Oliver Steffen wrote: > Code to print gpt patition guids has been duplicated in multiple places. > Add a common function for that. > > Signed-off-by: Oliver Steffen > --- > grub-core/partmap/gpt.c | 13 + > include/grub/gpt_partition.h |

Re: [PATCH v2 3/7] Add a module for the Boot Loader Interface

On Mon, Feb 20, 2023 at 07:56:26PM +0100, Oliver Steffen wrote: > Add a new module named boot_loader_interface, which provides a command > with the same name. It implements a small but quite useful part of the > Boot Loader Interface [0]. This interface uses EFI variables for > communication betwe

Re: [PATCH v2 2/7] efi: check for integer overflow in string conversion

On Mon, Feb 20, 2023 at 07:56:25PM +0100, Oliver Steffen wrote: > Check for integer overflow when converting the name of the > EFI variable to UTF16 in grub_efi_set_variable_with_attributes(). > > Signed-off-by: Oliver Steffen Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v2 1/7] efi: add grub_efi_set_variable_with_attributes

On Mon, Feb 20, 2023 at 07:56:24PM +0100, Oliver Steffen wrote: > Add a function to the EFI module that allows setting EFI variables > with specific attributes. > > This is useful for marking variables as volatile, for example. > > Signed-off-by: Oliver Steffen Reviewed-by: Daniel Kiper Daniel

Re: [PATCH] risc-v: Handle R_RISCV_CALL_PLT reloc

On Thu, Feb 23, 2023 at 01:15:08PM -0800, Khem Raj wrote: > GNU assembler starting 2.40 release always generates R_RISCV_CALL_PLT > reloc for call in assembler [1], similarly llvm does not make > distinction between R_RISCV_CALL_PLT and R_RISCV_CALL [2] > > Fixes > grub-mkimage: error: relocation 0

Re: [PATCH v1 2/2] Add a module for the Boot Loader Interface

On Tue, Feb 21, 2023 at 4:39 PM Daniel Kiper wrote: > On Mon, Feb 20, 2023 at 08:15:35AM -0800, Oliver Steffen wrote: > > Thank you for the comments, Daniel. > > > > Quoting Daniel Kiper (2023-02-15 19:27:03) > > > On Mon, Jan 16, 2023 at 12:40:53PM +0100, Oliver Steffen wrote: > > > > Add a new