Re: [PATCH 04/14] cryptodisk: Support key protectors

2023-02-22 Thread Gary Lin via Grub-devel
On Wed, Feb 22, 2023 at 03:00:44PM +0800, Gary Lin via Grub-devel wrote: > From: Hernan Gatta > > Add a new parameter to cryptomount to support the key protectors framework: > -k. > The parameter is used to automatically retrieve a key from specified key > protectors. The parameter may be repeat

Re: [PATCH 03/14] protectors: Add TPM2 Key Protector

2023-02-22 Thread Gary Lin via Grub-devel
On Wed, Feb 22, 2023 at 07:41:38AM -0500, James Bottomley wrote: > On Wed, 2023-02-22 at 15:00 +0800, Gary Lin via Grub-devel wrote: > > +GRUB_MOD_INIT (tpm2) > > +{ > > +  grub_tpm2_protector_init_cmd = > > +    grub_register_extcmd ("tpm2_key_protector_init", > > + grub_tp

Re: [PATCH 03/14] protectors: Add TPM2 Key Protector

2023-02-22 Thread James Bottomley
On Wed, 2023-02-22 at 15:00 +0800, Gary Lin via Grub-devel wrote: > +GRUB_MOD_INIT (tpm2) > +{ > +  grub_tpm2_protector_init_cmd = > +    grub_register_extcmd ("tpm2_key_protector_init", > + grub_tpm2_protector_init_cmd_handler, 0, > + N_("[-m mode] "

Compile and testsuite runs for various Debian targets

2023-02-22 Thread John Paul Adrian Glaubitz
Hi Glenn! I have test-built GRUB from git at f7564844f on all Debian targets which support GRUB. Builds worked fine on all targets except for hurd-i386 for which I will send a separate mail. For the Linux-based targets, I have uploaded the testsuite results to [1]. Adrian > [1] https://people.d

Re: [PATCH v2] osdep/hurd/getroot: Remove unused variables in grub_util_find_hurd_root_device()

2023-02-22 Thread Samuel Thibault
John Paul Adrian Glaubitz, le mer. 22 févr. 2023 09:43:02 +0100, a ecrit: > Found during a test build on Debian/hurd-i386 with --disable-werror enabled: > > In file included from grub-core/osdep/getroot.c:12: > grub-core/osdep/hurd/getroot.c: In function ‘grub_util_find_hurd_root_device’: > grub-c

[PATCH v2] osdep/hurd/getroot: Remove unused variables in grub_util_find_hurd_root_device()

2023-02-22 Thread John Paul Adrian Glaubitz
Found during a test build on Debian/hurd-i386 with --disable-werror enabled: In file included from grub-core/osdep/getroot.c:12: grub-core/osdep/hurd/getroot.c: In function ‘grub_util_find_hurd_root_device’: grub-core/osdep/hurd/getroot.c:126:13: error: unused variable ‘next’ [-Werror=unused-vari

[PATCH] osdep/hurd/getroot: Remove unused variables in grub_util_find_hurd_root_device()

2023-02-22 Thread John Paul Adrian Glaubitz
Found during a test build on Debian/hurd-i386 with --disable-werror enabled: In file included from grub-core/osdep/getroot.c:12: grub-core/osdep/hurd/getroot.c: In function ‘grub_util_find_hurd_root_device’: grub-core/osdep/hurd/getroot.c:126:13: error: unused variable ‘next’ [-Werror=unused-vari