Re: [PATCH] loader: Ensure the newc pathname is NULL-terminated

2022-11-23 Thread Gary Lin via Grub-devel
On Wed, Nov 23, 2022 at 03:44:54PM +0100, Daniel Kiper wrote: > On Wed, Nov 23, 2022 at 02:40:21PM +0800, Gary Lin via Grub-devel wrote: > > Per "man 5 cpio", the namesize in the cpio header includes the trailing > > NULL byte of the pathname and the pathname is followed by NULL bytes, but > > s/N

Re: [PATCH 1/1] fs/udf: validate length of AED in grub_udf_read_block()

2022-11-23 Thread Daniel Kiper
On Wed, Nov 23, 2022 at 04:20:02PM +0100, Jag Raman wrote: > > On Nov 23, 2022, at 9:52 AM, Daniel Kiper wrote: > > On Thu, Nov 17, 2022 at 12:17:52AM +, Jagannathan Raman wrote: > >> Validate the length of Allocation Extent Descriptor in > >> grub_udf_read_block(), based on the details in UDF

Re: [PATCH 2/2] bash-completion:fix shellcheck warning

2022-11-23 Thread Daniel Kiper
On Mon, Sep 19, 2022 at 09:20:14AM +0800, t.feng via Grub-devel wrote: > SC2207 (warning): Prefer mapfile or read -a to split > command output (or quote to avoid splitting). > SC2120 (warning): __grub_get_options_from_help references arguments, > but none are ever passed. > SC2155 (warning): Declar

Re: [PATCH 1/2] bash-completion:fix shellcheck error

2022-11-23 Thread Daniel Kiper
On Mon, Sep 19, 2022 at 09:20:13AM +0800, t.feng via Grub-devel wrote: > SC2070 (error): -n doesn't work with unquoted arguments. > Quote or use [[ ]]. > In grub-completion.bash.in line 130: > [ -n $tmp ] && { > ^--^ SC2070 (error) > > ref:https://github.com/koalaman/

Re: [PATCH 0/9] fix memory leaks in fs module

2022-11-23 Thread Daniel Kiper
On Sat, Nov 19, 2022 at 06:39:37PM +0800, t.feng via Grub-devel wrote: > Hi all, > I am doing code review in grub-core/fs module and I found some > memory leaks. > > * > > t.feng (9): > fs/affs:Fix memory leaks in grub_affs_create_node > fs/btrfs: Fix memory leak in find

Re: [PATCH 1/1] fs/udf: validate length of AED in grub_udf_read_block()

2022-11-23 Thread Jag Raman
> On Nov 23, 2022, at 9:52 AM, Daniel Kiper wrote: > > On Thu, Nov 17, 2022 at 12:17:52AM +, Jagannathan Raman wrote: >> Validate the length of Allocation Extent Descriptor in >> grub_udf_read_block(), based on the details in UDF spec. v2.01 section >> 2.3.11 >> >> Fixes: CID 314037 >> >>

Re: [PATCH 4/9] fs/ntfs: Fix memory leak in grub_ntfs_read_symlink

2022-11-23 Thread Daniel Kiper
On Sat, Nov 19, 2022 at 06:39:41PM +0800, t.feng via Grub-devel wrote: > Fix memory leaks in grub_ntfs_read_symlink. > > Fixes: 5773fb641(Support NTFS reparse points.) > > Signed-off-by: "t.feng" > --- > grub-core/fs/ntfs.c | 26 ++ > 1 file changed, 22 insertions(+), 4 de

Re: [PATCH 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink

2022-11-23 Thread Daniel Kiper
On Sat, Nov 19, 2022 at 06:39:40PM +0800, t.feng via Grub-devel wrote: > Fix memory leaks in grub_minix_lookup_symlink. > > Fixes: a07e6ad01(Remove variable length arrays) > > Signed-off-by: "t.feng" > --- > grub-core/fs/minix.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-)

Re: [PATCH 1/1] fs/udf: validate length of AED in grub_udf_read_block()

2022-11-23 Thread Daniel Kiper
On Thu, Nov 17, 2022 at 12:17:52AM +, Jagannathan Raman wrote: > Validate the length of Allocation Extent Descriptor in > grub_udf_read_block(), based on the details in UDF spec. v2.01 section > 2.3.11 > > Fixes: CID 314037 > > Signed-off-by: Jagannathan Raman Reviewed-by: Daniel Kiper Dani

Re: [PATCH] docs: Consistently spell *boot loader* with space in paragraph

2022-11-23 Thread Daniel Kiper
On Sun, Nov 20, 2022 at 11:20:01AM +0100, Paul Menzel wrote: > Signed-off-by: Paul Menzel > --- > docs/grub.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/grub.texi b/docs/grub.texi > index 50c811a88..1c94cf192 100644 > --- a/docs/grub.texi > +++ b/docs/grub.te

Re: [PATCH] loader: Ensure the newc pathname is NULL-terminated

2022-11-23 Thread Daniel Kiper
On Wed, Nov 23, 2022 at 02:40:21PM +0800, Gary Lin via Grub-devel wrote: > Per "man 5 cpio", the namesize in the cpio header includes the trailing > NULL byte of the pathname and the pathname is followed by NULL bytes, but s/NULL/NUL/ and below please... > the current implementation excludes the

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-23 Thread Xiaotian Wu
Is there a new patch? 在 2022-11-08星期二的 23:59 -0800，Atish Kumar Patra写道： > > > On Tue, Nov 8, 2022 at 7:56 AM Daniel Kiper > wrote: > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > > Update the RISC-V Linux kernel image headers as per the current > > > header. > > > > > > Re