Re: [PATCH] tpm: Disable tpm verifier if tpm is not present

2022-10-06 Thread Michael Chang via Grub-devel
On Thu, Oct 06, 2022 at 03:40:36PM -0400, Stefan Berger wrote: > > > On 9/8/22 00:23, Michael Chang via Grub-devel wrote: > > This helps to prevent out of memory error when reading large files via > > disablig > > tpm device as verifier has to read all content into memory in one chunk to > > mea

[PATCH v2] tpm: Disable tpm verifier if tpm is not present

2022-10-06 Thread Michael Chang via Grub-devel
This helps to prevent out of memory error when reading large files via disabling tpm device as verifier has to read all content into memory in one chunk to measure the hash and extend to tpm. Signed-off-by: Michael Chang Reviewed-by: Stefan Berger --- grub-core/commands/efi/tpm.c | 37 +

Re: [PATCH v3] templates: introduce GRUB_TOP_LEVEL_* vars

2022-10-06 Thread Oskari Pirhonen
On Wed, Oct 05, 2022 at 02:22:38 -0700, Denton Liu wrote: > A user may wish to use an image that is not sorted as the "latest" > version as the top-level entry. For example, in Arch Linux, if a user > has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts` > gets sorted as the "latest"

[PATCH] menu: Add ctrl-L to refresh the menu

2022-10-06 Thread Benjamin Herrenschmidt
This is useful on cloud instances with remote serial ports as it can be difficult to connect "fast enough" to get the initial menu display Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Daniel Kiper --- docs/grub.texi | 3 +++ grub-core/normal/menu.c | 4 2 files changed, 7 in

Re: [PATCH] tpm: Disable tpm verifier if tpm is not present

2022-10-06 Thread Stefan Berger
On 9/8/22 00:23, Michael Chang via Grub-devel wrote: This helps to prevent out of memory error when reading large files via disablig tpm device as verifier has to read all content into memory in one chunk to measure the hash and extend to tpm. Signed-off-by: Michael Chang --- grub-core/comm

Re: [PATCH] grub-install: set point of no return for powerpc-ieee1275 install

2022-10-06 Thread Daniel Kiper
On Thu, Aug 25, 2022 at 02:05:01PM +0800, Michael Chang via Grub-devel wrote: > The point of no return is used to define a point where no change should > be reverted in a wake of fatal error that consequently aborts the > process. The powerpc-ieee1275 install apparently missed this point of no > re

Re: [PATCH 1/2] diskfilter: check calloc() result for NULL

2022-10-06 Thread Daniel Kiper
On Sun, Aug 21, 2022 at 10:22:35PM +1000, Daniel Axtens wrote: > With wildly corrupt inputs, we can end up trying to calloc a very > large amount of memory, which will fail and give us a NULL pointer. > We need to check that to avoid a crash. (And, even if we blocked > such inputs, it is good pract

Re: [PATCH v3] grub-core/kern/corecmd: Quote variable values when displayed by the set command

2022-10-06 Thread Daniel Kiper
On Thu, Aug 25, 2022 at 07:53:51PM -0500, Glenn Washburn wrote: > Variable values may contain spaces at the end or newlines. However, when > displayed without quotes this is not obvious and can lead to confusion as > to the actual contents of variables. Also for some variables grub_env_get() > retu

Re: [PATCH v5 1/1] grub-module-verifierxx.c: enable running standalone checkers

2022-10-06 Thread Daniel Kiper
On Wed, Oct 05, 2022 at 09:48:37AM -0400, Robbie Harwood wrote: > From: Peter Jones > > Allow treating grub-module-verifierxx.c as a file you can build directly > so syntax checkers like vim's "syntastic" plugin, which uses "gcc -x c > -fsyntax-only" to build it, will work. > > One still has to do

Re: [PATCH 2/2] diskfilter: don't make a RAID array with more than 1024 disks

2022-10-06 Thread Daniel Kiper
On Tue, Aug 23, 2022 at 01:55:26AM +1000, Daniel Axtens wrote: > Daniel Axtens writes: > > > This is 'belt and braces' with the last fix: we end up trying to use > > too much memory in situations like corrupted Linux software raid setups > > purporting to usew a huge number of disks. Simply refuse

Re: [PATCH v6 2/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-10-06 Thread Daniel Kiper
On Tue, Sep 06, 2022 at 05:28:40PM +0200, Patrick Steinhardt wrote: > On Tue, Aug 30, 2022 at 03:12:36PM -0500, Glenn Washburn wrote: > > On Mon, 29 Aug 2022 07:38:24 +0200 > > Patrick Steinhardt wrote: > > > > > On Fri, Aug 19, 2022 at 06:06:15PM -0500, Glenn Washburn wrote: > > > > A user can no

Re: [PATCH] templates: Add support for acpi on Hurd

2022-10-06 Thread Daniel Kiper
On Mon, Sep 26, 2022 at 09:51:32PM +0200, Samuel Thibault wrote: > This adds acpi as bootstrap module whenever it is available. This opens the > path for proper IRQ routing for fully-userland disk drivers. > > Signed-off-by: Samuel Thibault Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v2 1/1] mm: Better handling of adding new regions

2022-10-06 Thread Daniel Kiper
On Sun, Sep 25, 2022 at 03:59:50PM +0200, Patrick Steinhardt wrote: > On Tue, Sep 13, 2022 at 01:49:52AM +0800, Zhang Boyang wrote: > > The code of dynamically adding new regions has two problems. First, it > > always invalidate disk caches, which decreases performance severely. > > Second, it requ