Re: [PATCH v2 0/1] Fix slow loading problem introduced by 887f98f0d

2022-09-12 Thread Gary Lin via Grub-devel
On Tue, Sep 13, 2022 at 11:16:19AM +0800, Gary Lin via Grub-devel wrote: > On Tue, Sep 13, 2022 at 01:49:51AM +0800, Zhang Boyang wrote: > > Hi, > > > > This patch should probably fix the slow loading problem introduced by > > 887f98f0db43 (mm: Allow dynamically requesting additional memory > > re

Re: [PATCH v2 0/1] Fix slow loading problem introduced by 887f98f0d

2022-09-12 Thread Gary Lin via Grub-devel
On Tue, Sep 13, 2022 at 01:49:51AM +0800, Zhang Boyang wrote: > Hi, > > This patch should probably fix the slow loading problem introduced by > 887f98f0db43 (mm: Allow dynamically requesting additional memory > regions). > > Although I'm not against increasing default heap size, simply increasing

[PATCH v2 1/1] mm: Better handling of adding new regions

2022-09-12 Thread Zhang Boyang
The code of dynamically adding new regions has two problems. First, it always invalidate disk caches, which decreases performance severely. Second, it request exactly "size" bytes for new region, ignoring region management overheads. This patch makes adding new regions more priority than disk cach

[PATCH v2 0/1] Fix slow loading problem introduced by 887f98f0d

2022-09-12 Thread Zhang Boyang
Hi, This patch should probably fix the slow loading problem introduced by 887f98f0db43 (mm: Allow dynamically requesting additional memory regions). Although I'm not against increasing default heap size, simply increasing heap size may not fully fix the problem. I think the root cause is disk cac

Re: [PATCH 1/1] mm: Better handling of adding new regions

2022-09-12 Thread Zhang Boyang
Hi, On 2022/9/12 23:03, Heinrich Schuchardt wrote: On 9/12/22 16:19, Zhang Boyang wrote: The code of dynamically adding new regions has two problems. First, it always invalidate disk caches, which decreases performance severely. Second, it request exactly "size" bytes for new region, ignoring r

Re: [PATCH 1/1] mm: Better handling of adding new regions

2022-09-12 Thread Heinrich Schuchardt
On 9/12/22 16:19, Zhang Boyang wrote: The code of dynamically adding new regions has two problems. First, it always invalidate disk caches, which decreases performance severely. Second, it request exactly "size" bytes for new region, ignoring region overheads. This patch makes adding new regions

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread Zhang Boyang
On 2022/9/12 19:29, jim945 wrote: After swapping "case 0:" and "case 1:" works fine. Thanks for the information! I wrote a (better) patch based on the result. Best Regards, Zhang Boyang ___ Grub-devel mailing list Grub-devel@gnu.org https://list

[PATCH 0/1] Fix slow loading problem introduced by 887f98f0d

2022-09-12 Thread Zhang Boyang
Hi, This patch should probably fix the slow loading problem introduced by 887f98f0db43 (mm: Allow dynamically requesting additional memory regions). Although I'm not against increasing default heap size, simply increasing heap size may not fully fix the problem. I think the root cause is disk cac

[PATCH 1/1] mm: Better handling of adding new regions

2022-09-12 Thread Zhang Boyang
The code of dynamically adding new regions has two problems. First, it always invalidate disk caches, which decreases performance severely. Second, it request exactly "size" bytes for new region, ignoring region overheads. This patch makes adding new regions more priority than disk cache invalidat

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
10.09.2022 17:51, Zhang Boyang пишет: Hi On 2022/9/10 14:33, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile echo xzio squash4 sfs memdisk Th

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
12.09.2022 14:29, jim945 пишет: 10.09.2022 17:51, Zhang Boyang пишет: Hi On 2022/9/10 14:33, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
12.09.2022 05:15, Gary Lin пишет: On Sat, Sep 10, 2022 at 09:33:47AM +0300, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile echo xzio squash4 sfs

Re: [PATCH] efi: add feature_efifwsetup_check

2022-09-12 Thread Felipe Contreras
On Mon, Sep 12, 2022 at 5:27 AM Robbie Harwood wrote: > > Felipe Contreras writes: > > > In commit 26031d3b1 (efi: Don't display a uefi-firmware entry if it's > > not supported, 2022-08-18) an unconditional call to `fwsetup > > --is-supported` was added which causes the system to reboot if > > `g

Re: [PATCH] efi: add feature_efifwsetup_check

2022-09-12 Thread Robbie Harwood
Felipe Contreras writes: > In commit 26031d3b1 (efi: Don't display a uefi-firmware entry if it's > not supported, 2022-08-18) an unconditional call to `fwsetup > --is-supported` was added which causes the system to reboot if > `grub-install` hasn't been run because `fwsetup` doesn't have the new