Re: [PATCH 0/7] Add MMIO serial ports support and SPCR detection

2022-09-01 Thread Benjamin Herrenschmidt
On Fri, 2022-09-02 at 16:12 +1000, Benjamin Herrenschmidt wrote: > This series improves our legacy serial support to add the ability > to use MMIO based serial ports on x86 and to use ACPI's SPCR to > automatically configure the default port. > > An MMIO serial port can be specified explicitely us

[PATCH 5/7] ns8250: Use ACPI SPCR table when available to configure serial

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt "serial auto" is now equivalent to just "serial" and will use the SPCR to discover the port if present, otherwise defaults to "com0" as before. This allows to support MMIO ports specified by ACPI which is needed on AWS EC2 "metal" instances, and will enable grub to p

[PATCH 3/7] ns8250: Add base support for MMIO UARTs

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This adds the ability for the driver to access UARTs via MMIO instead of PIO selectively at runtime, and exposes a new function to add an MMIO port. Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250.c | 78 - gr

[PATCH 7/7] serial: Add ability to specify MMIO ports via 'serial'

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This adds the ability to explicitely add an MMIO based serial port via the 'serial' command. The syntax is: serial --port=mmio,{.b,.w,.l,.q} Signed-off-by: Benjamin Herrenschmidt --- docs/grub.texi | 26 -- grub-core/term/serial.c

[PATCH 2/7] acpi: Add SPCR and generic address definitions

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt --- include/grub/acpi.h | 51 + 1 file changed, 51 insertions(+) diff --git a/include/grub/acpi.h b/include/grub/acpi.h index 8c126b2b9..17aadb802 100644 --- a/include/grub/acpi.h +++

[PATCH 6/7] ns8250: Support more MMIO access sizes

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt It is common for PCI based UARTs to use larger than one byte access sizes. This adds support for this and uses the information present in SPCR accordingly. Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250-spcr.c | 3 ++- grub-core/term/ns8250.c

[PATCH 4/7] ns8250: Add configuration parameter when adding ports

2022-09-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This will allow ports to be added with a pre-set configuration Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250.c | 25 +++-- grub-core/term/serial.c | 2 +- include/grub/serial.h | 4 ++-- 3 files changed, 22 insertions(+), 9

[PATCH 1/7] acpi: Export a generic grub_acpi_find_table

2022-09-01 Thread Benjamin Herrenschmidt
From: Matthias Lange And convert grub_acpi_find_fadt to use it Signed-off-by: Benjamin Herrenschmidt --- grub-core/kern/acpi.c | 43 +-- include/grub/acpi.h | 3 +++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/grub-core/kern/acpi.

[PATCH 0/7] Add MMIO serial ports support and SPCR detection

2022-09-01 Thread Benjamin Herrenschmidt
This series improves our legacy serial support to add the ability to use MMIO based serial ports on x86 and to use ACPI's SPCR to automatically configure the default port. An MMIO serial port can be specified explicitely using the "mmio," prefix for the --port argument to the 'serial' command, the

Re: Slow(er) loading of Grub starting after commit 887f98f0d

2022-09-01 Thread Gary Lin via Grub-devel
On Thu, Sep 01, 2022 at 06:44:24PM +0200, Marcel Langner via Grub-devel wrote: > Hi, > just subscribed coming from arch forum > (https://bbs.archlinux.org/viewtopic.php?id=279006) to report slower loading > of grub after commit 887f98f0d. > The additional delay is around 20s and happens right after

Re: [PATCH 3/5] ns8250: Add base support for MMIO UARTs

2022-09-01 Thread Benjamin Herrenschmidt
On Wed, 2022-08-31 at 18:26 +1000, Benjamin Herrenschmidt wrote: >    grub_addr_t mmio_base; > +    /* Access size uses ACPI definition */ > +    unsigned int access_size; >    }; > }; >   This is buggy, access_size needs to be out of the union. I'll resend the whole series wi

Re: Slow(er) loading of Grub starting after commit 887f98f0d

2022-09-01 Thread Luna Jernberg
Have this problem too On 9/1/22, Marcel Langner via Grub-devel wrote: > Hi, > just subscribed coming from arch forum > (https://bbs.archlinux.org/viewtopic.php?id=279006) to report slower > loading of grub after commit 887f98f0d. > The additional delay is around 20s and happens right after I get

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-09-01 Thread Philip Müller via Grub-devel
On 31.08.22 20:44, Robbie Harwood wrote: While we could revert the entire --is-supported logic as well, since this is upstream pre-release code, it's probably easier for the downstreams that pulled this change if we don't, so: Reviewed-by: Robbie Harwood. Yep, that would also work. For example

Re: [PATCH v4 2/2] efi: new 'eficonnect' command

2022-09-01 Thread Robbie Harwood
Renaud Métrich writes: > When efi.quickboot is enabled on VMWare (which is the default for > hardware release 16 and later), it may happen that not all EFI devices > are connected. Due to this, browsing the devices in make_devices() just > fails to find devices, in particular disks or partitions

Slow(er) loading of Grub starting after commit 887f98f0d

2022-09-01 Thread Marcel Langner via Grub-devel
Hi, just subscribed coming from arch forum (https://bbs.archlinux.org/viewtopic.php?id=279006) to report slower loading of grub after commit 887f98f0d. The additional delay is around 20s and happens right after I get the message Slot 0 opened (as I have a luks encrypted partition) and after se

Re: [PATCH] Remove HFS support

2022-09-01 Thread Daniel Axtens
"Vladimir 'phcoder' Serbinenko" writes: > Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit : > >> Let me answer this out of order. >> >> > I understand the need to sometimes get rid of old code, but since the HFS >> > module can be blacklisted as Vladimir explains, I don't really understand >>

Re: efi: new 'connectefi' command

2022-09-01 Thread Renaud Métrich
Hi Glenn, Thanks for reviewing this. I reworked the feature based on your comments: - used grub_list - renamed into "eficonnect" - added "all" option See "[PATCH v4 1/2] lsefi: fixed memory leaks (unchanged)" and "[PATCH v4 2/2] efi: new 'eficonnect' command" Renaud. Le 8/28/22 à 21:51, G

[PATCH v4 2/2] efi: new 'eficonnect' command

2022-09-01 Thread Renaud Métrich
When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular disks or partitions for a given disk. This typically

[PATCH v4 1/2] lsefi: fixed memory leaks

2022-09-01 Thread Renaud Métrich
Signed-off-by: Renaud Métrich --- grub-core/commands/efi/lsefi.c | 4 1 file changed, 4 insertions(+) diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c index f46ba3b49..241be79f9 100644 --- a/grub-core/commands/efi/lsefi.c +++ b/grub-core/commands/efi/lsefi.c @@ -