Re: [PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-11 Thread Paul Menzel
Dear Glenn, Thank you for the patch. Am 12.05.22 um 05:07 schrieb Glenn Washburn: This command is meant to behave similarly to the 'mode' command of the EFI Shell application. One difference is that to set the mode the mode number is given, not the rows and columns of the desired mode. Also su

Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-11 Thread Paul Menzel
Dear Glenn, Thank you for the patch. Two small nits. Am 12.05.22 um 05:07 schrieb Glenn Washburn: Signed-off-by: Glenn Washburn *Add documentation for …* could be abbreviated to *Document …* in the git commit message summary. --- docs/grub.texi | 23 +++ 1 file ch

[PATCH 4/4] util/probe.c: Remove unused header includes

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- util/probe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/util/probe.c b/util/probe.c index 05a6d1462..81d91cf59 100644 --- a/util/probe.c +++ b/util/probe.c @@ -36,8 +36,6 @@ #include #include #include -#include -#include #include -- 2.34.

[PATCH 0/4] Miscellaneous fixes/improvements

2022-05-11 Thread Glenn Washburn
Patch #1: When the HFS UUID test fails it shows two GRUB generated outputs. There should be one GRUB output and one host system output, like the other filesystems output. In this case it should show the host generated HFS UUID which is not matching with the GRUB generated one. Patch #2: If te

[PATCH 3/4] formatting: Remove whitespace between N_ macro and open parenthesis

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/commands/macbless.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/grub-core/commands/macbless.c b/grub-core/commands/macbless.c index 85cefd0f7..3d761452a 100644 --- a/grub-core/commands/macbless.c +++ b/grub-core/commands/ma

[PATCH 2/4] tests: Add /sbin and /usr/sbin to path in partmap test

2022-05-11 Thread Glenn Washburn
The partmap test requires no elevated privileges. However, it uses parted which can be used as a normal user, but is usually located in /sbin or /usr/bin (eg. on Debian systems). Whereas the normal user does not usually have /sbin or /usr/sbin added to their path, thus parted will not be found caus

[PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails

2022-05-11 Thread Glenn Washburn
On failure, the hfs test should show both the host and GRUB determined fs UUID. Prior to this change, both outputs where generated by GRUB, which is less helpful in determining the cause of failure. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 2 +- 1 file changed, 1 insertio

[PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index 3b5522b0a..50ef28edd 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4202,6 +4202,7 @@ you forget a command, you can run the com

[PATCH 0/2] Add efitextmode command

2022-05-11 Thread Glenn Washburn
This patch add the efitextmode command which is used for showing all available text output modes and setting a specific mode. Its basically the equivalent of the EFI Shell's "mode" command and its output looks similar. The main difference is that its shows the mode number in the listing and takes a

[PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-11 Thread Glenn Washburn
This command is meant to behave similarly to the 'mode' command of the EFI Shell application. One difference is that to set the mode the mode number is given, not the rows and columns of the desired mode. Also supported are the arguments "min" and "max", which set the mode to the minimum and maximu

[PATCH] efi: Add missing header from efi/console_control.h

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- include/grub/efi/console_control.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/grub/efi/console_control.h b/include/grub/efi/console_control.h index 7c358fcdb..bb5fd038e 100644 --- a/include/grub/efi/console_control.h +++ b/include/grub/efi/con

[PATCH 7/7] docs: Add section for general undocumented commands

2022-05-11 Thread Glenn Washburn
The section is an itemized list of commands that are not listed else where in the command sections. Signed-off-by: Glenn Washburn --- docs/grub.texi | 101 + 1 file changed, 101 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index 9151

[PATCH 6/7] docs: Add under documented loader commands to beginning of loader section

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 36 1 file changed, 36 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index eea575e0c..91512e317 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -3922,6 +3922,42 @@ All options are the same as

[PATCH 2/7] docs: Make note that sendkey is only available on i386-pc

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 11c66160e..c5310fdec 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -5103,7 +5103,9 @@ Insert keystrokes into the keyboard buffer when

[PATCH 4/7] docs: Markup loader commands with @command tag

2022-05-11 Thread Glenn Washburn
Also, add period to terminate sentence. Signed-off-by: Glenn Washburn --- docs/grub.texi | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index e003be7ca..d96f08722 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -1005,13 +1005,14 @@

[PATCH 5/7] docs: Create command section for loader commands

2022-05-11 Thread Glenn Washburn
Move loader commands documented in the general commands list into the loader command section. Signed-off-by: Glenn Washburn --- docs/grub.texi | 220 ++--- 1 file changed, 116 insertions(+), 104 deletions(-) diff --git a/docs/grub.texi b/docs/grub.tex

[PATCH 3/7] docs: Make note of i386-pc specific usage of halt command

2022-05-11 Thread Glenn Washburn
The --no-apm option is only available on the i396-pc target. Signed-off-by: Glenn Washburn --- docs/grub.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index c5310fdec..e003be7ca 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@

[PATCH 1/7] docs: Fix spelling typo and remove unnecessary spaces

2022-05-11 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi index 617e155a0..47a8e3826 100644 --- a/docs/grub-dev.texi +++ b/docs/grub-dev.texi @@ -967,13 +967,13 @@ If it works next st

[PATCH 0/7] Various docs improvements

2022-05-11 Thread Glenn Washburn
The first 4 patches need no explanation. The 5th patch creates a new section just for loader commands and moves loader commands to that section from the general commands section. Patch #6 adds an itemized list of currently under-documented loader commands to the text part of the loader command sect

[PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()

2022-05-11 Thread Glenn Washburn
The commit 848724273e4 (net/net: Avoid unnecessary calls to grub_net_tcp_retransmit()) needs to have its condition inverted to avoid unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many unnecessary calls and does not call grub_net_tcp_retransmit() when needed. The call to grub_

Re: [PATCH] efi: Set text-mode console resolution to maximum supported

2022-05-11 Thread Glenn Washburn
On Tue, 10 May 2022 13:57:08 +0200 Gerd Hoffmann wrote: > On Fri, May 06, 2022 at 07:59:15PM -0500, Glenn Washburn wrote: > > Hi Gerd, > > > > Thanks for taking a look at the patch. > > > > On Fri, 6 May 2022 12:39:52 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > On some buggy

Re: [PATCH v2 0/1] plainmount: Support plain encryption mode.

2022-05-11 Thread Glenn Washburn
On Tue, 10 May 2022 19:16:06 + Maxim Fomin wrote: > --- Original Message --- > On Thursday, May 5th, 2022 at 6:09, Glenn Washburn > wrote: > > > Hi Maxim, > > > > I just want to reiterate Daniel, for v3, please use --threaded when > > using format-patch and send-email. It'll help r

a GRUB command to show the UEFI built-in boot manager

2022-05-11 Thread Chris Murphy
Hi, There's GRUB command "fwsetup" to bring the user from GRUB to the firmware's setup menu. Could there be a command that brings the user to the firmware's built-in boot manager? a.k.a. boot order, a.k.a. boot selection? I'm offhand not seeing a UEFI command to bring up this specific firmware me

multibooting Linux distros with UEFI Secure Boot

2022-05-11 Thread Chris Murphy
Hi, A given NVRAM entry points to a particular distro shim+GRUB, and it's not possible to use either chainloader or configfile to forward to another distro's GRUB. If GRUB wants to support the multiboot Linux case, it needs some way of discovering other distro's shim+GRUB comb in NVRAM and on the

multibooting Linux distros with UEFI Secure Boot

2022-05-11 Thread Chris Murphy
This seems related to thread: "How to boot Windows when Bitlocker enabled with key sealed in TPM External" https://lists.gnu.org/archive/html/grub-devel/2022-02/msg00072.html A given NVRAM entry points to a particular distro shim+GRUB, and it's not possible to use either chainloader or configfile

Re: Can't find a solution to a failed secure boot kernel loading

2022-05-11 Thread Dimitri John Ledkov
On Wed, 11 May 2022 at 11:14, Łukasz Piątkowski wrote: > > That was it, I created a new without that EKU and everything works! Thank you > very much, this was not easy to find, unfortunately :( Esp. when some > official pages like here > https://ubuntu.com/blog/how-to-sign-things-for-secure-boo

Re: Can't find a solution to a failed secure boot kernel loading

2022-05-11 Thread Łukasz Piątkowski
That was it, I created a new without that EKU and everything works! Thank you very much, this was not easy to find, unfortunately :( Esp. when some official pages like here https://ubuntu.com/blog/how-to-sign-things-for-secure-boot still list it as a needed EKU. On Tue, May 10, 2022 at 4:59 PM Łuk