[PATCH v2] configure: Fix default -O2 being added when CFLAGS not set

2022-03-28 Thread Glenn Washburn
Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS was defaulted to "" early in configure to prevent this. A recent commit ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the autoconf

Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set

2022-03-28 Thread Glenn Washburn
Hi Paul, On Fri, 25 Mar 2022 07:53:29 +0100 Paul Menzel wrote: > Dear Glenn, > > > Thank you for your tireless awesome work on GRUB. Sincerely, thank you. It seems to me that you're also deserving of this compliment and probably more so. > Am 24.03.22 um 23:31 schrieb Glenn Washburn: > > Au

Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set

2022-03-28 Thread Glenn Washburn
On Fri, 25 Mar 2022 11:54:59 -0400 Robbie Harwood wrote: > Glenn Washburn writes: > > > Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS > > was defaulted to "" early in configure to prevent this. Apparently something > > changed in autoconf and now AC_USE_SYSTEM_EXTE

[PATCH v2 2/3] Fix -Werror=array-bounds array subscript 0 is outside array bounds

2022-03-28 Thread Michael Chang via Grub-devel
The grub is failing to build with gcc-12 in many places like this: In function 'init_cbfsdisk', inlined from 'grub_mod_init' at ../../grub-core/fs/cbfs.c:391:3: ../../grub-core/fs/cbfs.c:345:7: error: array subscript 0 is outside array bounds of 'grub_uint32_t[0]' {aka 'unsigned int[]'} [-Wer

[PATCH v2 0/3] Fix GCC 12 build error

2022-03-28 Thread Michael Chang via Grub-devel
The tested gcc version is: abuild@mazu:~> gcc --version gcc (SUSE Linux) 12.0.1 20220307 (experimental) [revision 40c1d4a07e5798c01e4364336c9617550744861d] Copyright (C) 2022 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; n

[PATCH v2 3/3] reed_solomon: Fix array subscript 0 is outside array bounds

2022-03-28 Thread Michael Chang via Grub-devel
The grub_absolute_pointer() is a compound expression that can only work within a function. We are out of luck here when the pointer variables require global definition due to ATTRIBUTE_TEXT that have to use fully initialized global definition because of the way linkers work. static gf_single_t *

[PATCH v2 1/3] mkimage: Fix dangling pointer may be used error

2022-03-28 Thread Michael Chang via Grub-devel
The warning is real as long as dangling pointer to 'tmp_' may be used if o32 and o64 are both null. However that is not going to happen and can be ignored safely because the PE_OHDR is being used in a context that either o32 or o64 must have been properly initialized. Sadly compiler seems not to al