[PATCH] tests: Refactor building xorriso command for iso9660 tests

The iso9660 tests test creating isos with different combinations of joliet, rockridge, and iso9660 conformance level. Refactor xorriso argument generation for more readability and extensibility. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 43 +

[PATCH] configure: Fix misspelled variable BUILD_LDFAGS -> BUILD_LDFLAGS

Signed-off-by: Glenn Washburn --- I've been wondering why my build has been strangely failing for the last couple months and finally found the culprit. Quite an annoyance. I guess no one else actually uses BUILD_LDFLAGS. Glenn --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] Add Fedora location of DejaVu SANS font

On 12/7/21 15:04, Robbie Harwood wrote: Nicholas Vinson writes: Wouldn't it be better to modify configure.ac so the location could be passed in instead of having one-off patches for alternate locations? Something like --with-dejavu-font=/usr/share/fonts/dejavu-sans-fonts? That would mean tha

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

On Tue, 7 Dec 2021 23:07:32 +0100 Michael Schierl wrote: > > Hello Glenn, > > > Am 07.12.2021 um 22:59 schrieb Glenn Washburn: > > Yes, but I didn't want to assume that "all" is the first item in the > > list. > > More important, "all" does not have to be present at all. > > DEBUG=fat,btrfs,

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

Hello Glenn, Am 07.12.2021 um 22:59 schrieb Glenn Washburn: Yes, but I didn't want to assume that "all" is the first item in the list. More important, "all" does not have to be present at all. DEBUG=fat,btrfs,-fat should be perfectly legal (and it is). I decided that it doesn't make as

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

On Tue, 7 Dec 2021 22:01:14 +0100 Michael Schierl wrote: > Hello Glenn, > > > Am 07.12.2021 um 10:17 schrieb Glenn Washburn: > > >> maybe move the conditional before the assignment of ret? > > > > I'm understanding you to be suggesting to move the assignment of ret to > > after the if statemen

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

Hello Glenn, Am 07.12.2021 um 10:17 schrieb Glenn Washburn: maybe move the conditional before the assignment of ret? I'm understanding you to be suggesting to move the assignment of ret to after the if statement that follows it. Correct. The only point I see is saving an assignment in th

Re: [PATCH] Drop gnulib fix-base64.patch

Daniel Kiper writes: > On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote: >> Daniel Kiper writes: >> >> > Yeah, but I think it would require major overhaul. Does not it? If yes >> > then maybe we should consider move to the Kconfig or something like >> > that. >> >> Perhaps, but ple

Re: [PATCH] Add Fedora location of DejaVu SANS font

Nicholas Vinson writes: > Wouldn't it be better to modify configure.ac so the location could be > passed in instead of having one-off patches for alternate locations? > Something like --with-dejavu-font=/usr/share/fonts/dejavu-sans-fonts? That would mean that anyone using grub2 that wants the

Re: [PATCH v2] misc: Allow selective disabling of debug facility names

Hi Michael, Thanks for taking a look at this. On Mon, 6 Dec 2021 22:01:22 +0100 Michael Schierl wrote: > > Hello Glenn, > > Comments below, note that I did not test the patch so maybe I am missing > something. > > Am 06.12.2021 um 18:03 schrieb Glenn Washburn: > > > grub_debug_enabled (co