Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-12-01 Thread Glenn Washburn
On Thu, 18 Nov 2021 15:25:44 +0100 Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote: > > The member found_uuid was never used by the crypto-backends, but was used to > > Ha! Could you make this patch second in this patch series? Then we could > avoid carrying

Re: grub2 + xen + lz4 kernels

2021-12-01 Thread Juergen Gross via Grub-devel
On 01.12.21 20:24, Shaun Reitan wrote: Hi Daniel thanks for your reply!  You mentioned finding a new LZ4 library but grub2 already looks to support lz4 compressed kernels. The issue is that they don't look to be supported under the Xen platform with a target of x86_64. Grub does "support" lz4

Re: [PATCH v3 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

2021-12-01 Thread Glenn Washburn
On Thu, 18 Nov 2021 15:06:56 +0100 Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodisk.c | 26 +- > > grub-core/disk/geli.c | 9 - > > grub-core/disk/

Re: [PATCH v3 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

2021-12-01 Thread Glenn Washburn
On Sun, 14 Nov 2021 10:56:15 +0100 Patrick Steinhardt wrote: > On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodisk.c | 26 +- > > grub-core/disk/geli.c | 9 - > > grub-core

Re: [PATCH v3 2/4] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk

2021-12-01 Thread Glenn Washburn
On Wed, 17 Nov 2021 20:10:21 +0100 Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:26:27PM -0500, Glenn Washburn wrote: > > The crypto device modules should only be setting up the crypto devices and > > not getting user input. This has the added benefit of simplifying the code > > such that thre

Re: [PATCH v3 1/4] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

2021-12-01 Thread Glenn Washburn
On Wed, 17 Nov 2021 18:29:36 +0100 Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:26:26PM -0500, Glenn Washburn wrote: > > As an example, passing a password as a cryptomount argument is implemented. > > I am not very happy with that. Splitting this into separate patch or > merging with patch #

Re[2]: grub2 + xen + lz4 kernels

2021-12-01 Thread Shaun Reitan
Hi Daniel thanks for your reply! You mentioned finding a new LZ4 library but grub2 already looks to support lz4 compressed kernels. The issue is that they don't look to be supported under the Xen platform with a target of x86_64. I'm going to poke around on this today and see what I can figur

Re: [PATCH v2] fs/btrfs: Make extent item iteration to handle gaps

2021-12-01 Thread Daniel Kiper
On Thu, Oct 28, 2021 at 05:44:57PM +0800, Qu Wenruo via Grub-devel wrote: > [BUG] > Grub btrfs implementation can't handle two very basic btrfs file > layouts: > > 1. Mixed inline/regualr extents ># mkfs.btrfs -f test.img ># mount test.img /mnt/btrfs ># xfs_io -f -c "pwrite 0 1k" -c "sy

Re: [PATCH 1/6] mm: document grub internal memory management structures

2021-12-01 Thread Daniel Kiper
On Thu, Nov 25, 2021 at 02:22:45AM +1100, Daniel Axtens wrote: > I spent more than a trivial quantity of time figuring out pre_size and > whether a memory region's size contains the header cell or not. > > Document the meanings of all the properties. Hopefully now no-one else > has to figure it out

Re: [PATCH v2 2/2] Make a "gdb" dprintf that tells us load addresses

2021-12-01 Thread Daniel Kiper
On Wed, Dec 01, 2021 at 11:08:39AM -0500, Peter Jones wrote: > On Tue, Nov 30, 2021 at 05:08:20PM +0100, Daniel Kiper wrote: > > On Mon, Nov 29, 2021 at 06:11:36PM -0500, Robbie Harwood wrote: > > > Daniel Kiper writes: > > > > > > > On Wed, Nov 03, 2021 at 02:22:07PM -0400, Robbie Harwood wrote:

Re: [PATCH] Use full btrfs bootloader area

2021-12-01 Thread Daniel Kiper
On Tue, Nov 02, 2021 at 04:11:06PM +0800, Michael Chang via Grub-devel wrote: > Up to now grub can only embed to the first 64 KiB before primary s/grub/GRUB/ > superblock of btrfs, effectively limiting the size that could > consequently pose restrictions to feature enablement like advancing zstd

Re: [PATCH v2 2/2] Make a "gdb" dprintf that tells us load addresses

2021-12-01 Thread Peter Jones
On Tue, Nov 30, 2021 at 05:08:20PM +0100, Daniel Kiper wrote: > On Mon, Nov 29, 2021 at 06:11:36PM -0500, Robbie Harwood wrote: > > Daniel Kiper writes: > > > > > On Wed, Nov 03, 2021 at 02:22:07PM -0400, Robbie Harwood wrote: > > >> From: Peter Jones > > >> > > >> Add a grub_dprintf() call durin