Re: [PATCH v2 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

On Sun, 3 Oct 2021 21:16:09 +0200 Patrick Steinhardt wrote: > On Mon, Sep 27, 2021 at 06:14:02PM -0500, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodisk.c | 26 +- > > grub-core/disk/geli.c | 9 - > > grub-core/

Re: [PATCH v2 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

On Sun, 3 Oct 2021 22:22:40 +0200 Patrick Steinhardt wrote: > On Mon, Sep 27, 2021 at 06:14:03PM -0500, Glenn Washburn wrote: > > The member found_uuid was never used by the crypto-backends, but was used to > > determine if a crypto-backend successfully mounted a cryptodisk with a given > > uuid.

Re: [PATCH] luks2: Fix decoding of digests and salts with escaped chars

On Tue, Sep 28, 2021 at 12:55:24PM -0500, Glenn Washburn wrote: > On Tue, 28 Sep 2021 17:13:10 +0200 > Daniel Kiper wrote: > > > CC-ing Glenn... > > Thanks, I missed this > > > On Wed, Aug 11, 2021 at 08:55:32PM +0200, Patrick Steinhardt wrote: > > > It was reported in the #grub IRC channel tha

Re: [PATCH v2 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

On Mon, Sep 27, 2021 at 06:14:03PM -0500, Glenn Washburn wrote: > The member found_uuid was never used by the crypto-backends, but was used to > determine if a crypto-backend successfully mounted a cryptodisk with a given > uuid. This is not needed however, because grub_device_iterate will return 1

Re: [PATCH v2 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

On Mon, Sep 27, 2021 at 06:14:02PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cryptodisk.c | 26 +- > grub-core/disk/geli.c | 9 - > grub-core/disk/luks.c | 11 +-- > grub-core/disk/luks2.c | 6 +++

Re: [PATCH v2 2/4] cryptodisk: Refactor password input from crypto dev modules into cryptodisk

On Mon, Sep 27, 2021 at 06:14:01PM -0500, Glenn Washburn wrote: > The crypto device modules should only be setting up the crypto devices and > not getting user input. This has the added benefit of simplifying the code > such that three essentially duplicate pieces of code are merged into one. > >

Re: [PATCH v2 1/4] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

On Mon, Sep 27, 2021 at 06:14:00PM -0500, Glenn Washburn wrote: > As an example, passing a password as a cryptomount argument is implemented. > However, the backends are not implemented, so testing this will return a not > implemented error. > > Signed-off-by: Glenn Washburn > --- > grub-core/di

Grub2 Password complexity and verification with the old password

Hi， Currently, when changing the GRUB2 password, the old password is not verified and the password complexity is not checked. As a result, the GRUB2 password may be cracked by brute force. Does the community have any development plans for this? Recently I have been trying to develop code to veri