Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader

2021-08-29 Thread Heinrich Schuchardt
On 8/29/21 2:44 PM, Nikita Ermakov wrote: Btw, I have a minor suggestion [1] for your patch. AFAIK hartid terminology and /chosen/boot-hartid are RISC-V specifics. So, I think, we should not emit the warning and change DTB with a null boot-hartid value. If get_hartid is not defined then we should

Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader

2021-08-29 Thread Nikita Ermakov
Btw, I have a minor suggestion [1] for your patch. AFAIK hartid terminology and /chosen/boot-hartid are RISC-V specifics. So, I think, we should not emit the warning and change DTB with a null boot-hartid value. If get_hartid is not defined then we should, probably, just skip this boot-hartid thing