Re: RFC: A partition for grubenv, etc.

2021-05-26 Thread Chris Murphy
On Wed, May 26, 2021 at 3:17 AM Michael Chang via Grub-devel wrote: > > On Tue, May 25, 2021 at 04:58:23PM -0600, Chris Murphy wrote: > > Hi, > > > > It's not possible for GRUB pre-boot environment to write to grubenv > > when it's on Btrfs, ZFS, LVM, mdadm raid, or LUKS. Also, at least XFS > > up

Re: RFC: A partition for grubenv, etc.

2021-05-26 Thread Chris Murphy
On Wed, May 26, 2021 at 2:08 AM Konrad Rzeszutek Wilk wrote: > > On Tue, May 25, 2021 at 04:58:23PM -0600, Chris Murphy wrote: > > Hi, > > > > It's not possible for GRUB pre-boot environment to write to grubenv > > when it's on Btrfs, ZFS, LVM, mdadm raid, or LUKS. Also, at least XFS > > upstream

[PATCH v3] grub-core: Build fixes for i386

2021-05-26 Thread Jan (janneke) Nieuwenhuizen
This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux of grub-core/lib/i386/relocator64.S This file has six sections that only build with a 64-bit assembler, yet only the first two sections had support for a 32-bit assembler; this patch completes this for the remaining sections.

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-26 Thread Jan Nieuwenhuizen
Daniel Kiper writes: Hello, > Mostly nits... Please take a look below... Great! > On Tue, May 18, 2021 at 12:47:33PM +0200, Jan (janneke) Nieuwenhuizen wrote: >> To reproduce, update the Grub source description in your local Guix > > s/Grub/GRUB/ Ok. >> or install an x86 cross-build environme

Re: [PATCH v2] grub-core: Build fixes for i386

2021-05-26 Thread Daniel Kiper
Mostly nits... Please take a look below... On Tue, May 18, 2021 at 12:47:33PM +0200, Jan (janneke) Nieuwenhuizen wrote: > This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux. > > To reproduce, update the Grub source description in your local Guix s/Grub/GRUB/ > archive and run > >

Re: [PATCH] grub-mkpasswd-pbkdf2: Simplify the main function implementation

2021-05-26 Thread Daniel Kiper
Hi Tianjia, On Wed, May 26, 2021 at 04:38:33PM +0800, Tianjia Zhang wrote: > Hi Daniel, > > Please take the time to look at this patch. Thank you for the patch. I do not consider it as release material. So, I will take a look at this patch after release. Daniel _

Re: RFC: A partition for grubenv, etc.

2021-05-26 Thread Michael Chang via Grub-devel
On Tue, May 25, 2021 at 04:58:23PM -0600, Chris Murphy wrote: > Hi, > > It's not possible for GRUB pre-boot environment to write to grubenv > when it's on Btrfs, ZFS, LVM, mdadm raid, or LUKS. Also, at least XFS > upstream is super skeptical of anything except kernel code making any > kind of modi

Re: [PATCH] grub-mkpasswd-pbkdf2: Simplify the main function implementation

2021-05-26 Thread Tianjia Zhang
Hi Daniel, Please take the time to look at this patch. Thanks, Tianjia On 11/18/20 2:58 PM, Tianjia Zhang wrote: Allocate memory if needed, while saving the corresponding release operation, reducing the amount of code and code complexity. Signed-off-by: Tianjia Zhang --- util/grub-mkpasswd

Re: [PATCH] grub-mkpasswd-pbkdf2: Simplify the main function implementation

2021-05-26 Thread Tianjia Zhang
On 3/15/21 9:26 AM, Glenn Washburn wrote: On Sun, 14 Mar 2021 19:09:36 +0800 Tianjia Zhang wrote: ping. Thanks, Tianjia On 11/18/20 2:58 PM, Tianjia Zhang wrote: Allocate memory if needed, while saving the corresponding release operation, reducing the amount of code and code complexity.

Re: RFC: A partition for grubenv, etc.

2021-05-26 Thread Toomas Soome via Grub-devel
> On 26. May 2021, at 11:07, Konrad Rzeszutek Wilk > wrote: > > On Tue, May 25, 2021 at 04:58:23PM -0600, Chris Murphy wrote: >> Hi, >> >> It's not possible for GRUB pre-boot environment to write to grubenv >> when it's on Btrfs, ZFS, LVM, mdadm raid, or LUKS. Also, at least XFS >> upstream i

Re: RFC: A partition for grubenv, etc.

2021-05-26 Thread Konrad Rzeszutek Wilk
On Tue, May 25, 2021 at 04:58:23PM -0600, Chris Murphy wrote: > Hi, > > It's not possible for GRUB pre-boot environment to write to grubenv > when it's on Btrfs, ZFS, LVM, mdadm raid, or LUKS. Also, at least XFS > upstream is super skeptical of anything except kernel code making any > kind of modi