Re: [PATCH] grub-install: Add backup and restore

2021-05-04 Thread Daniel Kiper
Hey, In general much better but... On Thu, Apr 29, 2021 at 12:36:37PM +0100, Dimitri John Ledkov wrote: > Refactor clean_grub_dir to create a backup of all the files, instead > of just irrevocably removing them as the first action. If available, > register atexit handle to restore the backup if e

Re: [PATCH] unix exec: avoid atexit handlers when child execvp fails

2021-05-04 Thread Daniel Kiper
On Thu, Apr 29, 2021 at 12:34:34PM +0100, Dimitri John Ledkov wrote: > Functions `grub_util_exec_pipe()` and `grub_util_exec_pipe_stderr()` > currently call `execvp()`. If the call fails for any reason, the child > currently calls `exit(127)`. This in turn executes the parents > `atexit()` handlers

Re: [PATCH] grub-install: Add backup and restore

2021-05-04 Thread Dimitri John Ledkov
On Mon, May 3, 2021 at 6:09 AM Michael Chang via Grub-devel wrote: > > On Thu, Apr 29, 2021 at 12:36:37PM +0100, Dimitri John Ledkov wrote: > > Refactor clean_grub_dir to create a backup of all the files, instead > > of just irrevocably removing them as the first action. If available, > > register