[PATCH] usb: Use GRUB_USB_MAX_CONF macro instead of literal in hub for maximum configs

2021-03-18 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/bus/usb/usbhub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/bus/usb/usbhub.c b/grub-core/bus/usb/usbhub.c index a06cce302..85ccf3a4b 100644 --- a/grub-core/bus/usb/usbhub.c +++ b/grub-core/bus/usb/usbhub.c @@ -82,7

Re: [PATCH 0/5] serial: Add MMIO & SPCR support for AWS EC2 metal instances

2021-03-18 Thread Benjamin Herrenschmidt
On Thu, 2021-03-18 at 19:03 -0500, Glenn Washburn wrote: > > This was tested using SPCR on an actual c5.metal instance, and using > > explicit instanciation via serial -p mmio on a modified qemu > > hacked to create MMIO PCI serial ports. > > > When you say a modified qemu, was that a sou

Re: [PATCH v2 1/7] grub-core/bus/usb: Parse SuperSpeed companion descriptors

2021-03-18 Thread Glenn Washburn
Hi Patrick, I noticed some style issues while rebasing this code. Also this patch series now looks like it'll need a touch up when rebasing on to the release candidate (you might want to wait until the actual release comes out to send the next version). On Mon, 7 Dec 2020 08:41:21 +0100 Patrick

Re: [PATCH 0/5] serial: Add MMIO & SPCR support for AWS EC2 metal instances

2021-03-18 Thread Glenn Washburn
Hey Ben, On Fri, 19 Mar 2021 09:07:23 +1100 Benjamin Herrenschmidt wrote: > (Apologies if that got sent twice, there was an issue with my setup > yesterday causing it to be sent with the wrong From: line) > > This series adds support for the serial console of AWS EC2 "metal" x86 > instances to

[PATCH 3/5] ns8250: Add base support for MMIO UARTs

2021-03-18 Thread Benjamin Herrenschmidt
This adds the ability for the driver to access UARTs via MMIO instead of PIO selectively at runtime, and exposes a new function to add an MMIO port. Signed-off-by: Benjamin Herrenschmidt --- docs/grub.texi | 3 +- grub-core/term/ns8250.c | 78 -

[PATCH 4/5] ns8250: Add configuration parameter when adding ports

2021-03-18 Thread Benjamin Herrenschmidt
This will allow ports to be added with a pre-set configuration Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250.c | 25 +++-- grub-core/term/serial.c | 2 +- include/grub/serial.h | 4 ++-- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/gru

[PATCH 1/5] acpi: Export a generic grub_acpi_find_table

2021-03-18 Thread Benjamin Herrenschmidt
And convert grub_acpi_find_fadt to use it Signed-off-by: Benjamin Herrenschmidt --- grub-core/kern/acpi.c | 43 +-- include/grub/acpi.h | 3 +++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/grub-core/kern/acpi.c b/grub-core/kern/acpi

[PATCH 2/5] acpi: Add SPCR and generic address definitions

2021-03-18 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt --- include/grub/acpi.h | 51 + 1 file changed, 51 insertions(+) diff --git a/include/grub/acpi.h b/include/grub/acpi.h index 8c126b2b9..17aadb802 100644 --- a/include/grub/acpi.h +++ b/include/grub/acpi.h @@ -179,

[PATCH 5/5] ns8250: Use ACPI SPCR table when available to configure serial

2021-03-18 Thread Benjamin Herrenschmidt
"serial auto" is now equivalent to just "serial" and will use the SPCR to discover the port if present, otherwise defaults to "com0" as before. This allows to support MMIO ports specified by ACPI which is needed on AWS EC2 "metal" instances, and will enable grub to pickup the port configuration sp

[PATCH 0/5] serial: Add MMIO & SPCR support for AWS EC2 metal instances

2021-03-18 Thread Benjamin Herrenschmidt
(Apologies if that got sent twice, there was an issue with my setup yesterday causing it to be sent with the wrong From: line) This series adds support for the serial console of AWS EC2 "metal" x86 instances to grub. This requires two improvements: - Support for MMIO accesses to the 8250 serial p

[PATCH v2] i386-pc: build verifiers API as module

2021-03-18 Thread Michael Chang via Grub-devel
Given no core functions on i386-pc would require verifiers to work and the only consumer of the verifier API is the pgp module, it looks good to me that we can move the verifiers out of the kernel image and let moddep.lst to auto-load it when pgp is loaded on i386-pc platform. This helps to reduce

Re: [PATCH] i386-pc: build verifiers API as module

2021-03-18 Thread Michael Chang via Grub-devel
On Thu, Mar 18, 2021 at 09:23:40AM +, Colin Watson wrote: > On Thu, Mar 18, 2021 at 03:14:34PM +0800, Michael Chang via Grub-devel wrote: > > Given no core functions on i386-pc would require verifiers to work and > > the only consumer of the verifier API is the pgp module, it looks good > > to

Re: [PATCH v5 2/2] Document new limitations on MBR gap support

2021-03-18 Thread Colin Watson
On Fri, Dec 04, 2020 at 02:57:00PM +0100, Daniel Kiper wrote: > On Fri, Nov 13, 2020 at 09:28:16PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > From 4bd2f59773bec11ad7be1ced5b49edbf44d711f2 Mon Sep 17 00:00:00 2001 > > From: Vladimir Serbinenko > > Date: Tue, 10 Nov 2020 20:23:56 +0100 > > Subj

Re: [SECURITY PATCH 029/117] zstd: Initialize seq_t structure fully

2021-03-18 Thread Darren Kenny
Hi Paul, On Thursday, 2021-03-18 at 09:50:00 +01, Paul Menzel wrote: > Dear Darren, dear Daniel, > > > Am 02.03.21 um 19:00 schrieb Daniel Kiper: >> From: Darren Kenny >> >> While many compilers will initialize this to zero, not all will, > > Which ones do not? I have been working with C for a

Re: [PATCH] i386-pc: build verifiers API as module

2021-03-18 Thread Colin Watson
On Thu, Mar 18, 2021 at 03:14:34PM +0800, Michael Chang via Grub-devel wrote: > Given no core functions on i386-pc would require verifiers to work and > the only consumer of the verifier API is the pgp module, it looks good > to me that we can move the verifiers out of the kernel image and let > mo

Re: [SECURITY PATCH 000/117] Multiple GRUB2 vulnerabilities - 2021/03/02 round

2021-03-18 Thread Paul Menzel
Dear Darren, dear Darren, Am 02.03.21 um 19:00 schrieb Daniel Kiper: Thank you very much for finding and fixing all these issues, and coordinating the publication. […] .../lib/gnulib-patches/fix-null-state-deref.patch | 12 + .../gnulib-patches/fix-regcomp-uninit-token.patch | 15 +

Re: [SECURITY PATCH 029/117] zstd: Initialize seq_t structure fully

2021-03-18 Thread Paul Menzel
Dear Darren, dear Daniel, Am 02.03.21 um 19:00 schrieb Daniel Kiper: From: Darren Kenny While many compilers will initialize this to zero, not all will, Which ones do not? so it is better to be sure that fields not being explicitly set are at known values, and there is code that checks th

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-18 Thread John Paul Adrian Glaubitz
Hi! On 3/2/21 7:01 PM, Daniel Kiper wrote: > From: Peter Jones > > Add a init_pe_section() helper function to setup PE sections. This makes > the code simpler and easier to read. > > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Daniel Kiper This change

[PATCH] i386-pc: build verifiers API as module

2021-03-18 Thread Michael Chang via Grub-devel
Given no core functions on i386-pc would require verifiers to work and the only consumer of the verifier API is the pgp module, it looks good to me that we can move the verifiers out of the kernel image and let moddep.lst to auto-load it when pgp is loaded on i386-pc platform. This helps to reduce

Re: [SECURITY PATCH 001/117] verifiers: Move verifiers API to kernel image

2021-03-18 Thread Michael Chang via Grub-devel
On Thu, Mar 18, 2021 at 01:22:19AM +, Colin Watson wrote: > On Tue, Mar 02, 2021 at 07:00:08PM +0100, Daniel Kiper wrote: [snip] > I believe the practical threshold is 62 512-byte sectors, i.e. 31744 > bytes. > > As you can see, the biggest single change was induced by this patch, > which mo