Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

2020-10-29 Thread Glenn Washburn
On Fri, 23 Oct 2020 14:14:52 +0200 Daniel Kiper wrote: > On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > > Introduce new variables keyslot_key, digest_key, and segment_key > > which represent the integer key of the item in the respective > > associative array when looping over t

Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt.

2020-10-29 Thread Glenn Washburn
On Tue, 27 Oct 2020 19:03:36 +0100 Daniel Kiper wrote: > On Mon, Oct 19, 2020 at 06:09:55PM -0500, Glenn Washburn wrote: > > This should improve readability of code by providing clues as to > > what the value represents. > > > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodis

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-29 Thread Glenn Washburn
On Tue, 27 Oct 2020 20:11:56 +0100 Daniel Kiper wrote: > On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: > > On Mon, 21 Sep 2020 13:23:04 +0200 > > Daniel Kiper wrote: > > > > > On Mon, Sep 21, 2020 at 06:28:28AM +, Glenn Washburn wrote: > > > > Sep 8, 2020 7:21:31 AM Daniel

[PATCH] efi/tpm: Add debug information for device protocol and eventlog

2020-10-29 Thread Tianjia Zhang
Add a number of debug logs to the tpm module. The condition tag for opening debugging is `tpm`. On TPM machines, this will bring great convenience to diagnosis and debugging. Signed-off-by: Tianjia Zhang --- grub-core/commands/efi/tpm.c | 19 +++ 1 file changed, 15 insertions(+),

[PATCH] efi/tpm: Extract duplicate code into independent functions

2020-10-29 Thread Tianjia Zhang
Part of the code logic for processing the return value of efi log_extend_event is repetitive and complicated. Extract the repetitive code into an independent function. Signed-off-by: Tianjia Zhang --- grub-core/commands/efi/tpm.c | 55 +++- 1 file changed, 23 inse

Universal Payload Project

2020-10-29 Thread Paul Menzel
Dear coreboot, GRUB, and SeaBIOS folks, In #coreb...@irc.freenode.net somebody mentioned the Universal Payload Project [1]. The goal of this project is to define an interface between a first stage platform initialization bootloader and a second stage payload. As there also is a specification