Newbie doubts about GRUB memory allocation

2020-07-30 Thread Flávio Alberto
Hello all, I`m a newbie in grub code (reasonably experienced as user) and excuse-me if this isn´t the correct list to ask this question. I´m studying the GRUB allocation code because I want to write a module that finds the greatest (or a list of) free memory chunk on machine memory to write data on

Re: [PATCH 17/17] luks2: Fix use of incorrect index and some error messages.

2020-07-30 Thread Glenn Washburn
On Thu, 30 Jul 2020 22:22:41 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:22PM -0500, developm...@efficientek.com > wrote: > > From: Glenn Washburn > > > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/luks2.c | 14 +++--- > > 1 file changed, 7 insertions

Re: [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.

2020-07-30 Thread Glenn Washburn
On Thu, 30 Jul 2020 17:29:58 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:16PM -0500, developm...@efficientek.com > wrote: > > From: Glenn Washburn > > > > This makes the creates an alignment with grub_disk_t naming of the > > same field and is more intuitive as to how it sho

Re: [PATCH 07/17] cryptodisk,luks: Allow special processing for comparing UUIDs.

2020-07-30 Thread Glenn Washburn
On Thu, 30 Jul 2020 17:24:12 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:12PM -0500, developm...@efficientek.com > wrote: > > From: Glenn Washburn > > > > Create grub_uuidcasecmp to compare UUIDs in a case-insensitive > > manner and that ignores '-' characters. This is backw

Re: [PATCH 01/17] configure: Add Ubuntu dejavu font path.

2020-07-30 Thread Mike Gilbert
On Wed, Jul 29, 2020 at 6:08 PM David Michael wrote: > > On Wed, Jul 29, 2020 at 5:52 PM wrote: > > From: Glenn Washburn > > > > Signed-off-by: Glenn Washburn > > --- > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > >

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Atish Patra
On Thu, Jul 30, 2020 at 1:19 PM Heinrich Schuchardt wrote: > > Am 30. Juli 2020 22:11:39 MESZ schrieb Heinrich Schuchardt > : > >Am 30. Juli 2020 20:31:47 MESZ schrieb Atish Patra > >: > >>On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt > >> wrote: > >>> > >>> On 30.07.20 12:16, Sean Anderson

Re: [PATCH 06/17] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors.

2020-07-30 Thread Glenn Washburn
On Thu, 30 Jul 2020 17:21:16 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:11PM -0500, developm...@efficientek.com > wrote: > > From: Glenn Washburn > > > > The total_length field is named confusingly because length usually > > refers to bytes, whereas in this case its really

Re: [PATCH 05/17] luks: Add support for LUKS2 in (proc)/luks_script

2020-07-30 Thread Glenn Washburn
On Thu, 30 Jul 2020 17:14:54 +0200 Patrick Steinhardt wrote: > >{ > > - size += sizeof ("luks_mount "); > > + size += grub_strlen (i->modname); > > + size += sizeof ("_mount"); > > size += grub_strlen (i->uuid); > > size += grub_strlen (i->cipher->cipher->name); > > - size

Re: [PATCH 17/17] luks2: Fix use of incorrect index and some error messages.

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:22PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn > > Signed-off-by: Glenn Washburn > --- > grub-core/disk/luks2.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/grub-core/disk/luks2.c b/grub-core/disk/l

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Heinrich Schuchardt
Am 30. Juli 2020 22:11:39 MESZ schrieb Heinrich Schuchardt : >Am 30. Juli 2020 20:31:47 MESZ schrieb Atish Patra >: >>On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt >> wrote: >>> >>> On 30.07.20 12:16, Sean Anderson wrote: >>> > On 7/30/20 6:03 AM, Heinrich Schuchardt wrote: >>> >> Dear Sean,

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Heinrich Schuchardt
Am 30. Juli 2020 20:31:47 MESZ schrieb Atish Patra : >On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt > wrote: >> >> On 30.07.20 12:16, Sean Anderson wrote: >> > On 7/30/20 6:03 AM, Heinrich Schuchardt wrote: >> >> Dear Sean, >> >> >> >> when trying to run grubriscv64.efi from the >> >> trini/u

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Atish Patra
On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt wrote: > > On 30.07.20 12:16, Sean Anderson wrote: > > On 7/30/20 6:03 AM, Heinrich Schuchardt wrote: > >> Dear Sean, > >> > >> when trying to run grubriscv64.efi from the > >> trini/u-boot-gitlab-ci-runner:bionic-20200526-18Jun2020 Docker image

Re: [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:16PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn > > This makes the creates an alignment with grub_disk_t naming of the same > field and is more intuitive as to how it should be used. > > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cr

Re: [PATCH 09/17] fs: When checking if a block list goes past the end of the disk, make sure the total size of the disk is in grub native sector sizes, otherwise there will be blocks at the end of the

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:14PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn The commit message header is quite long. Could you please shorten it to at most 80 characters and maybe put remaining info into the message body? > > Signed-off-by: Glenn Washburn > --- > grub-

Re: [PATCH 07/17] cryptodisk,luks: Allow special processing for comparing UUIDs.

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:12PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn > > Create grub_uuidcasecmp to compare UUIDs in a case-insensitive manner and > that ignores '-' characters. This is backwards compatible with the old LUKS1 > code that stored and compared against

Re: [PATCH 06/17] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors.

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:11PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn > > The total_length field is named confusingly because length usually refers to > bytes, whereas in this case its really the total number of sectors on the > device. Also counter-intuitively, grub

Re: [PATCH 05/17] luks: Add support for LUKS2 in (proc)/luks_script

2020-07-30 Thread Patrick Steinhardt
On Wed, Jul 29, 2020 at 04:50:10PM -0500, developm...@efficientek.com wrote: > From: Glenn Washburn > > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cryptodisk.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/grub-core/disk/cryptodisk.c b/g

Re: [PATCH] Makefile.util.def: Remove unused define GRUB_PKGLIBDIR

2020-07-30 Thread Jacob Kroon
On 6/20/20 3:01 PM, Jacob Kroon wrote: Signed-off-by: Jacob Kroon --- Makefile.util.def | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.util.def b/Makefile.util.def index d9e2bd84d..f8b356cc1 100644 --- a/Makefile.util.def +++ b/Makefile.util.def @@ -203,7 +203,6 @@ program = {

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Heinrich Schuchardt
On 30.07.20 12:16, Sean Anderson wrote: > On 7/30/20 6:03 AM, Heinrich Schuchardt wrote: >> Dear Sean, >> >> when trying to run grubriscv64.efi from the >> trini/u-boot-gitlab-ci-runner:bionic-20200526-18Jun2020 Docker image on >> a MAIXDUINO the relocations are not naturally aligned: >> >> lib/efi