Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Dimitri John Ledkov
On Tue, 2 Jun 2020, 13:53 Vladimir 'phcoder' Serbinenko, wrote: > > > On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > >> On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko >> wrote: >> > >> > >> > >> > On Mon, Jun 1, 2020, 15:21 Chris Coulson >> wrote: >> >> >> >> When a file i

Re: [RFC PATCH 3/3] efi: mm: implement runtime addition of pages

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 1, 2020, 21:34 Patrick Steinhardt wrote: > Adjust the interface of `grub_efi_mm_add_regions ()` to take a set of > `GRUB_MM_REGION_*` flags, which most notably is currently only the > `CONSECUTVE` flag. This allows us to set the function up as callback for > the memory subsystem and h

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson > wrote: > >> > >> When a file is verified, the entire contents of the verified file are > >> loaded in to memory

Re: [PATCH] tests: remove cmdline_cat and gfxterm_menu tests

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 2, 2020, 10:40 Daniel Axtens wrote: > cmdline_cat takes a checksum of a screen that includes the grub > version number, so it has been broken since commit 94d9926a6640 > ("Release 2.04~rc1"). That was in April 2019. > > I have not been able to get the gfxterm_menu tests to pass under

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Dimitri John Ledkov
On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko wrote: > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: >> >> When a file is verified, the entire contents of the verified file are >> loaded in to memory and retained until the file handle is closed. A >> consequence of this is th

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: > When a file is verified, the entire contents of the verified file are > loaded in to memory and retained until the file handle is closed. A > consequence of this is that opening a loopback image can incur a > significant memory cost. > > As loopba

[PATCH] tests: remove cmdline_cat and gfxterm_menu tests

2020-06-02 Thread Daniel Axtens
cmdline_cat takes a checksum of a screen that includes the grub version number, so it has been broken since commit 94d9926a6640 ("Release 2.04~rc1"). That was in April 2019. I have not been able to get the gfxterm_menu tests to pass under any configuration. These tests aren't providing any extra