Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-20 Thread Patrick Steinhardt
On Wed, Feb 12, 2020 at 08:18:32AM +0100, Milan Broz wrote: > On 11/02/2020 22:53, Daniel Kiper wrote: > > On Thu, Feb 06, 2020 at 03:27:28PM +0100, Patrick Steinhardt wrote: > >> - The import of Argon2 itself. I've imported code from the > >> cryptsetup project, but I've modified it quit

Re: [PATCH 1/5] efi: Allocate half of available memory by default

2020-02-20 Thread Patrick Steinhardt
On Thu, Feb 13, 2020 at 11:47:54AM +, Leif Lindholm wrote: > On Thu, Feb 06, 2020 at 15:27:29 +0100, Patrick Steinhardt wrote: > > By default, GRUB will allocate a quarter of the pages it got available > > in the EFI subsystem. On many current systems, this will amount to > > roughly 800MB of R

Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2

2020-02-20 Thread Leif Lindholm
Hi Patrick, On Thu, Feb 20, 2020 at 19:00:48 +0100, Patrick Steinhardt wrote: > this is the second version of my patchset to add support for Argon2 > encryption keys for LUKS2. > > The most important change is that I've now verbosely imported the argon2 > code from the official reference implemen

[PATCH v2 6/6] luks2: Support key derival via Argon2

2020-02-20 Thread Patrick Steinhardt
One addition with LUKS2 was support of the key derival function Argon2 in addition to the previously supported PBKDF2 algortihm. In order to ease getting in initial support for LUKS2, we only reused infrastructure to support LUKS2 with PBKDF2, but left out Argon2. This commit now introduces suppor

[PATCH v2 5/6] luks2: Discern Argon2i and Argon2id

2020-02-20 Thread Patrick Steinhardt
While GRUB is already able to parse both Argon2i and Argon2id parameters from the LUKS2 header, it doesn't discern both types. This commit introduces a new KDF type for Argon2id and sets up the parsed KDF's type accordingly. Signed-off-by: Patrick Steinhardt --- grub-core/disk/luks2.c | 13 +

[PATCH v2 3/6] argon2: Import Argon2 from cryptsetup

2020-02-20 Thread Patrick Steinhardt
In order to support the Argon2 key derival function for LUKS2, we obviously need to implement Argon2. It doesn't make a lot of sense to hand-code any crypto, which is why this commit instead imports Argon2 from the cryptsetup project. This commit thus imports the code from the official reference im

[PATCH v2 2/6] types.h: add UINT-related macros needed for Argon2

2020-02-20 Thread Patrick Steinhardt
For the upcoming import of the Argon2 library, we need the macros GRUB_UINT32_MAX, GRUB_UINT32_C and GRUB_UINT64_C. Add them as a preparatory step. Signed-off-by: Patrick Steinhardt --- include/grub/types.h | 8 1 file changed, 8 insertions(+) diff --git a/include/grub/types.h b/includ

[PATCH v2 0/6] Support Argon2 KDF in LUKS2

2020-02-20 Thread Patrick Steinhardt
Hi, this is the second version of my patchset to add support for Argon2 encryption keys for LUKS2. The most important change is that I've now verbosely imported the argon2 code from the official reference implementation instead of from the cryptsetup project. The diff between both isn't that big

[PATCH v2 1/6] efi: Allocate half of available memory by default

2020-02-20 Thread Patrick Steinhardt
By default, GRUB will allocate a quarter of the pages it got available in the EFI subsystem. On many current systems, this will amount to roughly 800MB of RAM assuming an address space of 32 bits. This is plenty for most use cases, but it doesn't suffice when using full disk encryption with a key d

[PATCH v2 4/6] luks2: Add missing newline to debug message

2020-02-20 Thread Patrick Steinhardt
The debug message printed when decryption with a keyslot fails is missing its trailing newline. Add it to avoid mangling it with subsequent output. Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper --- grub-core/disk/luks2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed

2020-02-20 Thread John Paul Adrian Glaubitz
Hi Mike! On 2/20/20 7:51 AM, Matt Turner wrote: > PIE should be disabled in assembly sources as well, or else grub will > fail to boot. Indeed. We have always passed -fno-PIE on Debian/sparc64 in the debian/rules file to TARGET_CCASFLAGS, but it makes more sense to fix the issue in the configure.

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-20 Thread Patrick Steinhardt
On Thu, Feb 13, 2020 at 12:42:59PM +0100, Daniel Kiper wrote: > On Wed, Feb 12, 2020 at 08:47:49AM +0100, Patrick Steinhardt wrote: > > On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote: > > > > GRUB's codebase. This included both stripping off unneeded > > > > functionality

Re: GRUB 2.06 release

2020-02-20 Thread John Paul Adrian Glaubitz
Hi! On 2/19/20 4:01 PM, Daniel Kiper wrote: > As I told during my FOSDEM 2020 presentation we are preparing for > GRUB 2.06 release. Tentative schedule is below: > - code freeze: 15th of March, 23:59:59 UTC; everything posted after > that date will not be considered as a release material, >